Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp1073107lqb; Wed, 17 Apr 2024 21:57:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXtyxyHQLMBTCvCXw0xo2VIXby8WPo6KXVm9pBodisDDHVwo4ynpU3RmoL0QnK8Nhgac7+hpXWRt68AcUton167SVmbpzjFyrUh6sYJ2g== X-Google-Smtp-Source: AGHT+IHSdE1y2MRJzwah0mBPtpb6T/O98HnNyKOIM4QANFvzY5/xK9k2e24tIdGlkVDgPlsgaHdV X-Received: by 2002:a05:6214:2e12:b0:699:2db7:f5de with SMTP id mx18-20020a0562142e1200b006992db7f5demr1810879qvb.2.1713416238072; Wed, 17 Apr 2024 21:57:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713416238; cv=pass; d=google.com; s=arc-20160816; b=SS5h9Cun0xKxeryXB8d/uA1n68xAF7GLH5MbMo4GI4Ay2IUEhTE/Cvr5IGylDp/oyQ U0smK+sCDlqcH1/ITEqj/6W3znjB4fTkMjHl8gUKXbt1vHrG+fweGpR/EJJ+B37PY9gS MUTxOF1dLIayk12MN8w6kDbHzdSwCty29pHIE/dqZJMt/tzIaYNY3Lgr4rPtZaHQ539t WYF8nRIBx+7LRaadvSshc4IIhTAP0Vy4pFjmyBpUJnKZTTnUt5zN1bA0mb6FxgCwz3tw Pcig4iIR1DfoZDuoQGbrdbJWWYMxD6AZsMKzGeQfQ5cj6oEiG7E2HASWD2qtgKiqjvKU nFYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JyUZV0e9ROSp0RhnA+Pw7XIu/qwjFprUf8qcldrWdDA=; fh=QadPeIrdjH8PhLrQ6eDfIPQ0SSwg4Fxcrkhm6rWtbAo=; b=l5KAbC6Zk7lENuSY/38tLDIut61rcy4wQEG7jO9gEmvk0XUpDdWgONV8bjkrwyVJM/ eMUwMxaX/YLIQF78p4qcRLKK2poIfGfOerS6j7DTXtheDYibr1/u9jQH4PlellquB7KW sSns6NfZVdf8AYsrzuEuBVOy2xeod7x+RmRwhM9VQ38UuLPWpTejoHw754xdHGNjZPGk 9KOE6SXuzE9AEIFOQDFVEAl0gJYxbSpW+4OxBntNS2S/cOGNggqB5r7f27/kVMhCsmwb BNltTnA42aP4bFv8JHY5vZju9DYZqgexbrI1JQwoldp5gibq5pYaWQM1JA04k5RDDsxh Y88Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=GS3sXpbi; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-149510-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149510-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id gu15-20020a056214260f00b00699462a7385si716663qvb.308.2024.04.17.21.57.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 21:57:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-149510-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=GS3sXpbi; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-149510-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149510-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C72A51C219E1 for ; Thu, 18 Apr 2024 04:57:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 57FC154BFB; Thu, 18 Apr 2024 04:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GS3sXpbi" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BABB3548EA; Thu, 18 Apr 2024 04:57:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713416228; cv=none; b=l2jIJUMt2b5ET62VEul4WQR3TryBeLRYJsRr9QjAhUPscITxqoub519ApyKKzIb1m8HqGofKAxggpEKExOJAdNSPx+AbzY4fFVlLLCreVKUXwBVrCSJ/sygx4woVP51qwmUcbuefm/9yYqi0/1gEyLPPMvt+9TWgjwMPkHJnAl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713416228; c=relaxed/simple; bh=bORzf0CPuk0CeUEBeV/TNqqTD59zUbx3CnM4lpUTj8g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iFSZBMMIpGxyu3EppEve+wX+dK/8n9l3gV32YW0DUsGgT5Qge02xVg/Lm1w9AtQfhV7KuIoifWR/2wn7pkB93S2GCmMt9LC+1eaV+te+KWalA18dBuTq9SXkl+5csQfnZnznjew8rboN3wwhMpTItzZ5hKOIhtCMp4KgkDub0WE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=GS3sXpbi; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JyUZV0e9ROSp0RhnA+Pw7XIu/qwjFprUf8qcldrWdDA=; b=GS3sXpbi7PpYkegn/egJYDClE/ JMGSgJt6XhyfRxBAx+pCWVTbH4S+DqpHkWxf8YX+d0f/SngQi2SRWwQQoDNu6aaOjD2flVulkC3TE G3y6lOsHaYhsTXlEyEavTxZj3jpkKO8KCZJAZnI/TRGK+xcg4bGcLZWuQWkw1ch5XSQWgVVR7DB25 HBJtpxa8l+MA98+KDQJ7WngPzUYfy1CQVWKeHg7iPMJ3MfcqnOG/Yzv5HCcRbla8jbw+J5X6tFsdG h+Byz9IYBkvGAsoxmgkGjvzE6AGG4Uv+a9wZbzMv7lagbdXaa5N1rHYUL4EyAppfSiT0cGriVo8Lg 3C60d2qQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxJpY-00000000wgH-2Vqw; Thu, 18 Apr 2024 04:57:04 +0000 Date: Wed, 17 Apr 2024 21:57:04 -0700 From: Christoph Hellwig To: Mikulas Patocka Cc: Peter Zijlstra , Mike Snitzer , Jens Axboe , Damien Le Moal , Ingo Molnar , Will Deacon , Waiman Long , Guangwu Zhang , dm-devel@lists.linux.dev, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] completion: move blk_wait_io to kernel/sched/completion.c Message-ID: References: <31b118f3-bc8d-b18b-c4b9-e57d74a73f@redhat.com> <20240417175538.GP40213@noisy.programming.kicks-ass.net> <546473fd-ca4b-3c64-349d-cc739088b748@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <546473fd-ca4b-3c64-349d-cc739088b748@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Wed, Apr 17, 2024 at 08:00:22PM +0200, Mikulas Patocka wrote: > > > +EXPORT_SYMBOL(wait_for_completion_long_io); > > > > Urgh, why is it a sane thing to circumvent the hang check timer? > > The block layer already does it - the bios can have arbitrary size, so > waiting for them takes arbitrary time. And as mentioned the last few times around, I think we want a task state to say that task can sleep long or even forever and not propagate this hack even further.