Received-SPF: pass (google.com: domain of linux-kernel+bounces-149556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <54A57FB24C5E1752+669a5f22-b9fc-4cb6-8df5-367331dc4658@radxa.com>
Date: Thu, 18 Apr 2024 15:13:17 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: add Radxa ROCK3 Model C
To: Chukun Pan <amadeus@jmu.edu.cn>, Heiko Stuebner <heiko@sntech.de>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20240416130010.379705-1-amadeus@jmu.edu.cn>
Content-Language: en-US
From: FUKAUMI Naoki <naoki@radxa.com>
In-Reply-To: <20240416130010.379705-1-amadeus@jmu.edu.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Feedback-ID: bizesmtpsz:radxa.com:qybglogicsvrgz:qybglogicsvrgz6a-0

Hi,

On 4/16/24 22:00, Chukun Pan wrote:
> The Radxa ROCK3 Model C is a similar board to
> the Radxa ROCK3 Model A with the RK3566 SoC.
> Add devicetree binding documentation for it.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>   Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 99bd5e2c76a0..dc3847bd67fe 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -777,6 +777,11 @@ properties:
>             - const: radxa,rock3a
>             - const: rockchip,rk3568
>   
> +      - description: Radxa ROCK3 Model C

please use "Radxa ROCK 3C" here too.

> +        items:
> +          - const: radxa,rock3c

and "rock-3c" here.

> +          - const: rockchip,rk3566
> +
>         - description: Radxa ROCK 5 Model A
>           items:
>             - const: radxa,rock-5a

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.