Received-SPF: pass (google.com: domain of linux-kernel+bounces-149566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <489a558f-8f56-4342-9396-544a4b8ff8c3@linux.alibaba.com>
Date: Thu, 18 Apr 2024 14:16:50 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH] sched/eevdf: Return leftmost entity in pick_eevdf()
 if no eligible entity is found
Content-Language: en-US
To: Chen Yu <yu.c.chen@intel.com>
Cc: Xuewen Yan <xuewen.yan94@gmail.com>, Peter Zijlstra
 <peterz@infradead.org>, Abel Wu <wuyun.abel@bytedance.com>,
 Ingo Molnar <mingo@redhat.com>, Vincent Guittot
 <vincent.guittot@linaro.org>, Juri Lelli <juri.lelli@redhat.com>,
 Tim Chen <tim.c.chen@intel.com>, Tiwei Bie <tiwei.btw@antgroup.com>,
 Honglei Wang <wanghonglei@didichuxing.com>, Aaron Lu <aaron.lu@intel.com>,
 Chen Yu <yu.chen.surf@gmail.com>, Yujie Liu <yujie.liu@intel.com>,
 linux-kernel@vger.kernel.org, kernel test robot <oliver.sang@intel.com>
References: <ZiCOybMoVyNK6gPT@chenyu5-mobl2>
 <c3959f3e-ca17-4c27-9dd2-504b95f2653c@linux.alibaba.com>
 <ZiC1LuqGAXGHgeDo@chenyu5-mobl2>
From: Tianchen Ding <dtcccc@linux.alibaba.com>
In-Reply-To: <ZiC1LuqGAXGHgeDo@chenyu5-mobl2>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/4/18 13:52, Chen Yu wrote:
> On 2024-04-18 at 11:37:31 +0800, Tianchen Ding wrote:
>> Hi, we've found a bug about reweight_eevdf(). Would you also please try this
>> patchset?
>>
>> https://lore.kernel.org/all/20240306022133.81008-1-dtcccc@linux.alibaba.com/
>>
> 
> Sure, I'll have a try after I test Xuewen's patch. I assume your fix is mainly in
> 2/2 which adjusts the se->vruntime in reweight_eevdf() by using the correct
> avg_vruntime(), although it might not be directly related to the s64 overflow issue
> here, it is worthy a fix.
> 

Yes. I'm hoping to reduce "noises" about the unexpected avg_vruntime() varying 
during your tests.

Thanks.