Received-SPF: pass (google.com: domain of linux-kernel+bounces-149643-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 18 Apr 2024 08:18:59 +0100
Message-ID: <8734rjrvdo.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: 	tglx@linutronix.de,  Guanrui Huang <guanrui.huang@linux.alibaba.com>
Cc:	yuzenghui@huawei.com,
	shannon.zhao@linux.alibaba.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] irqchip/gic-v3-its: Fix double free on error 
In-Reply-To: <20240418061053.96803-1-guanrui.huang@linux.alibaba.com>
References: <20240418061053.96803-1-guanrui.huang@linux.alibaba.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Thu, 18 Apr 2024 07:10:51 +0100,
Guanrui Huang <guanrui.huang@linux.alibaba.com> wrote:
> 
> Hello everyone, this is the v5 of the patch to fix double free 
> in gic driver.
> 
> The differences from the v3 and v4:
> 1. modify description: add "Fixes" in patch 1, as suggested by Markus Elfring.
> 
> 2. improve patch granularity: split 'remove BUG_ON' into a secord patch, 
>    as suggested by Zenghui and Markus Elfring.
> 
> 3. modify description: explain why the BUG_ON is useless in patch 2, 
>    as suggested by Marc Zyngier.
> 
> Thanks,
> Guanrui
> 
> Guanrui Huang (2):
>   irqchip/gic-v3-its: Fix double free on error
>   irqchip/gic-v3-its: remove BUG_ON in its_vpe_irq_domain_alloc
> 
>  drivers/irqchip/irq-gic-v3-its.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 

Thomas, can you please take this in for 6.10?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.