Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp1129953lqb; Thu, 18 Apr 2024 00:27:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUGZRifJLxTSqQYW9RBtv23rgwJ+iuBpnQJHhkLGXVX+urOxv+IBUgK6oSv9mZrJxsyDXfPw7/ypByCXeWpT98GdMco9jeXp3YgklCebg== X-Google-Smtp-Source: AGHT+IGTMMuezEBm0D0Mh/UGLL9AMV6IzK/Tu7S86mFMblyeVD3tTcJ956AisZ+iSjGB/Mr3kcrE X-Received: by 2002:a05:6a00:21c2:b0:6ed:7684:484b with SMTP id t2-20020a056a0021c200b006ed7684484bmr1985075pfj.27.1713425223139; Thu, 18 Apr 2024 00:27:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713425223; cv=pass; d=google.com; s=arc-20160816; b=Gffdexjbr/exHH58LGjN7xhv1LxxaKbTvuLIcXrqQgz5TvKL9gtfhELQrdNtzlKNLW hKfeJE9PJHgP8UsHKyToyfXVTRZf473+UwY/7I5xI/HfC8Dm4/VRSZpeTyNmaAj8F5w1 XaxZef4pqM1ORKLIQNerdVupqY5bCuS7gJAcvvC4AzO9bJNLpsDP6hd5TmjTvf0ZxG8Q o/GAW82pZjMDbsku6Fv6R/ryXP7Ej9R/IyEKyK0V6Z4qt7q4CUaneaAHQPVdPPV9jm5g /9imJL+Z2uJG2iFdzEKIMJu0Q2BcRMguK01OxyW3glH3r4xU/V6teFvnSsP7zj8WJ/Ln g6xw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=f/kljw3WIu9Nyid/c/jp8gr+BElyOPqDQkGlBVNzXGU=; fh=f1lcg3AcMosKoC9NulbREMQjfpqdBQi2zxvt8/eXnO4=; b=BnyQngkTFTxPvGDiHZ+T4fPrAhU1TTlbE39aUukNFXnbpDS9IpLL7TZbfzoi8NyDst PRynMsE4ITkxuWoZ95nsc9ulobv6HodP/E9Z+bZyXi9jLaGR/8klZ3QWIIqfH3UERKrB +kdg6ZghfvX/EkjA8FpMpYuuQwPg04VOeyeS1TeeR08+19m79xCMdMQtRDoqLX4lmJr/ btOJCC7tguEnBT0lCH3y40futcobXuPW+0vTokUJcGvWmQ49bKKeQg3rPV0LW0yeYikH X5Le1wfoAqEgAotcGqL4FEdOIB4RAJbYL+00GtzIFWfxjDtrKLl6bIIDvzoQ0CV4G6jE 3MVA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=T4t341uu; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-149404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149404-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id jc33-20020a056a006ca100b006eadf481e9bsi996644pfb.13.2024.04.18.00.27.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 00:27:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-149404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=T4t341uu; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-149404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149404-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 75594283155 for ; Thu, 18 Apr 2024 01:31:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8ED4E3A1C7; Thu, 18 Apr 2024 01:30:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="T4t341uu" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C3BC3BBD4; Thu, 18 Apr 2024 01:30:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713403850; cv=none; b=CNL4TO4FOzcoJrBMhHHLkmvdQoMQ5hzN3ereiGhAaG26Kv9rC0qdRgZYr2+U1O4A07D3kvoYnvtvGJ5YgoL6RSUwqTJm5kTWY6bM1mspbn11+2tSV6TY/auksVOU8RGGIhRS9hDvegkhJuZ0VoQn9uSBT6Ut247es6XANl24D6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713403850; c=relaxed/simple; bh=JjynidKEZFAxpHdume9tSkQsH7/8Xm3xZGDHoj+Wf5k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fLKuMnza7mVgzpVKuTDVZnyi8lqunabDUtzJhK3CaCB/MTKB0cuyvFYLxxLV2sSghJgEWCfVYjWZrhs90eD0GdxmWGpnR+TSli9HQNH93p8VWrHJL6qa3UYaOi1KJew2AAF98F8+gW/Ud4Sph7Z58o95BYzn41JVsT4l97HwExU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=T4t341uu; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f/kljw3WIu9Nyid/c/jp8gr+BElyOPqDQkGlBVNzXGU=; b=T4t341uuJ0iIcv6IObZnoplnuJ QvhQzlNIlkOP4kKYvsiTJks0GDoV9FzODjn0K+hp0MPz69D4xaTqXXV9ypP7Sp1Z54hYdySib553E ZN625x+8mgnSHU5tHI6U/ky8oq6HQEGea1BvdVtxhK85KcCtRHQpr7Qa8UOx+iiJPBLtOcDf14YM+ S1rBvQETqdH0jvAnzTCN5iqpFKRwdkDjInBdACC6KlM7ZNZFNyE3kf8Wh8EyoJntAPHb7I2hT6mKv Qku9qDciTYw2zgQ8ilYqfd8ByFhUwO82c1DoisITx0u+0pKjW4yAsw9osfl9ZfBz5rPYyI3+ULfch 3NFXKg5g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxGbW-00000004DjD-3q35; Thu, 18 Apr 2024 01:30:23 +0000 Date: Thu, 18 Apr 2024 02:30:22 +0100 From: Matthew Wilcox To: Xiubo Li Cc: Kairui Song , linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ilya Dryomov , Jeff Layton , ceph-devel@vger.kernel.org Subject: Re: [PATCH 4/8] ceph: drop usage of page_index Message-ID: References: <20240417160842.76665-1-ryncsn@gmail.com> <20240417160842.76665-5-ryncsn@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 18, 2024 at 08:28:22AM +0800, Xiubo Li wrote: > Thanks for you patch and will it be doable to switch to folio_index() > instead ? No. Just use folio->index. You only need folio_index() if the folio might belong to the swapcache instead of a file.