Received-SPF: pass (google.com: domain of linux-kernel+bounces-149680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 18 Apr 2024 10:51:28 +0300
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Camelia Groza <camelia.groza@nxp.com>,
	David Gouarin <dgouarin@gmail.com>, david.gouarin@thalesgroup.com,
	Madalin Bucur <madalin.bucur@nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org
Subject: Re: [PATCH net v4] dpaa_eth: fix XDP queue index
Message-ID: <20240418075128.m4v4f3nlrzn3qlfl@skbuf>
References: <20240410194055.2bc89eeb@kernel.org>
 <20240411113433.ulnnink3trehi44b@skbuf>
 <20240417181734.7ebc844f@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417181734.7ebc844f@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PnftYX6FQYtdWWLpsLnhHIFIhrvcCF+ekGzFuQdi3zJU6D44BNUGcQERO2Fg?=
 =?us-ascii?Q?uDm89zJ3gxBrY5guRTarNrqRJqDQAEyzK5UWksN7vr+JTqQSOdew7XqkY8Ks?=
 =?us-ascii?Q?YrN8pRPnukdIBYbmHCucUWTUcSnJvuyqaUqOWGXm5DMw51o491sRiCMCU4e4?=
 =?us-ascii?Q?0f/pCBd1PbV2b+MbrWKjnhUGU6lUTNdnZ66wBOgpwAgfDKTTwxwnDuP58ctG?=
 =?us-ascii?Q?zYAJ+7L64oZ4A7F+FJVknGTK53ryTrWAp1pvQq1JRIlDrZ3V1hoFhN8d/fxh?=
 =?us-ascii?Q?NKjiMtSB/2WR8iTtjCrDOIrWygMeJfOfXSICfsEzonlmaqWfh9OZ/jXNOi5S?=
 =?us-ascii?Q?S7+DK6rfRUeJ20U2o9mWZK3OXpgBGjS4NKZ7WYiimrTVBJC6b9MyeOBzAsD9?=
 =?us-ascii?Q?ebQhC5Xy5P4QdNU7Z2NAtDUitZkOwu5kQzY/9K4WeHaX8wcmPC5A6Rd/rR7A?=
 =?us-ascii?Q?zfVVgecjwD7g5zPUNzeRJX6zG6nTz0opB0BB4w8k7+6H8/GGBVM5t7wdkZ+Q?=
 =?us-ascii?Q?BaTusix+IXJEzzfkYG5ayrTVl+d7Fm9YqxApWEoJoRKTNLRO99k6g1TkbtQJ?=
 =?us-ascii?Q?hZvQPUxJs0JJ6a0s7Rpamp93/JkUcrzmtdPAWn1oEbTZQlGLi/joU56qCxIH?=
 =?us-ascii?Q?9195biybSidz1g3VFpmCYXfZIu7bEECYDiB8IxR4I1CF+ZYfPXMWyWlvZPFb?=
 =?us-ascii?Q?KLhWI8WNXxZLuDuKPgK3x7ivS+IA2NCmOPR8nwyPH3uj5iVDFtRttBcO9uH3?=
 =?us-ascii?Q?Tfl3e2CXngOlUhdc0D5y7vEASX7A7FJKslLHs1nvfUbtLJdIN7Acr/MTpzIW?=
 =?us-ascii?Q?OImYUqqdWfQShA6qj5cd51OXvJ341liGS+Ctj50EJ48K6ayLkdXGcuiztrq2?=
 =?us-ascii?Q?192bFAwrGlg9DibU11MkMK7A6i+1N7+WCHfzTCueGmRStIdas2MaRqnQA6NV?=
 =?us-ascii?Q?aVhRqc5L6/F1Z9wVtjx/sZmLHO1gM2CSJMSbSrSISOKXzJsimyKU5DB2+zL8?=
 =?us-ascii?Q?f8ENRYiD3IkdBeXzOMuTFlqts9LZwqLIKak6QPtPyNfr01yLFZxDLLM6DzuR?=
 =?us-ascii?Q?pgBkzRKhsoFfDPSnXPdsZzLFq0r47QCaFvO2uXQp7FMLnpTxcXwDbFuSYjNT?=
 =?us-ascii?Q?CfIQds7qjGqaMpzf/xK8nCjtGIJ9xJLyqwUcnj16aeVv8DMsDZuITuul9Bsi?=
 =?us-ascii?Q?8PSgKSNTZ73iRmqbl3gQdooOeTC9gPs7tzx3OYi2CigQY3AfuRDOlMe8fOzN?=
 =?us-ascii?Q?MV9ZVRsW+Z6PsJ9VgVAi6giid+jAjA6Ruc/nzmxO/Aty/2wZLSq+RPGR8bWK?=
 =?us-ascii?Q?/21i64V2qGAsgN5x6OagFQ2mMep3u1LkVL735EQzNOGGZ/8NE1uq6awwHz9G?=
 =?us-ascii?Q?loB7jg8zKuEG8uwU18YYh8oTUZ2qSbE/x5s8aBOKDsLbmIN6+rUSi8BQryXa?=
 =?us-ascii?Q?kCjAXUp1Qkze9y0Qk3sEByDUKoMMq/O5En+YIAbbgcdVd6E+myUoT5AreVwd?=
 =?us-ascii?Q?YvmLQgc9YMPFBkFGit6QCTKZ4LdSiYI1IsY8sD9mPBgVfWg8eGc/yjV0j1iH?=
 =?us-ascii?Q?dzb6hrOkPm7In99i4oSDiSPW+TfImU6CyPT41yvHIMrYK6h/JlhklQua+cQu?=
 =?us-ascii?Q?nM7noOFtjU0hb0h1KYTMEx4=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e089c523-8491-4a25-d56c-08dc5f7c5cca
X-MS-Exchange-CrossTenant-AuthSource: PR3PR04MB7371.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 07:51:32.6888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: anibqSbS5FFzw5+4eeZ+eUacJRImf/au65k4E0lhPIUmFL4qJ3uqPZ/ELRbYv6I8/Ro3YSu0149QOChq8GCe9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6915

On Wed, Apr 17, 2024 at 06:17:34PM -0700, Jakub Kicinski wrote:
> On Thu, 11 Apr 2024 14:34:33 +0300 Vladimir Oltean wrote:
> > On Wed, Apr 10, 2024 at 07:40:55PM -0700, Jakub Kicinski wrote:
> > > On Tue,  9 Apr 2024 11:30:46 +0200 David Gouarin wrote:  
> > > > Make it possible to bind a XDP socket to a queue id.
> > > > The DPAA FQ Id was passed to the XDP program in the
> > > > xdp_rxq_info->queue_index instead of the Ethernet device queue number,
> > > > which made it unusable with bpf_map_redirect.
> > > > Instead of the DPAA FQ Id, initialise the XDP rx queue with the queue number.  
> > > 
> > > Camelia, looks good?  
> > 
> > Please allow me some time to prepare a response, even if this means the
> > patch misses this week's 'net' pull request.
> 
> We're getting close to the 'net' pull request of the following week :)
> The bug has been around for a while so no huge rush, but would be nice
> to get rid of this from patchwork. If you don't have time - would you
> be willing to repost it once you found the time to investigate?

I have been looking into this, but I do not have a definitive response yet.
The dpaa_fq->channel replacement is not the zero-based RX queue number
that David is looking for, either.

We will work this out. Please remove this patch from patchwork for now.