Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp1156252lqb; Thu, 18 Apr 2024 01:31:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWqOIZU5hUkX8GbFKSKCCmBcSqHx4QXBFLImyUQiVdOZhwU6GXrr9zvPIOJNn1xSX2XT/oW/3s4kbjEycihJ4RmfWxt7JmC2GHc62vVdw== X-Google-Smtp-Source: AGHT+IEjkxzXCWiqAf5jxKx/emhym2zlKrrWzoeIB1QJctuxP2MzaRIkV/RH2sZIvrKeKhiEHMSz X-Received: by 2002:a17:902:b214:b0:1e0:a22a:623e with SMTP id t20-20020a170902b21400b001e0a22a623emr2092278plr.21.1713429102984; Thu, 18 Apr 2024 01:31:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713429102; cv=pass; d=google.com; s=arc-20160816; b=Ml7+DrERMeIO7KsJfJ4WIDNzxNaqWXj4OzDCm0dYO7vSuxpgp3aa1znv2LM2BGB14D BKZR8Gg8HsGdqFrdXzVaQeVZkLV3y8iKLOxuwBeHbMHaoNlyExK6WugAQ4h17UdFCIGY MTyNQyJ6ruihNY6p1EJ5f5mohwiinMGE7EhyRIy0gV3O3lUaWva0Pfje7N20fixek4Vi XmfdHyRmupFzh3ighxUeezOIN0eqw89uNGZRpHmYS68c3nQLnlJHCkPEU5ivaY667OLB CwqaaHnYeiHYwXNKygCYkto6YvxLLPxzw/1cUAZnF4kOLz78XOa8nrZOL1r6v0NugxsQ yOQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nUgKINz754ZFI6JUxUXJjitVcSOb5Cu6ZJ/ZatqtMfk=; fh=Y9krvqleeNlJWfzzK3+zFTLovHz+Oim3hf0XcbrA3Ws=; b=RxodVVU3iUCRzhnW/XiSsdHlpacq0z92jMmL2Gij8ba6zYycOTeO8X7BDPXiMppk4g 8OFZdepLFGnpBaLlCmJ/R6T7AG7zNNJ7UkBsAFTDDMo3a5XbEPPzQ9Jrycb9xe/HzGqj tIcbp4hjWaIz509WJMoNAFXAO7XpmO+Rf+LD80KgsCjKGiVBxyu03tOylRSYH5fqTLc6 IAzp2yIPqXbUqIZY1GWfNopAdaAymp5/KBB7Rrfax+ECrttHjc7Cjg2AvipSfsnfnsGJ J/s1LXtZtXn3qfHy+YaFFGoAE3nOeNjeb/2sR0vCWTwt7NiaM63ipXOwU2aLZsz9y1G1 3zhQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="tjD/4+e4"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-149722-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149722-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id q14-20020a170902a3ce00b001e61a7a98d1si974301plb.261.2024.04.18.01.31.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 01:31:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-149722-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="tjD/4+e4"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-149722-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149722-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 979C1282B67 for ; Thu, 18 Apr 2024 08:31:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D65B2145FF8; Thu, 18 Apr 2024 08:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tjD/4+e4" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08C0B12FB00; Thu, 18 Apr 2024 08:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713428983; cv=none; b=ozzeS2VEXknQJ+MDB2XHjuGdHfl+JAyc4LRPo59VSoidrstAFo3AsIkcl57uMUm6YBoCMOQbq1PCNAcQ+A885alcrEKyPgXdiP7K4qzpQmQ3cKJvzbF2hlXR9vMO1hX+vSyyf5VV+J1ImyM8JQHnsTwWs7nnZcANkvbLLzmvXuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713428983; c=relaxed/simple; bh=epqtCU7cHFg6qcrksoflXTGplFleqVGd4CaEPMYW1d8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hQhfNovP+f2gfn5p8G4qlDL6ML8gQgffOGDD0nGdMhm15lzDBxZq+AcBprDac/xzRDq1Dh7g6Lrn5wiMVYIpUXksEY/CWsbNK8ONLNVVq07t54Nfz0nPZJ93ZjpLx76j2pnPJKsEgsP89qPSl0Xkb5xT55SFAzyRuVJAxTjjKS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tjD/4+e4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5AF8C32781; Thu, 18 Apr 2024 08:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713428982; bh=epqtCU7cHFg6qcrksoflXTGplFleqVGd4CaEPMYW1d8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tjD/4+e4vSScmvSoEvYQoRNeiQAYlbYXzasd0/Rl0orlzzFKkOvIvRkR8cKoA1I6Q dposssKjjyWT4Y52T/bz7YfGNkxruHcxz33+n9Y5snKbqpZSQRVtQYJuPZuZs/Sg1R k3Q1Q8Cfm38H26kT6/1vhLW7dXnRqNGxRM0FYxj4PAMYa6gVM5YzFxdCc5LtBPHJAq lLX/ybDMiolc5dRUDXD4x5k7nGsRUGoh7yYT+wUwLOcGRYQr1vyKeUAtwk/cEQkanK SqwWXSqmEU8tVYaicFqMnxbDR/TyD5fnpaFWwCWkX4rbRrIchayKcN3MKMr0wCwVpM AbvDMyzTJWhfw== Date: Thu, 18 Apr 2024 10:29:37 +0200 From: Niklas Cassel To: Manivannan Sadhasivam Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] PCI: endpoint: pci-epf-test: Use 'msix_capable' flag directly in pci_epf_test_alloc_space() Message-ID: References: <20240418-pci-epf-test-fix-v2-0-eacd54831444@linaro.org> <20240418-pci-epf-test-fix-v2-2-eacd54831444@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240418-pci-epf-test-fix-v2-2-eacd54831444@linaro.org> On Thu, Apr 18, 2024 at 01:29:59PM +0530, Manivannan Sadhasivam wrote: > Instead of using a local variable to cache the 'msix_capable' flag, use it > directly to simplify the code. > > Suggested-by: Niklas Cassel > Signed-off-by: Manivannan Sadhasivam > --- Reviewed-by: Niklas Cassel