Received-SPF: pass (google.com: domain of linux-kernel+bounces-149784-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Yuan, Perry" <Perry.Yuan@amd.com>
To: "Huang, Ray" <Ray.Huang@amd.com>
CC: "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>, "Limonciello,
 Mario" <Mario.Limonciello@amd.com>, "viresh.kumar@linaro.org"
	<viresh.kumar@linaro.org>, "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"Petkov, Borislav" <Borislav.Petkov@amd.com>, "Deucher, Alexander"
	<Alexander.Deucher@amd.com>, "Huang, Shimmer" <Shimmer.Huang@amd.com>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>, "Du, Xiaojian"
	<Xiaojian.Du@amd.com>, "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v10 1/8] cpufreq: amd-pstate: Document *_limit_* fields in
 struct amd_cpudata
Thread-Topic: [PATCH v10 1/8] cpufreq: amd-pstate: Document *_limit_* fields
 in struct amd_cpudata
Thread-Index: AQHafqj7zTlF2tpHFUiWMFmrMWzN6bForYQAgAU3JwA=
Date: Thu, 18 Apr 2024 09:17:55 +0000
Message-ID:
 <CYYPR12MB8655D251FC00EF8207C771BD9C0E2@CYYPR12MB8655.namprd12.prod.outlook.com>
References: <cover.1711335714.git.perry.yuan@amd.com>
 <6b8432f302165e686a01ffe7d1d98852d5e88609.1711335714.git.perry.yuan@amd.com>
 <ZhyEwE3Hr8Waf620@amd.com>
In-Reply-To: <ZhyEwE3Hr8Waf620@amd.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=70a4cd2f-13eb-4e4d-9d1b-9a767e9d2867;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-04-18T09:15:45Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CYYPR12MB8655:EE_|IA0PR12MB8373:EE_
x-ms-office365-filtering-correlation-id: 82f15f04-f8ff-4257-84f4-08dc5f886e61
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 X/Gl8L/RezNotEpvep1Ir7jEH6eCCgg80PsSQ78mhxC40YL52VmtRCqHpPIQpP15PHUkMKgiYtVRcSPU2PPuLwTNHRfRTRUGi5+8M5lVJVcNpEfz6iicGvxRfQJ1/cwFpY+AtjU4lG4gyF7wt5OtfCaOGh90ocVoWo7SnZsWxSfDB5FrftmG+UkRD0aSE3x9CKsXXwMjs2y2S7oGNENkT0UD6euqnaRukM5rzedkccHvWsXtF9NBVc0hMk/YUtqs6FsY5lsRlBi4jBLTNh6zm50TadUOdDew2J8T61/iP4U/9Klrhsp/ERdbW06RWUVsQe9mhXnx5U/zfBxl+7DgkHaNaxIpFMSJeoVCG0Z+fLWC9ZCDmfdteB5xiwuR8OFQxnZwh/TMR3cyfDgUX6z4V4jb0p6n+XhmT6niLi2hJE5DHJgRPvph2FdoxTka8oRXO4yCK7hAti/3YQ/MUC/HUvIICAxhaSo7wLOwS+nJLcEwpZfFYYJG53d/cELapFRfVuRjVnhv6KF0pMgzt9cAaX830+eik1Ayr18mTj8mRMSJ6jlHkzLGW6AKRTKSFPTCp1g6p+0498X8Y0Q4pWLLjAbU0lYUKvA5Dy8Z26v0D10LmI/OrFrfAZsZoXXKPhNHHRvCZrP0fsxHvgJuBqh50C2XSeGFSVnuVV/tyqnkGIcniytU6gsSTop0TMCZU27TmKQ/aaObFQeTWJNu5LDsHzS+QUq7f+HJdSNWd6NMq1A=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYYPR12MB8655.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007)(38070700009);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?i8NJvUNeGVbJp8FK3tdIDArvz0ULpcjyjac/cRIMosMPJVa0FLH3J0yRZuHn?=
 =?us-ascii?Q?GKSII+qFdBgcDUl5HMGb/+2ppwPVBdzII6R1PeJO4J1qenswSCkMQEhy98F1?=
 =?us-ascii?Q?9Z6kmpBycDIBbO70F47F4xschW3iK6aUnWzit9r9mixaZNjpEqJmaArZWFBo?=
 =?us-ascii?Q?sHVDARlAnpL5CFndIRNIFMGP4VHOJPleO07AYpf2rYFpkg6blpH+a8hA7woa?=
 =?us-ascii?Q?OWqLq21/w2Ik0lwf8BJcMH/MElWMrkShuOD9x1bYFk5K0OFacDr9No06x9Nu?=
 =?us-ascii?Q?6Vt7fJyvlbHzLTbdnZh3boKR6Gy80OEMY/YfN2kdrz6/wVKwzwqM+sf12ju8?=
 =?us-ascii?Q?KYivmaEdCU/xHAdEyCk5ID+UDd4lbdA5CeFVEqQYUWPF9E4LsHKzQy8vg3Dl?=
 =?us-ascii?Q?dXyUHlUYIUoLxWKEDejRV8ZNACQMdaajS2FMiDQyK/gBiJFm+YDvzPdMe91U?=
 =?us-ascii?Q?u8CGgSiNPLr1CTdFTZ5eTuptv84+e32KtUB8ENI59hgp7wAZ63MgbHvcPOQP?=
 =?us-ascii?Q?MM6J4Ux6n/AbfhTe41ZXbMlxJZ/nzQpsKG14ISsKbNJd3KBUBvhIGyZx9VCL?=
 =?us-ascii?Q?Lg51EinE+iyAhwajfVQGf50vshAPpWQQ1Otcas7AwS+Ss8Tg3oVW8bqlaDiB?=
 =?us-ascii?Q?W1+sLbYlDX0aMP8NBH01Q6tbkbZ2B+2HPUV0n3+MEQgi+CNfX4AEgmFHHns1?=
 =?us-ascii?Q?lE3Rum5s6rXxqOBcAZBprRDn4IVPGCWsyjkgYEZuUA5jzVV4l7LKdwvV9OEr?=
 =?us-ascii?Q?b3uOR3VG7HYYvRhFiGRaixKxtsJKfIfBVyWCXhAQILA9jD7gikUgyZBRr7XU?=
 =?us-ascii?Q?hAsQB2jv6bRu3+HHwAtOOhp9OTFt3Dbg7vKfdtlM6N22CYb1UA95Q4tvu2c+?=
 =?us-ascii?Q?FbYGo2R7+oc7PozuLNx+LtJlI+byqwDL2unUWkaQ82Es+/U6yQZDUQszytv9?=
 =?us-ascii?Q?ZNoKL/FYrGw0tafqLs0xFaKo5GJZol5opV6x6IvHB0rw70YFdBXSgIuUyiwk?=
 =?us-ascii?Q?AxTH6b+/nae/XSuwJBV2OB7zgxZq+gNNg0d2bbc2EoivdmI9LtAe+0jq3AtC?=
 =?us-ascii?Q?/7WAagos222jcJrhd/mQqt2Aqd0V61xZhQcWzOiFMoCT8yRzkieJHqeqLoHp?=
 =?us-ascii?Q?94mrMVDTdnCRZrhbK9xega/jKLo/P8Ey7nZnKExN8fMOGBNqZTumxOTLvCp9?=
 =?us-ascii?Q?8dVlh4c90wH2MyEnU6HCrordSVApGqFj769vi9ykyspxMPzntoHHD8pNKvmd?=
 =?us-ascii?Q?9QeBJkgvP5JYO8jmY0fKMefGEVItcJBNcBE1k90dEbQ4+oNFfBUsUX78UGv/?=
 =?us-ascii?Q?APatzNL1lZmWOZNtVxy9eFHnELd1fXVzAELLJCzhaYp6AkO8zPkPOCYyE+TE?=
 =?us-ascii?Q?A8gJrFhB979dWCKUHJc67dCVXRnOlapIssnQgHwdxXLY8bIb60tOQALfCyhW?=
 =?us-ascii?Q?3KAnqkSZt/iMwwZhZYIqmhOImaCEbTqAZlHg1ANrJue+UNZZLbNsuS406emG?=
 =?us-ascii?Q?N01uA0eLllqFk/d01pvLlO+H/1TYFFbM30rhivBzfjN2o3c6ENzfD5wxxjKC?=
 =?us-ascii?Q?ChbQ6Kgj2k4PP6mkA6VOmaslhViKblNDs+N1YsFH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8655.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82f15f04-f8ff-4257-84f4-08dc5f886e61
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2024 09:17:55.1752
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5L50Gtv1m0tuaGuNtC8zZIVsNTXzL35pztCBRrcg0vRzYXHtQilnUoKtvGxRDwANzk1I1u1JEJHfuYBWABHVfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8373

[AMD Official Use Only - General]

> -----Original Message-----
> From: Huang, Ray <Ray.Huang@amd.com>
> Sent: Monday, April 15, 2024 9:37 AM
> To: Yuan, Perry <Perry.Yuan@amd.com>
> Cc: rafael.j.wysocki@intel.com; Limonciello, Mario
> <Mario.Limonciello@amd.com>; viresh.kumar@linaro.org; Shenoy, Gautham
> Ranjal <gautham.shenoy@amd.com>; Petkov, Borislav
> <Borislav.Petkov@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Huang, Shimmer
> <Shimmer.Huang@amd.com>; oleksandr@natalenko.name; Du, Xiaojian
> <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v10 1/8] cpufreq: amd-pstate: Document *_limit_* fiel=
ds
> in struct amd_cpudata
>
> On Mon, Mar 25, 2024 at 11:03:21AM +0800, Yuan, Perry wrote:
> > From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
> >
> > The four fields of struct cpudata namely min_limit_perf,
> > max_limit_perf, min_limit_freq, max_limit_freq introduced in the
> > commit febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and
> > scaling_max_freq update") are currently undocumented
> >
> > Add comments describing these fields
> >
> > Fixes: febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and
> > scaling_max_freq update")
> > Reviewed-by: Li Meng <li.meng@amd.com>
> > Tested-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
> > Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> > Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> > ---
> >  include/linux/amd-pstate.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> > index d21838835abd..212f377d615b 100644
> > --- a/include/linux/amd-pstate.h
> > +++ b/include/linux/amd-pstate.h
> > @@ -49,6 +49,10 @@ struct amd_aperf_mperf {
> >   * @lowest_perf: the absolute lowest performance level of the processo=
r
> >   * @prefcore_ranking: the preferred core ranking, the higher value ind=
icates
> a higher
> >   *                   priority.
> > + * @min_limit_perf: Cached value of the perf corresponding to
> > + policy->min
> > + * @max_limit_perf: Cached value of the perf corresponding to
> > + policy->max
>
> I think we should use "performance" instead of "perf" in the comments.

The max limit perf should be OK,  the perf string is more meaningful for th=
e pstate driver performance level control.
Thanks.


Perry.
>
> With that fixed, patch is Acked-by: Huang Rui <ray.huang@amd.com>
>
> Thanks,
> Ray

Thanks, will pick up the flag in v11.


>
> > + * @min_limit_freq: Cached value of policy->min
> > + * @max_limit_freq: Cached value of policy->max
> >   * @max_freq: the frequency that mapped to highest_perf
> >   * @min_freq: the frequency that mapped to lowest_perf
> >   * @nominal_freq: the frequency that mapped to nominal_perf
> > --
> > 2.34.1
> >