Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp1195750lqb; Thu, 18 Apr 2024 03:03:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVavVFh9OmfuShyQk46Wob1nhQccyCCv42Hq11q3tMdAIhjzpHhAl/X+MqFBJcWUsSSqrFYI/BJAdinUF1I4B90sjE5V0npy+ell78/aQ== X-Google-Smtp-Source: AGHT+IHEuJ0kzRZmfxXYAdZEh0BpUyaEob0m7L9hCl4BPy4CrAMuARh2o4mVMJz5ThM1c8/eQTFE X-Received: by 2002:a05:6a21:2d87:b0:1a9:d27c:3151 with SMTP id ty7-20020a056a212d8700b001a9d27c3151mr2884413pzb.23.1713434608410; Thu, 18 Apr 2024 03:03:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713434608; cv=pass; d=google.com; s=arc-20160816; b=sFvtMTiokxd1l5LTRDpi0eprFoOuvHhFelECq5VaKxNnYJlVVzMvLvBZp+981PPKbs bQ20dxCUeaQh3kt6Wsya7FCfY5aJ2svRv2NDOK83ptoUVGRk/mHs5Ijn8m7yQtwkRqFr tR9sTp8J+dS9R91X3ODVm0DqPcVryV6Yyt788ccR58NMjKjFctRen7yzzISN6FfC/HJk EYpuxIq8lo47Z9eLzcyDAWabhM2tLtiA2OY/5VjfkGs7e0z505NA2/cokD2BdlsZVAbz YykXe9lkITPIz0kbmps+Zf86bLVMjkbgK2ImNxo/hXIOU7gQh9meq3ZEnnmbZa/q4bWo RITA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=zwzkYWr6U9C4zC2JlX3QMDroH3epi3ZSlaJuC9jmIvY=; fh=ybee/aWq1iFGqGHFirmRYPwdmMHKKc4xxaMdWXlsU54=; b=TRKEAkVgVl7pUi/PJ+W4AQBDkeea49+oh97cF9GwUorggVqzSPrLrbwOQiHmvye/93 ggpYMgtDMV0UnRwIeu3etld24SiE0ZSV3MQy/dt3USEGpRgENmMWDiDH0O4RAHWfF2gZ URdTBAt3vES6wA2GNjKoj2W/e+Ua0QdlXrrqTqmvLOzJm8bnvyU4trPZxZ2XPyxePqD2 gemM8vuDAljjXXi5ufmKGCqO4u2VBHcbDI6M13cLsNLmUC3t1h1JDut1/MkVirQY/zgB qyQZOCaJ7aMFb+90MHgZxlgKHSOa+9gSVsr7xKAlRaWgpPBf7ZhgngpuTjXCdL6rQvKO ZLzQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=32zD3y44; arc=pass (i=1 spf=pass spfdomain=fairphone.com dkim=pass dkdomain=fairphone.com dmarc=pass fromdomain=fairphone.com); spf=pass (google.com: domain of linux-kernel+bounces-149862-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149862-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id o27-20020a63731b000000b005dc4eb22ed9si1126071pgc.166.2024.04.18.03.03.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 03:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-149862-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=32zD3y44; arc=pass (i=1 spf=pass spfdomain=fairphone.com dkim=pass dkdomain=fairphone.com dmarc=pass fromdomain=fairphone.com); spf=pass (google.com: domain of linux-kernel+bounces-149862-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149862-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0AC43283AF4 for ; Thu, 18 Apr 2024 10:03:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AE8A415B57F; Thu, 18 Apr 2024 10:03:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="32zD3y44" Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB5615B141 for ; Thu, 18 Apr 2024 10:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713434596; cv=none; b=iZDykfIntnmxi+nngBTUechDYaAQPYUFk6m1Xm/W/gcHzNhi8VrBEkV9mkgm3YsgobpTMfH+DQX74h15JwVkDYdNx58Oue/W1T7CS0t8fdNZldNKthh3U8gO3JkKDD31xJ8Kq/MGgnKDgo5yVPUG2p2xByYB4K+TvG5TpRhQZrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713434596; c=relaxed/simple; bh=zwzkYWr6U9C4zC2JlX3QMDroH3epi3ZSlaJuC9jmIvY=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=TnbRtWALH/oXtdKt+qFEGjVmNX5GSdbwW3LlubNAZYXtH+IXoEuJlE/w2yC2UV3TSGBErSn8oTeH+MzEub/DJGyY6W3zIPFDdIsnGGlWYS/RSdz7qNN6lxmW8HcDC3Kn4qUoht4SwVZFE6vmZsBbdkEwHSEmpUkNCuLxS6ILNvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=32zD3y44; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a555b203587so65892466b.3 for ; Thu, 18 Apr 2024 03:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1713434592; x=1714039392; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zwzkYWr6U9C4zC2JlX3QMDroH3epi3ZSlaJuC9jmIvY=; b=32zD3y44hHaLIYej5hYS32GufwYGYRibPGW7H1540N4sCnx1Ra2aQ48QyYnbP/Rtkn 5LYrRWqRx4iqonM4En5tqQcLAdoaf+DywCMtNDgT07hPKKMY88DG0/1JovWPbJtLMwN3 6Q7it91+9KwtCPvpbDJKJ6UVUEdt211xAL2lxBBRVdI5AVxZD3Elx+2JNJiUOmhX/Flv rmCCk8IttwWC70m9fJqMg5+f9p7fap040O8SJzDidRqbsvOFSl6s6/VKUhbkduwFJZjo UFiagZ5L6S+F8R3QiitcE8gYdRxNB/VeRTPrKE28a53pAUXiRHDnWTMCsx+6RHPjBlQu AIuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713434592; x=1714039392; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zwzkYWr6U9C4zC2JlX3QMDroH3epi3ZSlaJuC9jmIvY=; b=siCDipkxoylsyIKXReFMKtUFpyvxU7giar+5av5JSCb/+1aBB1FrTe1SB04WnV7/CJ 2mqpJWTjw+TtPMM/Xb2Nh6ba6I0tzXeCtVhg5O+nsHJIXxWvT+cHZCSaMM/9Pq1GuPHI 8OqGvCA11KpifaIVv1wdMwlaBLi22sbWWk2ryqIdC3aVmHypHd8gt9px4FtBF1mnfSKa vTaEmqdLfRogwB3FmB7keCi5cGYTDOm+BZ6FVui783fYQrjRTWuYV/A0C4soCK/vayYH 2D5ZQtXl5WrJcXBQFQFHaWUPf7Hb9Bj5gW4+XegGpkjEeAnUAF5/U4VSw4BEIKq0vK00 Rb+A== X-Forwarded-Encrypted: i=1; AJvYcCVDhFN4a9mu8gmpMDfjh3A50WihESvvwPUbMr2ElPbbj2tif/bEOdQ15XxMzNQ0E2xeMA8OM95drqSNG1Gt6MpX0Eghp4MJri5R/WB8 X-Gm-Message-State: AOJu0YxoaI02SAFJ6sTqckSSbWXZNs+l/lVO4nnYFYEWFVh9z8eTtKAj W9v2CLB3GMX6HevYb3UqBmJKgbKQZs/JagI1+n67MuccmeYbaotAq3yQxNMbNWU= X-Received: by 2002:a17:906:6857:b0:a51:dd18:bd20 with SMTP id a23-20020a170906685700b00a51dd18bd20mr1763260ejs.14.1713434592068; Thu, 18 Apr 2024 03:03:12 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id gh16-20020a170906e09000b00a5180d5b31asm672634ejb.32.2024.04.18.03.03.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 03:03:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 18 Apr 2024 12:03:10 +0200 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , Subject: Re: [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator From: "Luca Weiss" To: "Konrad Dybcio" , "Bjorn Andersson" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Fenglin Wu" X-Mailer: aerc 0.17.0 References: <20240418-fp3-vibra-v1-0-b636b8b3ff32@fairphone.com> <20240418-fp3-vibra-v1-1-b636b8b3ff32@fairphone.com> In-Reply-To: On Thu Apr 18, 2024 at 12:01 PM CEST, Konrad Dybcio wrote: > On 18.04.2024 8:36 AM, Luca Weiss wrote: > > Add a node for the vibrator module found inside the PMI632. > >=20 > > Signed-off-by: Luca Weiss > > --- > > Reviewed-by: Konrad Dybcio > > On a side note, this is a totally configuration-free peripheral that does= n't do > anything crazy until manually configured. > > In the slow quest to be (hopefully) more sane about the defaults, should = we keep > them enabled by default? Bjorn? But many (most?) devices don't have a vibration motor connected to PMI632, some (like devboards) don't have anything, and other phones have a separate chip that controls the vibration motor. Enabling this by default would mean all devices with PMI632 would get an input device for the vibrator that probably doesn't work? Regards Luca > > Konrad