Received-SPF: pass (google.com: domain of linux-kernel+bounces-149881-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240418091148.1968155-1-f.suligoi@asem.it> <20240418091148.1968155-2-f.suligoi@asem.it>
In-Reply-To: <20240418091148.1968155-2-f.suligoi@asem.it>
From: Adam Ford <aford173@gmail.com>
Date: Thu, 18 Apr 2024 05:25:43 -0500
Message-ID: <CAHCN7xL-18xL04KCZUYfegBH0vWa8i5EEa8UkhoedbmrpOqyWg@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] dt-bindings: net: snps,dwmac: remove tx-sched-sp property
To: Flavio Suligoi <f.suligoi@asem.it>
Cc: "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Alexandre Torgue <alexandre.torgue@foss.st.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, 
	Jose Abreu <joabreu@synopsys.com>, netdev@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18, 2024 at 4:12=E2=80=AFAM Flavio Suligoi <f.suligoi@asem.it> =
wrote:
>
> Strict priority for the tx scheduler is by default in Linux driver, so th=
e
> tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
> platform: Delete a redundant condition branch").
>
> This property is still in use in the following DT (and it will be removed
> in a separate patch series):
>
> - arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
> - arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> - arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> - arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> - arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>
> There is no problem if that property is still used in the DTs above,
> since, as seen above, it is a default property of the driver.
>
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by:  Adam Ford <aford173@gmail.com>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml        | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Docu=
mentation/devicetree/bindings/net/snps,dwmac.yaml
> index 15073627c53a..21cc27e75f50 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -328,9 +328,6 @@ properties:
>        snps,tx-sched-dwrr:
>          type: boolean
>          description: Deficit Weighted Round Robin
> -      snps,tx-sched-sp:
> -        type: boolean
> -        description: Strict priority
>      allOf:
>        - if:
>            required:
> @@ -339,7 +336,6 @@ properties:
>            properties:
>              snps,tx-sched-wfq: false
>              snps,tx-sched-dwrr: false
> -            snps,tx-sched-sp: false
>        - if:
>            required:
>              - snps,tx-sched-wfq
> @@ -347,7 +343,6 @@ properties:
>            properties:
>              snps,tx-sched-wrr: false
>              snps,tx-sched-dwrr: false
> -            snps,tx-sched-sp: false
>        - if:
>            required:
>              - snps,tx-sched-dwrr
> @@ -355,15 +350,6 @@ properties:
>            properties:
>              snps,tx-sched-wrr: false
>              snps,tx-sched-wfq: false
> -            snps,tx-sched-sp: false
> -      - if:
> -          required:
> -            - snps,tx-sched-sp
> -        then:
> -          properties:
> -            snps,tx-sched-wrr: false
> -            snps,tx-sched-wfq: false
> -            snps,tx-sched-dwrr: false
>      patternProperties:
>        "^queue[0-9]$":
>          description: Each subnode represents a queue.
> --
> 2.34.1
>
>