Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp1217665lqb; Thu, 18 Apr 2024 03:50:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU5x0BApKkxZe2h8DOdwxTaa96cqWkGlZqPruEX3+nJphBXvpWV2a9hciUXXwm7U9nKpJ+VEp50xGXiq3ktjzQvs+zFXgpO0DOxXP3SUQ== X-Google-Smtp-Source: AGHT+IFUBqPzR1LQd/5N3RpDWu/IPH9chftAVJQmAIQSXI5yvD8QqerrmUpd//qrtBzzPx9C/lwq X-Received: by 2002:a05:6a00:1898:b0:6ea:bdbc:6a4 with SMTP id x24-20020a056a00189800b006eabdbc06a4mr3105818pfh.13.1713437439472; Thu, 18 Apr 2024 03:50:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713437439; cv=pass; d=google.com; s=arc-20160816; b=UfMrJc9X4Ju9rJp2XLLEdM2lUklwgHOJyLxUdryvcCivaEgD5J72Nicx/cljE/1qjO SE+CdrBiz+Lne93BGRCVcg/6s0SQR/ZFVpiPXqhlR0zkoycqpJ0eUcUUA0Z/8xLg0V5W GFVOSq1s3Dmi//XX/HQ3Rr1unc9j5rMJglyUmQ15zZh/lWm8G34ApoSpATx59BbFZxU3 cKrLCY3M7ZrlwbuvEudBphR6TaxDbY+IChEDOfz1zy1rP7lRswpj7rZoNWQ2lnYawVY0 32jLVUQWFXGcKy84qVM2S7aSkxCQ7Rur4Ks82F/pzsmrGzGXnobR7cQffgxnw412q05W 9l1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=xfN3C19fgruUXPMqKTSmuhdp2OUHMa1mBEwx+Ur8hrY=; fh=PwK/oPHy5EcJUcn09tqRSF6bDW8OKWves4R/1As/jCk=; b=w3mTscatnX94ayoRnmCDiIXpQanNeRxtUEbPG7tsO6d09+4Tt56lOfNqWON2IawWKK rXcgl8jV+DLRt2yi3DlkouCXN1fN12/56OeHFP+zzwpsVR4oxn3syrWWPrco7vtK9P/K AKD5ePz26x9LBWTqEdO/byFh7++dkhr6/RPBXqYE+R2ffWChwy7ywMc/VPjXlrb9IbvM LqxEFurSSsvGhzt8I7j/+ByxqHm/1CVXLRcVB48SvyeTK88ixbLxuTBqtvSNZpL13Gwi OAE0DIPWKroCXfsjrlAYOmkYInmbezYdJ6bk6xWOZYbkEu5sTWaCLibY0AcSzfyS6KUh 1hIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=easystack.cn dmarc=pass fromdomain=easystack.cn); spf=pass (google.com: domain of linux-kernel+bounces-149909-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149909-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id q16-20020a056a00089000b006ecf7f19df2si1278096pfj.187.2024.04.18.03.50.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 03:50:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-149909-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=easystack.cn dmarc=pass fromdomain=easystack.cn); spf=pass (google.com: domain of linux-kernel+bounces-149909-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149909-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 35C23B21EF6 for ; Thu, 18 Apr 2024 10:50:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7A7B415D5D0; Thu, 18 Apr 2024 10:50:10 +0000 (UTC) Received: from mail-m6032.netease.com (mail-m6032.netease.com [210.79.60.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B48356464; Thu, 18 Apr 2024 10:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.79.60.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713437410; cv=none; b=EEP08Rfqffr1G8ba00a72pDaTWmbrA2q+xdgws6HQ+JCbU6ebtlSnhb6l49s79SbY9hw+8WvKJCRKoCgEMLaesn/gn3AgMtppoOtEDFQ4q3NvJpK0ynPv5FWOsemCdx/A9DURPmlSwzbvZULQwzPu6CvvErPebf6uoHNxrnjHqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713437410; c=relaxed/simple; bh=iiOufjOIkL3haOEHZ1PQmwIhrHyxYpHcfZJEjBfNLSk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IP2GNsg+RZeiNzBVii8qOWgzzRdqfFEs1VraKGJgMPAF4XEtXTr5z699I8IMtHRjY707YUBU8Vb8ZTkWU/VaNOFpkYP/4mPCMvo5j19NmtUaibFbBMe2w9y+XJHBEYCpmk6CyQ7sSg6twnvs3CSbRvokomMMeD2qFJ7jeQbdwZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn; spf=pass smtp.mailfrom=easystack.cn; arc=none smtp.client-ip=210.79.60.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=easystack.cn Received: from localhost.localdomain (unknown [110.185.170.227]) by smtp.qiye.163.com (Hmail) with ESMTPA id 6AE235601A7; Thu, 18 Apr 2024 10:32:44 +0800 (CST) From: "jun.gu" To: echaudro@redhat.com Cc: dev@openvswitch.org, jun.gu@easystack.cn, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v4] net: openvswitch: Check vport netdev name Date: Thu, 18 Apr 2024 10:32:42 +0800 Message-Id: <20240418023242.259542-1-jun.gu@easystack.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <811765EC-AD27-4210-9AFC-034129F24BFA@redhat.com> References: <811765EC-AD27-4210-9AFC-034129F24BFA@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWS1ZQUlXWQ8JGhUIEh9ZQVlDSxhCVk9MTk1DT0pNSEkdSVUZERMWGhIXJBQOD1 lXWRgSC1lBWUpKS1VKQ05VSkxLVUlJTFlXWRYaDxIVHRRZQVlPS0hVSk1PSUxOVUpLS1VKQktLWQ Y+ X-HM-Tid: 0a8eef0c9ae6023dkunm6ae235601a7 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OC46HQw5Sjc4QhkLLBUhOUoc HUMwCS1VSlVKTEpIT0tMTk1PQ0pNVTMWGhIXVREOFVUcDjseGggCCA8aGBBVGBVFWVdZEgtZQVlK SktVSkNOVUpMS1VJSUxZV1kIAVlBSkJKTTcG Ensure that the provided netdev name is not one of its aliases to prevent unnecessary creation and destruction of the vport by ovs-vswitchd. Signed-off-by: Jun Gu Acked-by: Eelco Chaudron --- net/openvswitch/vport-netdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index 903537a5da22..7003e76b8172 100644 --- a/net/openvswitch/vport-netdev.c +++ b/net/openvswitch/vport-netdev.c @@ -78,7 +78,10 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name) int err; vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name); - if (!vport->dev) { + /* Ensure that the device exists and that the provided + * name is not one of its aliases. + */ + if ((!vport->dev) || strcmp(name, ovs_vport_name(vport))) { err = -ENODEV; goto error_free_vport; } -- 2.25.1