Received-SPF: pass (google.com: domain of linux-kernel+bounces-149970-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 18 Apr 2024 14:32:01 +0300 (EEST)
To: Parker Newman <parker@finest.io>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    Jiri Slaby <jirislaby@kernel.org>, LKML <linux-kernel@vger.kernel.org>, 
    linux-serial <linux-serial@vger.kernel.org>, 
    Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v4 2/7] serial: exar: added a exar_get_nr_ports
 function
In-Reply-To: <33f2bf66bc334573c10cf670a299ecef0b7264bc.1713382717.git.pnewman@connecttech.com>
Message-ID: <e5ea43d8-90a1-c157-9932-99192fc5d138@linux.intel.com>
References: <cover.1713382717.git.pnewman@connecttech.com> <33f2bf66bc334573c10cf670a299ecef0b7264bc.1713382717.git.pnewman@connecttech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1371258394-1713439921=:986"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1371258394-1713439921=:986
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 17 Apr 2024, Parker Newman wrote:

> From: Parker Newman <pnewman@connecttech.com>
>=20
> Moved code for getting number of ports from exar_pci_probe() to a
> separate exar_get_nr_ports() function. CTI specific code will be added
> in another patch in this series.
>=20
> Signed-off-by: Parker Newman <pnewman@connecttech.com>
> ---
> Changes in v3:
> - Only moved existing code in this patch, will add CTI code in subsequent
>   patch
>=20
>  drivers/tty/serial/8250/8250_exar.c | 27 +++++++++++++++++++++------
>  1 file changed, 21 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/825=
0/8250_exar.c
> index 04ce5e8ddb24..72385c7d2eda 100644
> --- a/drivers/tty/serial/8250/8250_exar.c
> +++ b/drivers/tty/serial/8250/8250_exar.c
> @@ -704,6 +704,21 @@ static irqreturn_t exar_misc_handler(int irq, void *=
data)
>  =09return IRQ_HANDLED;
>  }
>=20
> +static unsigned int exar_get_nr_ports(struct exar8250_board *board,
> +=09=09=09=09=09struct pci_dev *pcidev)
> +{
> +=09unsigned int nr_ports =3D 0;

It's always set, so no need to initialize.

> +=09if (pcidev->vendor =3D=3D PCI_VENDOR_ID_ACCESSIO)
> +=09=09nr_ports =3D BIT(((pcidev->device & 0x38) >> 3) - 1);
> +=09else if (board->num_ports)
> +=09=09nr_ports =3D board->num_ports;
> +=09else
> +=09=09nr_ports =3D pcidev->device & 0x0f;
> +
> +=09return nr_ports;
> +}
> +
>  static int
>  exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
>  {
> @@ -723,12 +738,12 @@ exar_pci_probe(struct pci_dev *pcidev, const struct=
 pci_device_id *ent)
>=20
>  =09maxnr =3D pci_resource_len(pcidev, bar) >> (board->reg_shift + 3);
>=20
> -=09if (pcidev->vendor =3D=3D PCI_VENDOR_ID_ACCESSIO)
> -=09=09nr_ports =3D BIT(((pcidev->device & 0x38) >> 3) - 1);
> -=09else if (board->num_ports)
> -=09=09nr_ports =3D board->num_ports;
> -=09else
> -=09=09nr_ports =3D pcidev->device & 0x0f;
> +=09nr_ports =3D exar_get_nr_ports(board, pcidev);
> +=09if (nr_ports =3D=3D 0) {
> +=09=09dev_err_probe(&pcidev->dev, -ENODEV,
> +=09=09=09=09"failed to get number of ports\n");
> +=09=09return -ENODEV;

=09=09return dev_err_probe(&pcidev->dev, -ENODEV,
=09=09=09=09     "failed to get number of ports\n");

Other than those two small things,

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-1371258394-1713439921=:986--