Received-SPF: pass (google.com: domain of linux-kernel+bounces-149988-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 18 Apr 2024 14:37:23 +0300 (EEST)
To: Parker Newman <parker@finest.io>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    Jiri Slaby <jirislaby@kernel.org>, LKML <linux-kernel@vger.kernel.org>, 
    linux-serial <linux-serial@vger.kernel.org>, 
    Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v4 4/7] serial: exar: moved generic_rs485 further up in
 8250_exar.c
In-Reply-To: <a7bf2a42de759908c058246ec15f60bde9a5dc65.1713382717.git.pnewman@connecttech.com>
Message-ID: <88d1dde8-c32b-a5b2-3eaf-e133ec3c4e33@linux.intel.com>
References: <cover.1713382717.git.pnewman@connecttech.com> <a7bf2a42de759908c058246ec15f60bde9a5dc65.1713382717.git.pnewman@connecttech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1651817364-1713440243=:986"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1651817364-1713440243=:986
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

Hi,

In shortlog (Subject),=20

- moved -> move
- exar: -> 8250_exar:

After those, "in 8250_exar.c" is redundant information and can be removed.

> From: Parker Newman <pnewman@connecttech.com>
>=20
> Preparatory patch moving generic_rs485_config and

Use () when talking about functions.

After fixing those, feel free to add,

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

> generic_rs485_supported higher in the file to allow for CTI setup
> functions to use them.
>=20
> Signed-off-by: Parker Newman <pnewman@connecttech.com>
> ---
> Changes in v3:
>  - split into separate preparatory patch
>=20
>  drivers/tty/serial/8250/8250_exar.c | 50 ++++++++++++++---------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
>=20
> diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/825=
0/8250_exar.c
> index f14f73d250bb..e68029a59122 100644
> --- a/drivers/tty/serial/8250/8250_exar.c
> +++ b/drivers/tty/serial/8250/8250_exar.c
> @@ -197,6 +197,31 @@ struct exar8250 {
>  =09int=09=09=09line[];
>  };
>=20
> +static int generic_rs485_config(struct uart_port *port, struct ktermios =
*termios,
> +=09=09=09=09struct serial_rs485 *rs485)
> +{
> +=09bool is_rs485 =3D !!(rs485->flags & SER_RS485_ENABLED);
> +=09u8 __iomem *p =3D port->membase;
> +=09u8 value;
> +
> +=09value =3D readb(p + UART_EXAR_FCTR);
> +=09if (is_rs485)
> +=09=09value |=3D UART_FCTR_EXAR_485;
> +=09else
> +=09=09value &=3D ~UART_FCTR_EXAR_485;
> +
> +=09writeb(value, p + UART_EXAR_FCTR);
> +
> +=09if (is_rs485)
> +=09=09writeb(UART_EXAR_RS485_DLY(4), p + UART_MSR);
> +
> +=09return 0;
> +}
> +
> +static const struct serial_rs485 generic_rs485_supported =3D {
> +=09.flags =3D SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND,
> +};
> +
>  static void exar_pm(struct uart_port *port, unsigned int state, unsigned=
 int old)
>  {
>  =09/*
> @@ -459,27 +484,6 @@ static void xr17v35x_unregister_gpio(struct uart_825=
0_port *port)
>  =09port->port.private_data =3D NULL;
>  }
>=20
> -static int generic_rs485_config(struct uart_port *port, struct ktermios =
*termios,
> -=09=09=09=09struct serial_rs485 *rs485)
> -{
> -=09bool is_rs485 =3D !!(rs485->flags & SER_RS485_ENABLED);
> -=09u8 __iomem *p =3D port->membase;
> -=09u8 value;
> -
> -=09value =3D readb(p + UART_EXAR_FCTR);
> -=09if (is_rs485)
> -=09=09value |=3D UART_FCTR_EXAR_485;
> -=09else
> -=09=09value &=3D ~UART_FCTR_EXAR_485;
> -
> -=09writeb(value, p + UART_EXAR_FCTR);
> -
> -=09if (is_rs485)
> -=09=09writeb(UART_EXAR_RS485_DLY(4), p + UART_MSR);
> -
> -=09return 0;
> -}
> -
>  static int sealevel_rs485_config(struct uart_port *port, struct ktermios=
 *termios,
>  =09=09=09=09  struct serial_rs485 *rs485)
>  {
> @@ -518,10 +522,6 @@ static int sealevel_rs485_config(struct uart_port *p=
ort, struct ktermios *termio
>  =09return 0;
>  }
>=20
> -static const struct serial_rs485 generic_rs485_supported =3D {
> -=09.flags =3D SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND,
> -};
> -
>  static const struct exar8250_platform exar8250_default_platform =3D {
>  =09.register_gpio =3D xr17v35x_register_gpio,
>  =09.unregister_gpio =3D xr17v35x_unregister_gpio,
> --
> 2.43.2
>=20
>=20
--8323328-1651817364-1713440243=:986--