Received-SPF: pass (google.com: domain of linux-kernel+bounces-150015-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <442a67cb-8f1c-f6ac-98c1-ef97db52d5a2@huawei.com>
Date: Thu, 18 Apr 2024 19:54:10 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2] pinctrl: devicetree: fix refcount leak in
 pinctrl_dt_to_map()
Content-Language: en-US
To: Andy Shevchenko <andriy.shevchenko@intel.com>
CC: <linus.walleij@linaro.org>, <dan.carpenter@linaro.org>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<liwei391@huawei.com>
References: <20240418113459.4182749-1-zengheng4@huawei.com>
 <ZiEGzuVzV_fV52DR@smile.fi.intel.com>
From: Zeng Heng <zengheng4@huawei.com>
In-Reply-To: <ZiEGzuVzV_fV52DR@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


在 2024/4/18 19:41, Andy Shevchenko 写道:
> On Thu, Apr 18, 2024 at 07:34:59PM +0800, Zeng Heng wrote:
>> If we fail to allocate propname buffer, we need to drop the reference
>> count we just took, otherwise it will lead reference leak. Here the
>> error exit path is modified to jump to the err label and call
>> pinctrl_dt_free_maps() which would drop the counter.
>>
>> In the meantime, if it is found that the property 'pinctrl-0' is not
>> present, ENODEV is returned and also jump to the err label and call the
>> free function, in case the Smatch tool complains.
>> ---
> You forgot a changelog, but I think this needs to be a followup.

Oops, the resend patch would come soon.


Thanks,

Zeng Heng