Received-SPF: pass (google.com: domain of linux-kernel+bounces-150042-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240418105750.98866-1-ioworker0@gmail.com> <20240418105750.98866-4-ioworker0@gmail.com>
 <c73423cb-3288-47aa-b389-22566e883db7@redhat.com>
In-Reply-To: <c73423cb-3288-47aa-b389-22566e883db7@redhat.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Thu, 18 Apr 2024 20:09:17 +0800
Message-ID: <CAK1f24=ZVJ=7Yp5CFzO2kpphexkNuKryWMD-fjhTpLeXSnrETg@mail.gmail.com>
Subject: Re: [PATCH v9 3/4] mm/memory: add any_dirty optional pointer to folio_pte_batch()
To: David Hildenbrand <david@redhat.com>
Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, 21cnbao@gmail.com, 
	mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, 
	shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, 
	songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, 
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18, 2024 at 8:00=E2=80=AFPM David Hildenbrand <david@redhat.com=
> wrote:
>
> On 18.04.24 12:57, Lance Yang wrote:
> > This commit adds the any_dirty pointer as an optional parameter to
> > folio_pte_batch() function. By using both the any_young and any_dirty p=
ointers,
> > madvise_free can make smarter decisions about whether to clear the PTEs=
 when
> > marking large folios as lazyfree.
> >
> > Suggested-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Lance Yang <ioworker0@gmail.com>
> > ---
> >   mm/internal.h | 12 ++++++++++--
> >   mm/madvise.c  | 19 ++++++++++++++-----
> >   mm/memory.c   |  4 ++--
> >   3 files changed, 26 insertions(+), 9 deletions(-)
> >
> > diff --git a/mm/internal.h b/mm/internal.h
> > index c6483f73ec13..daa59cef85d7 100644
> > --- a/mm/internal.h
> > +++ b/mm/internal.h
> > @@ -134,6 +134,8 @@ static inline pte_t __pte_batch_clear_ignored(pte_t=
 pte, fpb_t flags)
> >    *            first one is writable.
> >    * @any_young: Optional pointer to indicate whether any entry except =
the
> >    *            first one is young.
> > + * @any_dirty: Optional pointer to indicate whether any entry except t=
he
> > + *             first one is dirty.
> >    *
>

Hey David,

Thanks for taking time to review!

> I was also wondering if we should make that function return a
> pte+nr_pages, instead of only nr_pages, and then simply have the
> function, based on new flags, merge data into the original PTE.
>

Nice, good idea!

> But let's do that separately.

Yep, let's do that separately :p

>
> Acked-by: David Hildenbrand <david@redhat.com>

Thanks again for the review!
Lance

>
> --
> Cheers,
>
> David / dhildenb
>