Received-SPF: pass (google.com: domain of linux-kernel+bounces-150054-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <23c8a80d-a816-455b-b5ab-d65b159fd90f@amd.com>
Date: Thu, 18 Apr 2024 14:25:59 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/ttm: Print the memory decryption status just once
To: Zack Rusin <zack.rusin@broadcom.com>, dri-devel@lists.freedesktop.org
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>, Ian Forbes
 <ian.forbes@broadcom.com>, Martin Krastev <martin.krastev@broadcom.com>,
 Maaz Mombasawala <maaz.mombasawala@broadcom.com>,
 =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= <thomas.hellstrom@linux.intel.com>,
 linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20240408155605.1398631-1-zack.rusin@broadcom.com>
 <843fdfa2-348b-410e-8ff1-84ab86cac17d@amd.com>
 <CABQX2QMtTB9iiQuce36dnk6eO1Xcsm+Xt3vc1Nk93TGD+TtV9w@mail.gmail.com>
 <5ca415e9-fb3e-4d81-b385-71e8780a1399@amd.com>
 <CABQX2QMaF6e6o4Ewg6sExfaEZMXRaUrNHNYUCAYG3+44P=7epQ@mail.gmail.com>
 <CABQX2QNbbM-frtkVwYWZytUAqP0t0gyyd_tZc_s0bDxu+MaFUg@mail.gmail.com>
Content-Language: en-US
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <CABQX2QNbbM-frtkVwYWZytUAqP0t0gyyd_tZc_s0bDxu+MaFUg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NWV1RlhWWEJUbkpIYTQzaW1NN1N0SXVEZW9PL2FLM0dKaWw2dlVsaUQ2T0Ez?=
 =?utf-8?B?MldBRVpKNFBjMEVmbm1NVVFoN3FITVMveEk1eXY3b0dxYS9vTFFYU2dBV3B2?=
 =?utf-8?B?bVZMclQ3N2IrZW9qeXE5SlJURGF2Uld3bXNaYkY3OWdTeEliZXUrVFJlYnZH?=
 =?utf-8?B?eXQrbWNpa1ZYUWNFaEw2NzlJZVdUa29QclBXbmM1ZFprRGFlVC81NUZRak1O?=
 =?utf-8?B?VnJYckNFOEVVS09pZXdMRGpwQlVoYk1zR01LVzkxRWlpcUQ4L2UxRXJxL01L?=
 =?utf-8?B?VWwvQUY3MUhKSStBVEkrSzNOWm9rUXlsNE4xWHFFRGsxdzV6T0o5cWtvT2FT?=
 =?utf-8?B?SjUyc2Z3K3hjd0xGMFpQc2thQzlhcjBZTTMvQjBNU2dDNXRGMEcxZEYzd0FW?=
 =?utf-8?B?OGVncXRUODlKQ3dZSGJ6YjE5Y3Q3MHZLdjliV2s2ZjBtQWJtM1grS3hOSzha?=
 =?utf-8?B?RnhHbHRicHIzdXYwUzI0WDlXcWpibFp4UG0zUVFjbTVSRDh5SS95bXNaWFZl?=
 =?utf-8?B?RGxjWEY5WUpVRmFCQys5a3NLVWZzME9obXg1ckVEK3A2QWZtc052L09RU0Rr?=
 =?utf-8?B?R2JkYmJ5bEU4OHJoTmFhNC9rRllpUHA0VXZxMTRjRlJ3bTUrczZmUXlUYjEw?=
 =?utf-8?B?WjdPVVI4Mitmc3NzU1Bvb1VQOVJCSCt0L0NDbWlVOHVYemxGVXdQUHh0Z2I5?=
 =?utf-8?B?MVZzNGpCQURZN081SUVuOHpMa0VpTmpjTTUrUlNZUHFvdmVqWCsxNk0zbUUv?=
 =?utf-8?B?bU1neVVuRnV4YTRIbE44TGdyaEtWb2JJbHdIalN3M0dFYW1iTzUxSU5mb2Jz?=
 =?utf-8?B?VlZuMGZIaXBlRytlRTgxZVFqVW00ZnFZViszblRxSlNjTGdtSFEzckp5bGpz?=
 =?utf-8?B?b3lXeG1jUXdSWFR0S2VhSU9ET2hFRFFWaVNZS0NJZjBNNkErRkNVellSVHQv?=
 =?utf-8?B?TXpwOGFZMi9lTGh5ZDN4d3VsbVllR0p0Wlg1YUFTcS9rc2tZSnhuVlBTSHRD?=
 =?utf-8?B?NzAydks0eXIvNmlwZ1hWRGhhU3dncGp2bEMzTWJnV05udUpVcDFXRC90eEto?=
 =?utf-8?B?eTgyYTVBNXM3ZlBjMVg5RXV2b2xLVFNmUDlPaXhIcmZQYUJZL2FkYk90akhi?=
 =?utf-8?B?RG82djJjODN2NWtrUTlRWDVraWVQTUEzN1lpM1pKc002L1dHblMrdG1NWk10?=
 =?utf-8?B?Z3ZnTk8vb3gwaUNCODFjZGpTUnNHaG9icm1sUlhtLzFHaFUvazdYOXNvSnNU?=
 =?utf-8?B?ck5OMy9JSW1nTk1kbi94WlArWHZxS0tkeU1VcmFHNXY5Rmt1NTNUaTNHL0dp?=
 =?utf-8?B?RVczMVJaRy9hcmFUTGRGU0dJNWZuVWxUb21zQkJPWVJMdlFVVVJrY21iS2R3?=
 =?utf-8?B?d3ErZDJEVkdtUnRSbEZoWWthWnRZcGVoUFF1SGorbkJGMmhoRHdYSUkxbE5x?=
 =?utf-8?B?WFVqUnpwZ2orNGIzSmNLYzhhV2UvdU1BRHdQd1JQcE10QVYvQlUrVEZadi9O?=
 =?utf-8?B?ZXJGczVBUGZ4WUQ0L0ZJdGs0aFJCZFVKb1lCY3Nxby9nc3JVUU1uTVRxM1JF?=
 =?utf-8?B?SDhXUkZ0NThBTmFONVQ5dEMvN0laNzhJcGo2Vlhya2xmalV3ZVRpV0llNGZJ?=
 =?utf-8?B?R2VLSVRSWVphY08zeENLb01yU0VyTlc1VFFoQmt1dWFtMEJpajcyK0ViZzhY?=
 =?utf-8?B?QUl1d0lxejl2b1ovOCsrbkZBUU9BMCsvYWNwY0F4Z3BWOEQ3d1MxWlBLeDAr?=
 =?utf-8?B?cGtyQmhMVHlEalI5S2ozSG9vWnAzWFRQdVBjSlNoS0owZlpKb1BqOEtCd0Zy?=
 =?utf-8?B?QnVOQUYyU1VTRXVjYVhYaEVBdm9nM0UxTG9RNHF4c21WSVcvM3FZNjFZc01W?=
 =?utf-8?B?b09peWlRSkp2azA3dndJQm5vMUtGaHRHbUllMHRRK2syTUxQWUdpRFpHcWlw?=
 =?utf-8?B?WEkvVkcwMWNzVWE4R1hidXRVdU54MmgzcXcrMzdRbVlxbVJXdnlObnFhSTA5?=
 =?utf-8?B?WDlIcWo3YjFreG1vKzRjQTBYRGNWQi9zdElnaG9xWkZxUllQdzl0RzVBaGVD?=
 =?utf-8?B?bmZOQXhLZFBHNHN2cTJlMjNVWmpsTk13MHhPUWZGeldsbTU5bmtLKzJzYUVF?=
 =?utf-8?Q?d3Pg7c5ypCCn+WITH8a7fk5nM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a05cb77-3240-42e8-5be7-08dc5fa2b8fb
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 12:26:07.3930
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6/kj2P5dIPmg6zod/XyBncx/Or3NWmUmCj/WiShX7e8n91Q54FpgUsHMUp6AfI1I
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6911

Sorry haven't seen your reply. Feel free to add my rb to the patch.

Regards,
Christian.

Am 18.04.24 um 13:38 schrieb Zack Rusin:
> Ping on this one. If we don't want the "_once" then I can quickly
> prepare a patch that just removes the logging altogether, because
> while useful it's polluting up the kernel logs too much right now so
> getting a fix in for 6.9 for this would be great.
>
> z
>
> On Mon, Apr 8, 2024 at 1:46 PM Zack Rusin <zack.rusin@broadcom.com> wrote:
>> Sorry, apologies to everyone. By accident I replied off the list.
>> Redoing it now on the list. More below.
>>
>> On Mon, Apr 8, 2024 at 12:10 PM Christian König
>> <christian.koenig@amd.com> wrote:
>>> Am 08.04.24 um 18:04 schrieb Zack Rusin:
>>>> On Mon, Apr 8, 2024 at 11:59 AM Christian König
>>>> <christian.koenig@amd.com> wrote:
>>>>> Am 08.04.24 um 17:56 schrieb Zack Rusin:
>>>>>> Stop printing the TT memory decryption status info each time tt is created
>>>>>> and instead print it just once.
>>>>>>
>>>>>> Reduces the spam in the system logs when running guests with SEV enabled.
>>>>> Do we then really need this in the first place?
>>>> Thomas asked for it just to have an indication when those paths are
>>>> being used because they could potentially break things pretty bad. I
>>>> think it is useful knowing that those paths are hit (but only once).
>>>> It makes it pretty easy for me to tell whether bug reports with people
>>>> who report black screen can be answered with "the kernel needs to be
>>>> upgraded" ;)
>>> Sounds reasonable, but my expectation was rather that we would print
>>> something on the device level.
>>>
>>> If that's not feasible for whatever reason than printing it once works
>>> as well of course.
>> TBH, I think it's pretty convenient to have the drm_info in the TT
>> just to make sure that when drivers request use_dma_alloc on SEV
>> systems TT turns decryption on correctly, i.e. it's a nice sanity
>> check when reading the logs. But if you'd prefer it in the driver I
>> can move this logic there as well.
>>
>> z