Received-SPF: pass (google.com: domain of linux-kernel+bounces-150071-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 18 Apr 2024 08:40:15 -0400
From: Parker Newman <parker@finest.io>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v4 0/7] serial: exar: add Connect Tech serial cards to
 Exar driver
Message-ID: <20240418084015.5db5a6a1@SWDEV2.connecttech.local>
In-Reply-To: <2024041801-earthlike-drastic-076a@gregkh>
References: <cover.1713382717.git.pnewman@connecttech.com>
	<2024041801-earthlike-drastic-076a@gregkh>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:eKD3pRiZqFY=;h31ppLCcW88GZ3FaCMxv10M97Tl
 YWCsaMScUFeuuBQs/vCgyfdcUO93HyfLY1COogG3WuMNaGo4TqZdlpRIXae0+0H821w43/UlL
 XySY2K05NVd8eb2So1Lp+SNU2jgSxbUY60VPdOLgdXpDIINA3jtNZPhlq+ngq3CF1YhrjgaJh
 z65WBML4pf8AFbpyvxC5AXgYGYhiFvjv+oP1srqpW5X5Y/JqM3LFbjHCjcF39fcvi1cKIi1S5
 NgM3dnNQiqOAf+bswDfBBubEWRKGlkrgvGE8sNGauVXPcj5nzkiAR373/VnCvs/Jda0MgYDic
 qYUXuwcQyRXlKVEoEncf87YJ/t3VEEj4tV1mZvuYiAywh5L1EL7S6to5mPZOIem3XJ1DdlcST
 BkW5VnTgcJDVynd+0fcjRA6YoD3BlgvR3HGnGBWmc2n49ptlNCs1HmTOIItzEspoa/nzRL3vp
 QNoLxsrE2RciBCmRCy0cDew9C/vzKKZihnVS5Xu3q+Hprnd5LH2IpF3BFiEDa8tJFC/zsmLM8
 DBfvqMu36HBjcSZtgJBcvdkJ/jJEbKUTJzQBD+QIPMw9BjyW2qL60VSoairRwCyfP47sb+1iY
 wRG3ncp+eJ9RYDrieC4sPmZPMgCZDskE98XfFuk0NX5TLmF3OpLbnN6d4LafP1qg1gSpTlcjh
 U/phE9RryWxUpDpK4dqVuxez9BL5FIDypERbyhlcdTHL9SRG1xJvQPyrt5jY76U4QXFQ9gPa4
 Cr5AgU984MyEQzpQy5xzPmqdEoYnEtef3PpstRWbBxix3/QAdsq17M=

On Thu, 18 Apr 2024 08:25:10 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Wed, Apr 17, 2024 at 04:31:22PM -0400, Parker Newman wrote:
> > From: Parker Newman <pnewman@connecttech.com>
> >
> > Hello,
> > These patches add proper support for most of Connect Tech's (CTI) Exar
> > based serial cards. Previously, only a subset of CTI's cards would wor=
k
> > with the Exar driver while the rest required the CTI out-of-tree drive=
r.
> > These patches are intended to phase out the out-of-tree driver.
> >
> > I am new to the mailing lists and contributing to the kernel so please
> > let me know if I have made any mistakes or if you have any feedback.
> >
> > Changes in v2:
> > - Put missing PCI IDs in 8250_exar.c instead of pci_ids.h
> > - Split large patch into smaller ones
> >
> > Changes in v3:
> > - Refactored patches to be easier to follow (based on feedback of v2)
> > - Patch specific changes listed in corresponding patch
> >
> > Changes in v4:
> > - Rebased to tty-testing branch
> > - Removed v3 patch 8/8, "bug" didn't happen in current driver
> > - Patch specific changes listed in corresponding patch
> >
> > Thank you,
> >
> > Parker Newman (7):
> >   serial: exar: remove old Connect Tech setup
> >   serial: exar: added a exar_get_nr_ports function
> >   serial: exar: add optional board_init function
> >   serial: exar: moved generic_rs485 further up in 8250_exar.c
> >   serial: exar: add CTI cards to exar_get_nr_ports
> >   serial: exar: add CTI specific setup code
> >   serial: exar: fix checkpach warnings
> >
> >  drivers/tty/serial/8250/8250_exar.c | 981 ++++++++++++++++++++++++++-=
-
> >  1 file changed, 916 insertions(+), 65 deletions(-)
>
> Nice, compared to your first version, this is less code overall in this
> file:
>    1 file changed, 1019 insertions(+), 70 deletions(-)
>
> so the review process helped!
>

Yes thanks again for your patience. I learned a lot about the process :).

> All now applied to my tree, thanks for the revisions.  And a follow-on
> patch to fix up the kbuild warning would be appreciated.
>

I will follow up with a mini-series now to fix the kbuild warnings and a
couple minor things mentioned by Ilpo.

Thanks,
Parker

> thanks,
>
> greg k-h