Received-SPF: pass (google.com: domain of linux-kernel+bounces-149971-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 18 Apr 2024 14:32:51 +0300 (EEST)
To: Parker Newman <parker@finest.io>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    Jiri Slaby <jirislaby@kernel.org>, LKML <linux-kernel@vger.kernel.org>, 
    linux-serial <linux-serial@vger.kernel.org>, 
    Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v4 3/7] serial: exar: add optional board_init function
In-Reply-To: <0e72a3154114c733283ff273bc1e31456ee101f4.1713382717.git.pnewman@connecttech.com>
Message-ID: <60feac79-2e71-4a66-729e-80d12cb660f2@linux.intel.com>
References: <cover.1713382717.git.pnewman@connecttech.com> <0e72a3154114c733283ff273bc1e31456ee101f4.1713382717.git.pnewman@connecttech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1710506478-1713439971=:986"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1710506478-1713439971=:986
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 17 Apr 2024, Parker Newman wrote:

> From: Parker Newman <pnewman@connecttech.com>
>=20
> Add an optional "board_init()" function pointer to struct exar8250_board
> which is called once during probe prior to setting up the ports. It will
> be used in subsequent patches of this series.
>=20
> Signed-off-by: Parker Newman <pnewman@connecttech.com>
> ---
> Changes in v3:
>  - Renamed board_setup to board_init.
>  - Changed pci_err to dev_err_probe
>  - Added note above about checkpatch fixes
>=20
> Changes in v4:
>  - Removed checkpatch fixes, they will be in their own patch at the end
>  - Added pcidev to board_init() args to avoid needing to add to priv
>=20
>  drivers/tty/serial/8250/8250_exar.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/825=
0/8250_exar.c
> index 72385c7d2eda..f14f73d250bb 100644
> --- a/drivers/tty/serial/8250/8250_exar.c
> +++ b/drivers/tty/serial/8250/8250_exar.c
> @@ -177,12 +177,14 @@ struct exar8250_platform {
>   * struct exar8250_board - board information
>   * @num_ports: number of serial ports
>   * @reg_shift: describes UART register mapping in PCI memory
> - * @setup: quirk run at ->probe() stage
> + * @board_init: quirk run once at ->probe() stage before setting up port=
s
> + * @setup: quirk run at ->probe() stage for each port
>   * @exit: quirk run at ->remove() stage
>   */
>  struct exar8250_board {
>  =09unsigned int num_ports;
>  =09unsigned int reg_shift;
> +=09int     (*board_init)(struct exar8250 *priv, struct pci_dev *pcidev);
>  =09int=09(*setup)(struct exar8250 *, struct pci_dev *,
>  =09=09=09 struct uart_8250_port *, int);
>  =09void=09(*exit)(struct pci_dev *pcidev);
> @@ -773,6 +775,15 @@ exar_pci_probe(struct pci_dev *pcidev, const struct =
pci_device_id *ent)
>  =09if (rc)
>  =09=09return rc;
>=20
> +=09if (board->board_init) {
> +=09=09rc =3D board->board_init(priv, pcidev);
> +=09=09if (rc) {
> +=09=09=09dev_err_probe(&pcidev->dev, rc,
> +=09=09=09=09=09"failed to init serial board\n");
> +=09=09=09return rc;
> +=09=09}
> +=09}
> +

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-1710506478-1713439971=:986--