Received-SPF: pass (google.com: domain of linux-kernel+bounces-150091-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <89b534ab-ce9f-4a8a-984c-8460f686980d@redhat.com>
Date: Thu, 18 Apr 2024 14:44:34 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 4/4] mm/madvise: optimize lazyfreeing with mTHP in
 madvise_free
To: Lance Yang <ioworker0@gmail.com>
Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, 21cnbao@gmail.com,
 mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com,
 shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com,
 songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20240418105750.98866-1-ioworker0@gmail.com>
 <20240418105750.98866-5-ioworker0@gmail.com>
 <2fdcee93-b8ad-4374-a8ab-7c7bed463813@redhat.com>
 <CAK1f24m4y0kvmdFtHoJoPZeF9aeRpw4nnr1W5BMRz_OH49dHvg@mail.gmail.com>
From: David Hildenbrand <david@redhat.com>
Content-Language: en-US
Autocrypt: addr=david@redhat.com; keydata=
 xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ
 dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL
 QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp
 XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK
 Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9
 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt
 WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc
 UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv
 jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb
 B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk
 ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW
 AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q
 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp
 rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf
 wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4
 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l
 pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd
 KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE
 BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs
 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF
 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9
 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz
 Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb
 T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A
 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk
 CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G
 NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75
 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx
 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS
 lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv
 AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa
 N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3
 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB
 boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq
 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f
 XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ
 a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq
 Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6
 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8
 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E
 th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr
 jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt
 WNyWQQ==
Organization: Red Hat
In-Reply-To: <CAK1f24m4y0kvmdFtHoJoPZeF9aeRpw4nnr1W5BMRz_OH49dHvg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 18.04.24 14:33, Lance Yang wrote:
> On Thu, Apr 18, 2024 at 8:03 PM David Hildenbrand <david@redhat.com> wrote:
>>
>> On 18.04.24 12:57, Lance Yang wrote:
>>> This patch optimizes lazyfreeing with PTE-mapped mTHP[1]
>>> (Inspired by David Hildenbrand[2]). We aim to avoid unnecessary folio
>>> splitting if the large folio is fully mapped within the target range.
>>>
>>> If a large folio is locked or shared, or if we fail to split it, we just
>>> leave it in place and advance to the next PTE in the range. But note that
>>> the behavior is changed; previously, any failure of this sort would cause
>>> the entire operation to give up. As large folios become more common,
>>> sticking to the old way could result in wasted opportunities.
>>>
>>> On an Intel I5 CPU, lazyfreeing a 1GiB VMA backed by PTE-mapped folios of
>>> the same size results in the following runtimes for madvise(MADV_FREE) in
>>> seconds (shorter is better):
>>>
>>> Folio Size |   Old    |   New    | Change
>>> ------------------------------------------
>>>         4KiB | 0.590251 | 0.590259 |    0%
>>>        16KiB | 2.990447 | 0.185655 |  -94%
>>>        32KiB | 2.547831 | 0.104870 |  -95%
>>>        64KiB | 2.457796 | 0.052812 |  -97%
>>>       128KiB | 2.281034 | 0.032777 |  -99%
>>>       256KiB | 2.230387 | 0.017496 |  -99%
>>>       512KiB | 2.189106 | 0.010781 |  -99%
>>>      1024KiB | 2.183949 | 0.007753 |  -99%
>>>      2048KiB | 0.002799 | 0.002804 |    0%
>>>
>>> [1] https://lkml.kernel.org/r/20231207161211.2374093-5-ryan.roberts@arm.com
>>> [2] https://lore.kernel.org/linux-mm/20240214204435.167852-1-david@redhat.com
>>>
>>> Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
>>> Signed-off-by: Lance Yang <ioworker0@gmail.com>
>>> ---
>>>    mm/madvise.c | 85 +++++++++++++++++++++++++++-------------------------
>>>    1 file changed, 44 insertions(+), 41 deletions(-)
>>>
>>> diff --git a/mm/madvise.c b/mm/madvise.c
>>> index 4597a3568e7e..375ab3234603 100644
>>> --- a/mm/madvise.c
>>> +++ b/mm/madvise.c
>>> @@ -643,6 +643,7 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr,
>>>                                unsigned long end, struct mm_walk *walk)
>>>
>>>    {
>>> +     const cydp_t cydp_flags = CYDP_CLEAR_YOUNG | CYDP_CLEAR_DIRTY;
>>>        struct mmu_gather *tlb = walk->private;
>>>        struct mm_struct *mm = tlb->mm;
>>>        struct vm_area_struct *vma = walk->vma;
>>> @@ -697,44 +698,57 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr,
>>>                        continue;
>>>
>>>                /*
>>> -              * If pmd isn't transhuge but the folio is large and
>>> -              * is owned by only this process, split it and
>>> -              * deactivate all pages.
>>> +              * If we encounter a large folio, only split it if it is not
>>> +              * fully mapped within the range we are operating on. Otherwise
>>> +              * leave it as is so that it can be marked as lazyfree. If we
>>> +              * fail to split a folio, leave it in place and advance to the
>>> +              * next pte in the range.
>>>                 */
>>>                if (folio_test_large(folio)) {
>>> -                     int err;
>>> +                     bool any_young, any_dirty;
>>>
>>> -                     if (folio_likely_mapped_shared(folio))
>>> -                             break;
>>> -                     if (!folio_trylock(folio))
>>> -                             break;
>>> -                     folio_get(folio);
>>> -                     arch_leave_lazy_mmu_mode();
>>> -                     pte_unmap_unlock(start_pte, ptl);
>>> -                     start_pte = NULL;
>>> -                     err = split_folio(folio);
>>> -                     folio_unlock(folio);
>>> -                     folio_put(folio);
>>> -                     if (err)
>>> -                             break;
>>> -                     start_pte = pte =
>>> -                             pte_offset_map_lock(mm, pmd, addr, &ptl);
>>> -                     if (!start_pte)
>>> -                             break;
>>> -                     arch_enter_lazy_mmu_mode();
>>> -                     pte--;
>>> -                     addr -= PAGE_SIZE;
>>> -                     continue;
>>> +                     nr = madvise_folio_pte_batch(addr, end, folio, pte,
>>> +                                                  ptent, &any_young, NULL);
>>> +
>>> +                     if (nr < folio_nr_pages(folio)) {
>>> +                             int err;
>>> +
>>> +                             if (folio_likely_mapped_shared(folio))
>>> +                                     continue;
>>> +                             if (!folio_trylock(folio))
>>> +                                     continue;
>>> +                             folio_get(folio);
>>> +                             arch_leave_lazy_mmu_mode();
>>> +                             pte_unmap_unlock(start_pte, ptl);
>>> +                             start_pte = NULL;
>>> +                             err = split_folio(folio);
>>> +                             folio_unlock(folio);
>>> +                             folio_put(folio);
>>> +                             start_pte = pte =
>>> +                                     pte_offset_map_lock(mm, pmd, addr, &ptl);
>>
>> I'd just put it on a single line.
> 
> start_pte = pte = pte_offset_map_lock(mm, pmd, addr, &ptl);
> 
> I suddenly realized that putting it on a single line would exceed the
> 80-char limit.

Which is fine according to Documentation/process/coding-style.rst

.. as long as it aids readability.

Alternatively, the following might do:

pte = pte_offset_map_lock(mm, pmd, addr, &ptl);
start_pte = pte;

-- 
Cheers,

David / dhildenb