Received-SPF: pass (google.com: domain of linux-kernel+bounces-150138-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 18 Apr 2024 08:10:24 -0500
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: vkoul@kernel.org, pankaj.gupta@nxp.com,
	20240409185416.2224609-1-Frank.Li@nxp.com, shenwei.wang@nxp.com,
	xu.yang_2@nxp.com, shengjiu.wang@nxp.com,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	krzk@kernel.org, linux-kernel@vger.kernel.org, peng.fan@nxp.com,
	imx@lists.linux.dev, conor+dt@kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v5 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains'
 property
Message-ID: <171344580514.1090639.5974994638297885495.robh@kernel.org>
References: <20240417152457.361340-1-Frank.Li@nxp.com>
 <20240417152457.361340-2-Frank.Li@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417152457.361340-2-Frank.Li@nxp.com>


On Wed, 17 Apr 2024 11:24:57 -0400, Frank Li wrote:
> Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> it. EDMA supports each power-domain for each dma channel. So minItems and
> maxItems align 'dma-channels'.
> 
> Change fsl,imx93-edma3 example to fsl,imx8qm-edma to reflect this variants.
> 
> Fixed below DTB_CHECK warning:
>   dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> 
> Notes:
>     Change from v4 to v5
>     - Add description according to rob's suggest.
> 
>      "The number of power domains matches the number of channels, arranged
>      in ascending order according to their associated DMA channels."
> 
>     Change from v3 to v4
>     - Remove 'contains' change should be belong to first patch when rebase.
> 
>     make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,edma.yaml
>       LINT    Documentation/devicetree/bindings
>       DTEX    Documentation/devicetree/bindings/dma/fsl,edma.example.dts
>       CHKDT   Documentation/devicetree/bindings/processed-schema.json
>       SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>       DTC_CHK Documentation/devicetree/bindings/dma/fsl,edma.example.dtb
> 
>     After this patch no warning for imx8dxl-evk.dtb.
> 
>     touch arch/arm64/boot/dts/freescale/imx8dxl.dtsi
>     make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  CHECK_DTBS=y freescale/imx8dxl-evk.dtb
>       DTC_CHK arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb
> 
>     Change from v2 to v3
>     - set 'power-domains' false for other compatitble string
>     - change imx93 example to 8qm example to affect this change according to
>     Krzysztof Kozlowski's suggestion, choose least channel number edma
>     instance to reduce code copy. max channel number is 64.
> 
>     - Rebase to latest dmaengine/next, fixes conflicts.
> 
>     Change from v1 to v2
>     - using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
>     - add power-domains to 'required' when compatible string is fsl,imx8qm-adma
>         or fsl,imx8qm-edma
> 
>  .../devicetree/bindings/dma/fsl,edma.yaml     | 80 ++++++++++---------
>  1 file changed, 42 insertions(+), 38 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>