Received-SPF: pass (google.com: domain of linux-kernel+bounces-150131-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Siddh Raman Pant <siddh.raman.pant@oracle.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC: "cve@kernel.org" <cve@kernel.org>,
        "linux-cve-announce@vger.kernel.org"
	<linux-cve-announce@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: [External] : Re: CVE-2024-26920: tracing/trigger: Fix to return
 error if failed to alloc snapshot
Thread-Topic: [External] : Re: CVE-2024-26920: tracing/trigger: Fix to return
 error if failed to alloc snapshot
Thread-Index: AQHakYflavlUUMfH9kOorpGL09z+TLFt9pSAgAAI2AA=
Date: Thu, 18 Apr 2024 13:06:42 +0000
Message-ID: <92ec3ce16c7e640de19b44165e2bb88b63dd2478.camel@oracle.com>
References: <2024041738-CVE-2024-26920-a681@gregkh>
	 <6fa1eb4368cbaa2d0b243539f1d91692da95e117.camel@oracle.com>
	 <2024041805-rippling-entourage-1a72@gregkh>
In-Reply-To: <2024041805-rippling-entourage-1a72@gregkh>
Accept-Language: en-US, en-IN
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RkxPaVBTaFRSTUZSeDZlK0ZzUjZLaXVBRmR6eDJlUGtwZGVSaFJOQ21QL1g0?=
 =?utf-8?B?Y1o2aDgxejQ5WG9RV2tISFVCb1ZMUkova0RvbDlHbHVjYld1ZEk5dklaRTEz?=
 =?utf-8?B?Nm9XaGhyb0RqRklwYURRS2ZDc3ZmS0pHblVzcytSOXd5SDEzNFFTV1lWZ1JC?=
 =?utf-8?B?VU5aeUdNUG1xT0l5SHNLQllQYnBOd3ZMVUlkZCs5WnpVRTBFSmpqYjM4dGgv?=
 =?utf-8?B?SVNzajBybnU2eEtseEt1N3FQcys3YXE1RlhqM0dSQWNsMFVCL05ZNXFLSzhi?=
 =?utf-8?B?RWNISDRTZVFkV3hYSGVDK3pSMGprVEpvNHFrUEJjUDVjSVM3azhhRnZCNFJL?=
 =?utf-8?B?Y3ZTNDN4Vm1qUjkvNmpVNG9pamhzUVAwVCs0M3ZKU1JjclUrK3djUXJ1dThB?=
 =?utf-8?B?cEJvbjFLb0FRNGhIR3BueFVXUHZWNVorbkhkRTdjNFVOK0FoUXR5aU1MVVNQ?=
 =?utf-8?B?TFNsWjRRbTR4UUlsYmd0Z0lkWlZGd05WczZxSzZBbzZ6MTNaWnNyNnJ1ZGJI?=
 =?utf-8?B?VW1sOWUwdUptWUd5VXNBQzdMRWlmR1JIZHR3ZDNpZ0RLS01GMExJaTR3ODBr?=
 =?utf-8?B?S00zQThzQzJzU2Y0emtWTi96Ky8wcVdNMnBLSTQ2RFBLUXR1Z3M2c0o1Wldw?=
 =?utf-8?B?eDY2eGJOMm9lTVZVN2FQVkFoaU5mcGRFMXZTZm80RHRIMzV0LzZOSnJWZXRB?=
 =?utf-8?B?ZVEvYTlEUWFleENHYkF3djR5blpVM0pVdEZpQXQ1a2RZSS84L3ljUXhCNG91?=
 =?utf-8?B?OXBkZGFuYW1MWlVoYUQxRTREZEZmVWh2cFNaTmFFUnZuQm9WOURJcHRpUEhW?=
 =?utf-8?B?L1lCeU5ITFNTYVVUelFBSkM5RG82S0ptcU9NcTRiaStkaXpLbm5QdHZMWC9S?=
 =?utf-8?B?bm9sU2NQaGVGenl5dHJBTnFjR2RRcThURnp4WHZucGlaWWFHUHBoNkZEZ2o2?=
 =?utf-8?B?eUNqSlVRcE5pOTROc1lhZEhlS1ltSEppWG9oYUlTWlFqL1ZCS3ErNE9Yek1v?=
 =?utf-8?B?QVoyam1wS080ZG0xcE1wNDFpamZOYVRLSFdJT3ZENUJIMWR6cU55SWpSMzBO?=
 =?utf-8?B?L1pqTk9mU09YdUtOWHVIRVNOSjU4UG12eCtLNWNKNCtwc1I5Z2dMUkdOdHA4?=
 =?utf-8?B?WHNtUVUyazZ0emREd2hJNnh6UVJGc045UUYxTzJlODdqSTM3UmE2S3I0Skgr?=
 =?utf-8?B?em1vMkQvelhlTytzSjQ2d0Q1blVNSDI2cStkOVdiMlhwTnh0WkxWbDNjaWNU?=
 =?utf-8?B?UEU3QnZaWDJkeWNoVllyZ0Q0YkkrcDNBVWIwc3BQSFh4T0F1UnIzT2VHSjhM?=
 =?utf-8?B?dTY0MllVeExPMXRQTUU3MnJzODFJbjlkdFBKUitrSXc0M2xkcU5ZaWZMWjNB?=
 =?utf-8?B?dHF0V1FsTWhVRU45amN6WkxscWtIV3lBbjZ4RGJjU2pWdzFtZXIyQ250c1Bi?=
 =?utf-8?B?TGJFck5pT3pBRjNWTDJBcTB3V0ptd1VBK0MyNmk3QnpyUnFnbHhNK0VlYk9h?=
 =?utf-8?B?cHJSamhlVzBXMEZSRkZGa2ZmM3g4dG1INHlSY0Qrc0RMTUFmbnppQk9iaVRn?=
 =?utf-8?B?MHQ4YVd5T2o0bno1enZmYmdNdTNiZW51eWdwZm5sQ1pnaU5wV2JzNkJ2djNI?=
 =?utf-8?B?NVU4UmV6c20vSGNnQWEvR243MGdLYW0vNHRNSGNpTTllRU9XakdxRUUvNDkz?=
 =?utf-8?B?OVRNTlFROUpXbnlQZUZ4RmtHczAyNDBrcTUrbk5hU0N2TGx2L2tmNlFKdXIw?=
 =?utf-8?B?ODhYNGt6MXJaQXVVZXlqbzgvT2RHSFVPTjVOcC9oMEpuZjhGVE9IWjM0SDZQ?=
 =?utf-8?B?Q3NJMVRXd2srS0Y1dFMxOG03N0ZhakRmeCtMTWxYbjg4MDZiYnYyNWo4VUxn?=
 =?utf-8?B?MUdYaHdMNTFTbHgyQlBpWWR0eVdudDJocEdiT3JGNnhyTEZFN1Zmb3JDcSsz?=
 =?utf-8?B?R3c2RjR4QVAyY1ZTbHhaRytwazhKMXJxYko2S0VDd3JDWU9iMGVLRU1RaVhY?=
 =?utf-8?B?akd2aWJwS3VjYXF6MEt2TVFGZUVCeDBEaVJkVVlXK1laVW1jQXJod0Y2K095?=
 =?utf-8?B?U1VXOEZwNEpWaHZGcitZclZBWkR2WU9KbjlJTUIrMGV6d0xSWHdrZm12bXhs?=
 =?utf-8?B?cGxvbkpOc0Zna2JWSEM3dnpNWk82T3IwMnQxSE5NbVF2ODVNZ2ZNS1c2cit1?=
 =?utf-8?Q?+mqFOnzwROASj/lSt0P5wDo4B6vqbLuMAwNsFvS4920q?=
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="=-JAhC1ryRAGvOU1zuwHLD"
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	sYCy0DEkkVR9l+Bb3BkWaybgDcw5+EvP2dqwxvufLuMrNMOR6toMuE0DQR2PV9/wXBD2jppjlkFFz12lxX/ctZEst4RUi5nwXTG13m1Epx0OoxXCi7I3yVtVgGEgpEEw+D7kqvAczWTAcE3QT7n/0PGs82R5HMx7FSI985EpGAZnMJCtKUIL4U4T0r43/OmuzDfiU2rZFyyGW4bybYu4RUinAqCqEfcFkvyxkvHwEAED2awDzT6/23iaPiMsMIbt3m6thsGNogeEjuHypTkdiiYdCmohAfRGRwyIvKtz/h+z/JgrbtMiIfZbQlMS0c6T2vNEs7STSkjWP3CWqXbPgyVieKZkfmw/3thymeoH+G6eClFFE1lJ0XotfEWiZMnipNXS4xrWfUnj4SX4NiVxKXIbyuiqOYD3wT/zKn1rwYWIOkJwottT3qmaKXiUqF6THRro3wgxLISPY699mdnep6L26tDNRsxVRC2U8uYEbwI53DiN6yqkglIJw8lAnctHmiNB+Uj0+DYeLnk5QfaAZRoCN65HjGNcob7opLuybuI6zQxHsO4hiMmDb7EJOqdNNNPpUyW3AHovLr66zj+yuMtIVATfd+JQQPf5AoYPR0o=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB2810.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 434ea3ab-13c5-4c30-7a04-08dc5fa86476
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2024 13:06:42.4058
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qdSi6PPwjXg/mTcK3TRfM8U5JUQzFKnQ9XJgrN3dvzKD6yGpGy/CcYIfOpDc6SpYEMkzcB+86IqbR9zZwMsbH2Y+XrB3VtH6Q/jtTqrXcmg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6729
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-18_11,2024-04-17_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404180093
X-Proofpoint-ORIG-GUID: 5uOdh-UHVV5JUanuzfEF3paOJJqblc_J
X-Proofpoint-GUID: 5uOdh-UHVV5JUanuzfEF3paOJJqblc_J

--=-JAhC1ryRAGvOU1zuwHLD
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18 2024 at 14:34:57 +0200, gregkh@linuxfoundation.org
wrote:
> On Thu, Apr 18, 2024 at 11:59:41AM +0000, Siddh Raman Pant wrote:
> > Hi Greg,
> >=20
> > > In the Linux kernel, the following vulnerability has been resolved:
> > >=20
> > > tracing/trigger: Fix to return error if failed to alloc snapshot
> > >=20
> > > Fix register_snapshot_trigger() to return error code if it failed to
> > > allocate a snapshot instead of 0 (success). Unless that, it will regi=
ster
> > > snapshot trigger without an error.
> >=20
> > This commit is problematic on 4.19.y, 5.4.y, 5.10.y, and 5.15.y,
> > and should be reversed, and this CVE should be rejected for those
> > versions.
>=20
> Then please submit a patch for this.

Sure.


> But note, CVEs are not for specific versions, sorry.  We give a hint as
> to what kernel versions might be affected, but we don not assign CVE to
> versions.

Cool.

> >=20
> > The return value should be 0 on failure, because in the functions
> > event_trigger_callback() and event_enable_trigger_func(), we have:
> >=20
> > 	ret =3D cmd_ops->reg(glob, trigger_ops, trigger_data, file);
> > 	/*
> > 	 * The above returns on success the # of functions enabled,
> > 	 * but if it didn't find any functions it returns zero.
> > 	 * Consider no functions a failure too.
> > 	 */
> > 	if (!ret) {
> > 		ret =3D -ENOENT;
> >=20
> > Thus, the commit breaks this assumption.
> >=20
> > This commit needs b8cc44a4d3c1 ("tracing: Remove logic for registering
> > multiple event triggers at a time") as a prerequisite, as it removes
> > the above.
>=20
> Should we just take that patch instead?

The series in which the patch is posted is here:
- https://lore.kernel.org/lkml/cover.1644010575.git.zanussi@kernel.org/
- https://lore.kernel.org/lkml/cover.1641823001.git.zanussi@kernel.org/

Seems like some good tracing subsystem refactoring. So if I understand
Documentation/process/stable-kernel-rules.rst correctly, I would say we
should not.

Thanks,
Siddh

--=-JAhC1ryRAGvOU1zuwHLD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEQ4+7hHLv3y1dvdaRBwq/MEwk8ioFAmYhGtsACgkQBwq/MEwk
8irmGg/9E8tYBkfLbPAvvI3LhRki3vAjOjQI7neB/4Z7Cy2UuMUdp8XcsHvwnwXP
Drjam9ycJFRy0N0sOOZVKk6UF0t6A2RgNbaxkjYMfI6vSSFo/MaG2MrvSzJLTJut
pConpoNB3SDJePhhVv1uiEF0ANQEkGeMAW/iO4FOF7Dye66Bde3lD7AFgz3qo9bY
rqkfisBqAYZUMqReNq6lLt0IbKxRgw9WOY+YedzH56wqz9yuYllCJiFhCRIumdAW
gKZcPk2ARzNaTOn6kZGtV17LyjuKq8LjQ0AD7qNdrpIifEcx6Ilv0ynbcrufaDn5
0JBEe8SAuMsFt9haCEYIIO23IEzjaxgj5J6Ua9vrBUuQhNC+kcfouK3qUnMw0XbX
rA/+3+rkPOrfaT4JrfBeMeRbq+y7DkAo/JfTJfxJcJddsSg6odGM1kglJ0n3WZiE
BNiHDMcYDAp8uBmSE78FWxmH303im9zexBXnRTVbgL26hTJK079r9svSTycVB1q4
3mSt4LjeYzz5heGGrMufJrmyel5AlCohBlODRH7dzAzTsKIlxEEp683EDW9LBN9S
nCu8jlhufCTookGegNYrbSxuFq0CFjeazoM6uBWuSnXyecNRRshw136vH9ZFKLD/
qEVXLupwSGpcHyzfz9G909MR8wRthj0D09jyvhxPMCEphr6Swh4=
=m4Ys
-----END PGP SIGNATURE-----

--=-JAhC1ryRAGvOU1zuwHLD--