Received-SPF: pass (google.com: domain of linux-kernel+bounces-150203-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a5d9f8e6-3a1d-53ce-cf92-d8918f673d87@amd.com>
Date: Thu, 18 Apr 2024 08:49:49 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v4 2/5] x86/kexec: do unconditional WBINVD for bare-metal
 in relocate_kernel()
Content-Language: en-US
To: Kai Huang <kai.huang@intel.com>, linux-kernel@vger.kernel.org
Cc: x86@kernel.org, dave.hansen@intel.com, bp@alien8.de,
 kirill.shutemov@linux.intel.com, tglx@linutronix.de, mingo@redhat.com,
 hpa@zytor.com, luto@kernel.org, peterz@infradead.org,
 rick.p.edgecombe@intel.com, ashish.kalra@amd.com, chao.gao@intel.com,
 bhe@redhat.com, nik.borisov@suse.com, pbonzini@redhat.com, seanjc@google.com
References: <cover.1713439632.git.kai.huang@intel.com>
 <6cbd40389458acbfdbd2d804da1d363dec06f750.1713439632.git.kai.huang@intel.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <6cbd40389458acbfdbd2d804da1d363dec06f750.1713439632.git.kai.huang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TVJ5VDNsTk16bzV4TnZYay93SXdDL09GaEdvQmFvbFg3VVpSYlVaNC9sMDl0?=
 =?utf-8?B?QzA2Q296NFFJOTBma0FlV1VGOUN0VFBhazh0L2Y3Q2RJMHRmU1lmeXBwekxl?=
 =?utf-8?B?RVRuWmY2WEIwUzRiMnVFbkhRUkRMWHlQRkRuZ0VMN3Y1TlBOWC96OEZtRnFK?=
 =?utf-8?B?YkZVSDJIb2JjYkhhdzAwWm9lSHFvMWI5K0pIRlkvZEpsdm0wSmpRYmZDN0Ey?=
 =?utf-8?B?UFkxeTFha3A1NTdYckJJenZvWHVyeUVUTXhNcnZHYUQrRUpLSGdFcFFjdU1p?=
 =?utf-8?B?aUtqNkVQYjhuMWQ1YmJ3Z2hSVXAwMjY2K3NHNXVTK0dtekNyTFZXZmRLR0xJ?=
 =?utf-8?B?WWoveWJoQW5IVVhWNWptR3RSK045cnNtMlVwK2hLNVpHWXJpNVF2b1dNNHlB?=
 =?utf-8?B?emFLaUd6emtKb2U0ZkJNUmwwei9QaTR3dFNtZEpWYU1acFZWR1BlbG1FN2pS?=
 =?utf-8?B?dmRtODRVYS9UNUNhTnVUbER3c2lGQlFwN3ZiMStta21YMFRXRXZVTUpaQk5N?=
 =?utf-8?B?dWx3OVgxU2w5YjU1OGtLVS9hR0Mzd1VrUk50TVMxYko3ZTlFYUQ0L3FtYkRl?=
 =?utf-8?B?Zjc0VzZralUzdGJmcXFGYllJZDRtRkxNbldxcHg5UGdZTUFZOGlMZkt3NVk5?=
 =?utf-8?B?TjhaVHRDN0FlZmV6b2tOSTFJL1BZbVIwdkQrbEhIalpFcDJRN3ZrZno5MjFn?=
 =?utf-8?B?RTJUNTE4c2JkaHBuSURYamJkdmZ3OHJ5d0phV2ZmVy9ldVNhQ1UweUlSMGZI?=
 =?utf-8?B?dnpsb0VkUDJlNW52elBSSHNiNldNRjIzbUhFbGFzbEUrMzVsSTFvT0RybHpx?=
 =?utf-8?B?ZFY0RjlMSTFzRXlmMVgrT2NnMmEvMEhLb2lVT1NtRGN2Rlg3RDdnb01wK3NT?=
 =?utf-8?B?VmRKTERmL3VzcW9hTGl4c1hqNnNXUFphQmlOS21Odm1rR2JEQ1U3Wk9Tbmd2?=
 =?utf-8?B?c1NNNVJBS013UEY5cHVmYVB3KzNRckNBaXBybExvN3Y2bUVRSW4zRnY4RjRL?=
 =?utf-8?B?cHl6SjU1eWNiUG94aVVQeXJPZzBKQU5oMGJBcHkrR0E1cFBORVlvNVpqaVBj?=
 =?utf-8?B?UXc4bWdzT1hERXB0NEdveGlXNHpsNklHbGNEZktDSFBRWVlSRVRaekE1OWJs?=
 =?utf-8?B?eEF5YUpUcWMxandubjZXL2xkWllzT1JoZmREUnZTQjVKLzlMMHp3OXcvQlN3?=
 =?utf-8?B?Vkl6blNqcWFheHB4TlJmRzRFajBzajJjbVN6bXp5eHJiaklKYjd5aWNqWVlY?=
 =?utf-8?B?UWp2U3ZxVU5xVzFXOVpIWXZRQ3hBNWlpOXRnNUh2SmlyVDNBZzFPYVhWVmNv?=
 =?utf-8?B?T0pSU1FtZHFwWVZIc2VPV28zdTNVT3ltWWRPN0I5WURKcTQrTTkvUU1yZFAy?=
 =?utf-8?B?eDk1aUZSc1JiT3A3K1ZqM3llVEJyYzd0aGQ0clhvdUl2dUFYUE1MTXk1RU9s?=
 =?utf-8?B?MFdNbHJmdUtibUFneEVyd0lLb2xhR0RGR0tndEpqVlJ3dDRacTIvVDg2N1Bm?=
 =?utf-8?B?VFI5Mnp4cHg1N1o4ZDZmUHh1cTNLV2djYlBSUlRrMU9GUjZ0MGRkYTdvcmNB?=
 =?utf-8?B?RFh1MTRqUFI2U3ZLWFlQSUo3V3RZZkZOSXhjeUk1UkFrK1JkUjVkTDIyOHQr?=
 =?utf-8?B?V1k2dTJIdXVicFh1dUV2Zmtpb25LYVdjMjZVUGZJeVBjVWxQU2d3T1lDdFNs?=
 =?utf-8?B?bHJiKzBoQVNOVFBpYk9jaTkwbTZlMEpPK2JacklOM2JqcFVLZjQyMmJHbTY1?=
 =?utf-8?B?T3NlbWRxY3ZZbmt1eVE1QWxQd3UvK2NLZzQ0eTZlN1dFUkNxcHR6Q1JrVXkr?=
 =?utf-8?B?SVBBbWhYMWJ4aFBKY2R5OGcvQXJ4SFpqRGVrR3NWOUZ5OTViUGdBVmhPSDEx?=
 =?utf-8?B?eWsvMlhvSDNjcEZrSldvUkkxVGVuaXhvQ1o3VnlGMTNPT0JjZG81TDdDUW5N?=
 =?utf-8?B?OUhUOEhzaS9YQVU0MTUyVnhtd3BXR25EUUxSYVhhUEwwa1k2Wk1xQk8zbG5Y?=
 =?utf-8?B?SzJlcHEySGE3UXVNNElkNUVMVG1NdHRrVDhzd1dEaDhEM29HRDVGNUtJQlNm?=
 =?utf-8?B?a21HcVQ1ODVZWHVHL091czBTcDN2UmROaUxicFJ2NmNCM3NwUDVCeDE3N2dR?=
 =?utf-8?Q?h+hkq4XSE008xOg8nLIAqb9rk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f096f073-01cf-4fd8-ec8b-08dc5fae6cbc
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 13:49:53.4628
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 61ksMDkAAl2Rqenao/B5Sc2V9D5JKVWemZUJQw2v9I05tmWe3303f4dp3g5vAfQHy5GE/622xg6mcLAT2yQXuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6878

On 4/18/24 06:48, Kai Huang wrote:
> Both SME and TDX can leave caches in incoherent state due to memory
> encryption.  During kexec, the caches must be flushed before jumping to
> the second kernel to avoid silent memory corruption to the second kernel.
> 
> During kexec, the WBINVD in stop_this_cpu() flushes caches for all
> remote cpus when they are being stopped.  For SME, the WBINVD in
> relocate_kernel() flushes the cache for the last running cpu (which is
> executing the kexec).
> 
> Similarly, to support kexec for TDX host, after stopping all remote cpus
> with cache flushed, the kernel needs to flush cache for the last running
> cpu.
> 
> Use the existing WBINVD in relocate_kernel() to cover TDX host as well.
> 
> However, instead of sprinkling around vendor-specific checks, just do
> unconditional WBINVD to cover both SME and TDX.  Kexec is not a fast path
> so having one additional WBINVD for platforms w/o SME/TDX is acceptable.
> 
> But only do WBINVD for bare-metal because TDX guests and SEV-ES/SEV-SNP
> guests will get unexpected (and yet unnecessary) exception (#VE or #VC)
> which the kernel is unable to handle at this stage.
> 
> Signed-off-by: Kai Huang <kai.huang@intel.com>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Dave Young <dyoung@redhat.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---