Received-SPF: pass (google.com: domain of linux-kernel+bounces-150201-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 18 Apr 2024 09:49:02 -0400
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH v2 2/2] PCI: endpoint: pci-epf-test: Use 'msix_capable'
 flag directly in pci_epf_test_alloc_space()
Message-ID: <ZiEkzrwelbYCFO5P@lizhi-Precision-Tower-5810>
References: <20240418-pci-epf-test-fix-v2-0-eacd54831444@linaro.org>
 <20240418-pci-epf-test-fix-v2-2-eacd54831444@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240418-pci-epf-test-fix-v2-2-eacd54831444@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?XglSshW2H+NP1sWn801vGsdGNeIjW4EhUmVz0waHZmsn227LZYp8jMxW+k/K?=
 =?us-ascii?Q?q8MUVA0AJ+saCxm33UYXFHDIIEiEuhg+AHjVUQjdfVc+al1MFbCXqW8JjIZa?=
 =?us-ascii?Q?owwzit2uZgOtw6CcjA7Wn+36uJ0SlIy2Q5BbfYAPEwMuuJ9xKEyTe/CtooNH?=
 =?us-ascii?Q?nGF4WvurbQchrlku3NdKPvNDQKX0NCyeMbzuAq9b2gfWyWRsVQfNJp9gj8Hf?=
 =?us-ascii?Q?yFgNJH4rPf0ulq0SoPZJ7GxIxk154wP/s8zvD9tnhfoL8siWt0hfik6zKfV8?=
 =?us-ascii?Q?TGjX9f79IzadzvyCGAQHk3Z+A4y8ct4f9FOZJbfadUkuQwaf1AA/p+sdN+XX?=
 =?us-ascii?Q?iTm0i4nisIJ3pxXp+wdBumk3lqyTDNfttryH5sETSlQ/C1blBTt0IsjJbGaw?=
 =?us-ascii?Q?bMy7tbvpzEife1mlxIfhScG2Ln5Rw3YsK9FsF8a5SKlH2jBeZ2+zORP97DZ7?=
 =?us-ascii?Q?ASJijpOB8f0hooI9rejhuPxpAIregn59tsFUXj/YuuZ8NEzFLN7nfExA8aMH?=
 =?us-ascii?Q?Utosv7c3Bl7/Mex+ZURnFMVqWlmMx1Rrvc5ZYrKthKimPg8YFZKIFkMA9N4/?=
 =?us-ascii?Q?vVEoIX8nFUQwJtCazhB6goFa8WxCLEZi3jsZKNvWGtoQDPl4bGH8WW9qe2cH?=
 =?us-ascii?Q?k+XCYfoeJeTTQXBneHvvp5BFQ92f3DxKIPYnBYwE6sj9+wyHCItpEqbGl3DR?=
 =?us-ascii?Q?a3Y3AjR5GJVLe8BiFoApMd9GM2v4jO3zabPFt8msqIWZvjSUI54i4D/SlOb9?=
 =?us-ascii?Q?/qZvOSw8xjN3WOZVCWFGgeAyE4k4RLwGtp6T8c2XEAVgaZl2qD7r11aWBtwj?=
 =?us-ascii?Q?3O9aWrArPbs0uWZNTMw2CE8OcmweO/D+odeqe1zGpMFOGMcZXqeccGHdMbaQ?=
 =?us-ascii?Q?PX5whvcY98IB8yC0NYmgII/nhilJw8BFrLH78B+X527T1t+G2Y0Uu9HFVMlT?=
 =?us-ascii?Q?eHx/6boIoCSKf17rRJZLQ6cqPgfizA3V6ZJepHqBGML90gtu+ptQA5QfD+wk?=
 =?us-ascii?Q?I4nNFoko92e3GGbPCrW3oXjZka6Xs0DPNyciNN6JrYM6XOVZyFtHpUODmqi+?=
 =?us-ascii?Q?i34gwUUFOA8rBOXWgIBkGRAd/b6Cy1k0r/oerY84opXvTmDDLlDwIXmNV7ys?=
 =?us-ascii?Q?redq7iPfyhW6Ygbw8WlnJ0430xlMSaTu8unKeF4fivuHgtASWoH706ga+78k?=
 =?us-ascii?Q?+zif2JCPYbZsSck0xZdMoeLmdlSgyWnI8jx+K2aVaHT4MQf1E9twr+0eAJUR?=
 =?us-ascii?Q?NIMzY9iE2aIBPuK1ox0iqxRAZIenmxwR+9pMifpr4UPsOWHe2AKYztHBHPTM?=
 =?us-ascii?Q?MyUA5oGsNR65jDe3kCyb6APbb2PIFKhrCDNuV/me5vm+CRfM80JXZXwBwmmv?=
 =?us-ascii?Q?gl/BzJOGvKOJOkphYXQNDKjutIrrrouO4XkLp+SFFWJCBY6kfuEUKTeJZN4D?=
 =?us-ascii?Q?mqJN0r0ku6Db7zNjnIviRioYSH+C1OIKGjRQajokEJk64noywIJ3RoFbE6mI?=
 =?us-ascii?Q?1xoSMmkX6IzoOuP/YdOvn/FfNHrNzUxyI9jcsdinpztPciZtX2zxenUsdz6y?=
 =?us-ascii?Q?b2dOuqFvEl6fPHCJALLDigOH5r5/h8s7b2BmsXrK?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a8f0acc-1212-454b-4a4b-08dc5fae5205
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 13:49:08.5727
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2uVBVIX4YqacLLhG+Um2MrPkhYkRwQ1jbtv4fqgK2zyd/OnkQxMnuCg3LYuVdtgD0ztaRH9JlUbwdlw2b+8+MA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9640

On Thu, Apr 18, 2024 at 01:29:59PM +0530, Manivannan Sadhasivam wrote:
> Instead of using a local variable to cache the 'msix_capable' flag, use it
> directly to simplify the code.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> 
> Suggested-by: Niklas Cassel <cassel@kernel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 546d2a27955c..3de18a601e7b 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -802,19 +802,15 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf)
>  	size_t msix_table_size = 0;
>  	size_t test_reg_bar_size;
>  	size_t pba_size = 0;
> -	bool msix_capable;
>  	void *base;
>  	enum pci_barno test_reg_bar = epf_test->test_reg_bar;
>  	enum pci_barno bar;
> -	const struct pci_epc_features *epc_features;
> +	const struct pci_epc_features *epc_features = epf_test->epc_features;
>  	size_t test_reg_size;
>  
> -	epc_features = epf_test->epc_features;
> -
>  	test_reg_bar_size = ALIGN(sizeof(struct pci_epf_test_reg), 128);
>  
> -	msix_capable = epc_features->msix_capable;
> -	if (msix_capable) {
> +	if (epc_features->msix_capable) {
>  		msix_table_size = PCI_MSIX_ENTRY_SIZE * epf->msix_interrupts;
>  		epf_test->msix_table_offset = test_reg_bar_size;
>  		/* Align to QWORD or 8 Bytes */
> 
> -- 
> 2.25.1
>