Received-SPF: pass (google.com: domain of linux-kernel+bounces-150205-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 18 Apr 2024 09:52:29 -0400
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>, 
 Yick Xie <yick.xie@gmail.com>, 
 willemdebruijn.kernel@gmail.com, 
 willemb@google.com
Cc: netdev@vger.kernel.org, 
 davem@davemloft.net, 
 dsahern@kernel.org, 
 edumazet@google.com, 
 kuba@kernel.org, 
 linux-kernel@vger.kernel.org, 
 stable@vger.kernel.org
Message-ID: <6621259d66d0f_ec9b929478@willemb.c.googlers.com.notmuch>
In-Reply-To: <0a17d6745d5c6d4bb635cfac1029e90c1ac2c676.camel@redhat.com>
References: <20240416190330.492972-1-yick.xie@gmail.com>
 <0a17d6745d5c6d4bb635cfac1029e90c1ac2c676.camel@redhat.com>
Subject: Re: [PATCH net v2] udp: don't be set unconnected if only UDP cmsg
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

Paolo Abeni wrote:
> Hi,
> 
> On Wed, 2024-04-17 at 03:03 +0800, Yick Xie wrote:
> > If "udp_cmsg_send()" returned 0 (i.e. only UDP cmsg),
> > "connected" should not be set to 0. Otherwise it stops
> > the connected socket from using the cached route.
> > 
> > Fixes: 2e8de8576343 ("udp: add gso segment cmsg")
> > Signed-off-by: Yick Xie <yick.xie@gmail.com>
> > Cc: stable@vger.kernel.org
> 
> Minor: the patch subj is IMHO a bit confusing, what about removing the
> double negation?
> 
> preserve connect status with UDP-only cmsg
> 
> > ---
> > v2: Add Fixes tag
> > v1: https://lore.kernel.org/netdev/20240414195213.106209-1-yick.xie@gmail.com/
> > ---
> >  net/ipv4/udp.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> > index c02bf011d4a6..420905be5f30 100644
> > --- a/net/ipv4/udp.c
> > +++ b/net/ipv4/udp.c
> 
> What about ipv6? why this fix does not apply there, too?

Oops. Thanks Paolo. Yes, this definitely also applies to ipv6.