Received-SPF: pass (google.com: domain of linux-kernel+bounces-150230-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <ZiCp2ArgSzjGQZql@dread.disaster.area> <ZiDECInm854YiSPo@infradead.org>
In-Reply-To: <ZiDECInm854YiSPo@infradead.org>
From: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Date: Thu, 18 Apr 2024 15:58:52 +0200
Message-ID: <CAPAsAGxPEZYBCb30=an8yyku9zNZT74g3n4W_XFCRwLgg=9Xyw@mail.gmail.com>
Subject: Re: xfs : WARNING: possible circular locking dependency detected
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>, Xiubo Li <xiubli@redhat.com>, linux-xfs@vger.kernel.org, 
	chandan.babu@oracle.com, djwong@kernel.org, linux-kernel@vger.kernel.org, 
	kasan-dev@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18, 2024 at 8:56=E2=80=AFAM Christoph Hellwig <hch@infradead.or=
g> wrote:
>
> Adding the KASAN maintainer so that we actuall have a chane of
> fixing this instead of a rant that just gets lost on the xfs list..
>

Thanks.

> On Thu, Apr 18, 2024 at 03:04:24PM +1000, Dave Chinner wrote:
> > The only krealloc() in this path is:
> >
> >       new =3D krealloc(ifp->if_data, new_size,
> >                         GFP_KERNEL | __GFP_NOLOCKDEP | __GFP_NOFAIL);
> >
> > And it explicitly uses __GFP_NOLOCKDEP to tell lockdep not to warn
> > about this allocation because of this false positive situation.
> >
> > Oh. I've seen this before. This is a KASAN bug, and I'm pretty sure
> > I've posted a patch to fix it a fair while back that nobody seemed
> > to care about enough to review or merge it.
> >

Sorry, must have been my bad. I didn't find the actual patch though,
only proposed way to fix this bug:
https://lkml.kernel.org/r/%3C20230119045253.GI360264@dread.disaster.area%3E
So I'll cook patch and will send it shortly.