Received-SPF: pass (google.com: domain of linux-kernel+bounces-150243-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 18 Apr 2024 17:04:58 +0300
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Zeng Heng <zengheng4@huawei.com>
Cc: linus.walleij@linaro.org, dan.carpenter@linaro.org,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	liwei391@huawei.com
Subject: Re: [PATCH v2 resend] pinctrl: devicetree: fix refcount leak in
 pinctrl_dt_to_map()
Message-ID: <ZiEoiuHbIyyWs5hE@smile.fi.intel.com>
References: <20240418115813.93241-1-zengheng4@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240418115813.93241-1-zengheng4@huawei.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Apr 18, 2024 at 07:58:13PM +0800, Zeng Heng wrote:
> If we fail to allocate propname buffer, we need to drop the reference
> count we just took, otherwise it will lead reference leak. Here the
> error exit path is modified to jump to the err label and call
> pinctrl_dt_free_maps() which would drop the counter.
> 
> In the meantime, if it is found that the property 'pinctrl-0' is not
> present, ENODEV is returned and also jump to the err label and call the
> free function, in case the Smatch tool complains.

..

> ---
> v2: add a comment and modify the commit message, without any logical
>     changes.

You probably didn't get what I was saying...
Linus already applied your version, what is missing is the comment.
This should be done as a followup patch.

-- 
With Best Regards,
Andy Shevchenko