Received-SPF: pass (google.com: domain of linux-kernel+bounces-150266-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240416035240.2450127-1-wangzhu9@huawei.com> <2024041658-imagines-unlatch-a9b6@gregkh>
 <036c3371d3a64ef8881260197ce37dbc@huawei.com> <CADnq5_NML_BiqQx2UmwH86d3qv57D3tFRL--dro1qA99r0Qr5w@mail.gmail.com>
 <b9ab29ad37f94dfa81da3aa88c6456c2@huawei.com>
In-Reply-To: <b9ab29ad37f94dfa81da3aa88c6456c2@huawei.com>
From: Alex Deucher <alexdeucher@gmail.com>
Date: Thu, 18 Apr 2024 10:15:53 -0400
Message-ID: <CADnq5_PF=hynw-Fdt6JGxULXjBSCh1bM8dOgSbpeR4nAjh1pUw@mail.gmail.com>
Subject: Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands
To: wangzhu <wangzhu9@huawei.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, 
	"harry.wentland@amd.com" <harry.wentland@amd.com>, "sunpeng.li@amd.com" <sunpeng.li@amd.com>, 
	"Rodrigo.Siqueira@amd.com" <Rodrigo.Siqueira@amd.com>, 
	"alexander.deucher@amd.com" <alexander.deucher@amd.com>, 
	"christian.koenig@amd.com" <christian.koenig@amd.com>, "airlied@linux.ie" <airlied@linux.ie>, 
	"daniel@ffwll.ch" <daniel@ffwll.ch>, "qingqing.zhuo@amd.com" <qingqing.zhuo@amd.com>, 
	"stylon.wang@amd.com" <stylon.wang@amd.com>, "Josip.Pavic@amd.com" <Josip.Pavic@amd.com>, 
	"trix@redhat.com" <trix@redhat.com>, "cruise.hung@amd.com" <cruise.hung@amd.com>, 
	"Eric.Yang2@amd.com" <Eric.Yang2@amd.com>, 
	"mario.limonciello@amd.com" <mario.limonciello@amd.com>, "alvin.lee2@amd.com" <alvin.lee2@amd.com>, 
	"jun.lei@amd.com" <jun.lei@amd.com>, "austin.zheng@amd.com" <austin.zheng@amd.com>, 
	"sunglee@amd.com" <sunglee@amd.com>, "paul.hsieh@amd.com" <paul.hsieh@amd.com>, 
	"hanghong.ma@amd.com" <hanghong.ma@amd.com>, "JinZe.Xu@amd.com" <JinZe.Xu@amd.com>, 
	"lewis.huang@amd.com" <lewis.huang@amd.com>, "alex.hung@amd.com" <alex.hung@amd.com>, 
	"syed.hassan@amd.com" <syed.hassan@amd.com>, "wayne.lin@amd.com" <wayne.lin@amd.com>, 
	"nicholas.kazlauskas@amd.com" <nicholas.kazlauskas@amd.com>, 
	"chiahsuan.chung@amd.com" <chiahsuan.chung@amd.com>, 
	"aurabindo.pillai@amd.com" <aurabindo.pillai@amd.com>, "aric.cyr@amd.com" <aric.cyr@amd.com>, 
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>, 
	"dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 17, 2024 at 11:14=E2=80=AFPM wangzhu <wangzhu9@huawei.com> wrot=
e:
>
> The CVE-2023-52624 is fixed in linux-6.7 stable, while it is not fixed in=
 6.6, this commit is presented to fix it in linux-6.6 stable.

Why is there a CVE in the first place?  Is this actually an issue you
have seen?  It seems like you just picked a random patch and opened a
CVE.

Alex


>
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Alex Deucher [mailto:alexdeucher@gmail.com]
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B44=E6=9C=8818=E6=97=A5 =
9:58
> =E6=94=B6=E4=BB=B6=E4=BA=BA: wangzhu <wangzhu9@huawei.com>
> =E6=8A=84=E9=80=81: Greg KH <gregkh@linuxfoundation.org>; harry.wentland@=
amd.com; sunpeng.li@amd.com; Rodrigo.Siqueira@amd.com; alexander.deucher@am=
d.com; christian.koenig@amd.com; airlied@linux.ie; daniel@ffwll.ch; qingqin=
g.zhuo@amd.com; stylon.wang@amd.com; Josip.Pavic@amd.com; trix@redhat.com; =
cruise.hung@amd.com; Eric.Yang2@amd.com; mario.limonciello@amd.com; alvin.l=
ee2@amd.com; jun.lei@amd.com; austin.zheng@amd.com; sunglee@amd.com; paul.h=
sieh@amd.com; hanghong.ma@amd.com; JinZe.Xu@amd.com; lewis.huang@amd.com; Z=
hengzengkai <zhengzengkai@huawei.com>; alex.hung@amd.com; syed.hassan@amd.c=
om; wayne.lin@amd.com; nicholas.kazlauskas@amd.com; chiahsuan.chung@amd.com=
; aurabindo.pillai@amd.com; aric.cyr@amd.com; amd-gfx@lists.freedesktop.org=
; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
> =E4=B8=BB=E9=A2=98: Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before e=
xecuting GPINT commands
>
> On Wed, Apr 17, 2024 at 9:51=E2=80=AFPM wangzhu <wangzhu9@huawei.com> wro=
te:
> >
> > Hi Greg, thanks for your reply. Since there is no patch to fix CVE-2023=
-52624 in linux-5.10, there is a patch in the linux-6.7 branch, its commit =
is 2ef98c6d753a744e333b7e34b9cf687040fba57d ("drm/amd/display: Wake DMCUB b=
efore executing GPINT commands"). When we apply this patch to linux-5.10, t=
here are lots of conflicts, and we found there are lots of dependent patche=
s, and lots of patches are not proposed to fix the cve, they are presented =
to add new functions of the kernel.
> >
>
> Why is there a CVE?  Have you uncovered some specific issue?
>
> Alex
>
> > My commit comes from nearly 20 patches. For each patch, not all of its =
content is meant to fix the cve, so I just get the part which is helpful to=
 fix. It is why I don't present the patches one by one instead of merging t=
hem into one big patch.
> >
> >
> > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> > =E5=8F=91=E4=BB=B6=E4=BA=BA: Greg KH [mailto:gregkh@linuxfoundation.org=
]
> > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B44=E6=9C=8816=E6=97=
=A5 12:54
> > =E6=94=B6=E4=BB=B6=E4=BA=BA: wangzhu <wangzhu9@huawei.com>
> > =E6=8A=84=E9=80=81: harry.wentland@amd.com; sunpeng.li@amd.com;
> > Rodrigo.Siqueira@amd.com; alexander.deucher@amd.com;
> > christian.koenig@amd.com; airlied@linux.ie; daniel@ffwll.ch;
> > qingqing.zhuo@amd.com; stylon.wang@amd.com; Josip.Pavic@amd.com;
> > trix@redhat.com; cruise.hung@amd.com; Eric.Yang2@amd.com;
> > mario.limonciello@amd.com; alvin.lee2@amd.com; jun.lei@amd.com;
> > austin.zheng@amd.com; sunglee@amd.com; paul.hsieh@amd.com;
> > hanghong.ma@amd.com; JinZe.Xu@amd.com; lewis.huang@amd.com;
> > Zhengzengkai <zhengzengkai@huawei.com>; alex.hung@amd.com;
> > syed.hassan@amd.com; wayne.lin@amd.com; nicholas.kazlauskas@amd.com;
> > chiahsuan.chung@amd.com; aurabindo.pillai@amd.com; aric.cyr@amd.com;
> > amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
> > linux-kernel@vger.kernel.org
> > =E4=B8=BB=E9=A2=98: Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before=
 executing
> > GPINT commands
> >
> > On Tue, Apr 16, 2024 at 03:52:40AM +0000, Zhu Wang wrote:
> > > From: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> > >
> > > stable inclusion
> > > from stable-v6.7.3
> > > commit 2ef98c6d753a744e333b7e34b9cf687040fba57d
> > > category: bugfix
> > > bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9BV4C
> > > CVE: CVE-2023-52624
> > >
> > > Reference:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/c
> > > om mit/?id=3D2ef98c6d753a744e333b7e34b9cf687040fba57d
> > >
> > > --------------------------------
> > >
> > > [ Upstream commit e5ffd1263dd5b44929c676171802e7b6af483f21 ]
> > >
> > > [Why]
> > > DMCUB can be in idle when we attempt to interface with the HW
> > > through the GPINT mailbox resulting in a system hang.
> > >
> > > [How]
> > > Add dc_wake_and_execute_gpint() to wrap the wake, execute, sleep
> > > sequence.
> > >
> > > If the GPINT executes successfully then DMCUB will be put back into
> > > sleep after the optional response is returned.
> > >
> > > It functions similar to the inbox command interface.
> > >
> > > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: stable@vger.kernel.org
> > > Reviewed-by: Hansen Dsouza <hansen.dsouza@amd.com>
> > > Acked-by: Wayne Lin <wayne.lin@amd.com>
> > > Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> > > Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
> > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > >
> > > This commit comes from following commits:
> > >
> > >  8774029f76b9 ("drm/amd/display: Add DCN35 CLK_MGR")  65138eb72e1f
> > > ("drm/amd/display: Add DCN35 DMUB")  dc01c4b79bfe ("drm/amd/display:
> > > Update driver and IPS interop")
> > >  820c3870c491 ("drm/amd/display: Refactor DMCUB enter/exit idle
> > > interface")  2ef98c6d753a ("drm/amd/display: Wake DMCUB before
> > > executing GPINT commands")
> >
> > Why are you putting multiple commits together and not just submitting t=
he individual ones?  And what is this for?
> >
> > confused,
> >
> > greg k-h