Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp21508lqt; Thu, 18 Apr 2024 07:29:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCULbVdNmLKso0vrnF1qAkq31lW9d96bnOibk75mVsRrpQRg1BRkDcMxJyEjOuQ/CDbt0DmA5EPCuObDWU3MI1w8AOUgstpDTRY7goQtbw== X-Google-Smtp-Source: AGHT+IFOZx2pR5iFqRt14Y9Y8iJJD/TYj9suUVKD840+sX8kKpE5UtZBzi6DXk44cVtSmWwN5KeH X-Received: by 2002:a9d:4d01:0:b0:6eb:7d45:90c0 with SMTP id n1-20020a9d4d01000000b006eb7d4590c0mr3191178otf.17.1713450540070; Thu, 18 Apr 2024 07:29:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713450540; cv=pass; d=google.com; s=arc-20160816; b=TpVZ+afb7mn0WY5D5Akbwv8n9A5OAXisFpI1FIUnTsHiV1kBLdf5498WiYndLwDmJ0 akW1D14shwcH3dCmKuN8mOaj0lOXEjHhVoj2EL7ishwY9yaCQCYbp+VPc+tU5cMo3UCf QIpwtC3jnepCk18Yk7UTZtSNuAJ9yyUy8e5RxFjNFGdhqogUWHk1SHlZ8ri2rQK/YXqM eXxPFk12NgJH1uNXeRRuKBpJvHMnvzXJRWLwdzRlXe1isYZO3TwknNGBUteqcJsRnoYI RYaRjMzePHIKUAL+hyLHIry0oRZ/AwwZf+DIWcxxkYD+ThJfiPtgYUv0IL29DP/Ao8/z S//A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=oPOMqKMsMCFyz9ese51+tkQEMRF65hYJwdWud3kbtHQ=; fh=fvEStzJf1ZFUheM1hDFBXTcnpKry12h1MjfWk8gxr88=; b=Hu33GSme3JbFxR6gbLSYgdpfGizOl+dFuv8ksP5qi8ZY/XqSeCBG3WvfTFCa5nHHug jwTikaKNs0ZJvEnP2qY1X9uQOftixiQUnQdIyq8/mRCHyMw1v6g6N/VZ+bo6FMrInAzk 94MgRy5HxNqwaEK4OSSxsxqOgjrxA6W6Upl5Xr2ImCwI0eDjq3Isi6QMjxa/okHOnw0c cfsocox5/59ERWIh5IrcltWqaLJfFowqmdiVwTK41JwnftMXQ9KCQQrfLofc1vG4OEfa j5Kw16fuo3/AY0IX9qBpDk3mTL7msdMTQAlyqldFcZ58N9zMG/Ax/+txI3wawhx0i63K Z6Ng==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KMyNeIXj; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-150297-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150297-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l73-20020a633e4c000000b005f77b2c2f5esi1494881pga.293.2024.04.18.07.28.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 07:29:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-150297-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KMyNeIXj; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-150297-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150297-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6BABD28381C for ; Thu, 18 Apr 2024 14:26:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8FDE5168AFD; Thu, 18 Apr 2024 14:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KMyNeIXj" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2F81163A9B; Thu, 18 Apr 2024 14:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713450253; cv=none; b=W+zdqZj69mBpgrYYaH/4+KnrY2XMWQYnKTu0JT2ShuD56oXAYaxk1oPWuJPpFLUnRise9ubhVkllVCEn1ZiE2NE94X5+RvBEFKIe8XuLut00FGMzgRIAC2YFl+sxl5YQcw4Wx5ZRjg5YKj4mxsuRF5rwEMm82HnqkTap6hT2mvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713450253; c=relaxed/simple; bh=Q8liASnYD+YPWYkT0PWK1605RH/y4SMfVkrndA1iMPM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EZUeSNTXfdHj0/k+CbOQwZSc33cHXd2G5eDKoYUjStL1Tgak6IlifobNFvp+RFF1p9KCfaULL9G4iUuwZ/8A4bm4+jA6U1w937Spk/roKryMN3y7VrHFVusrobUYSdAEz4aNanXtlr6g9eVv3Xf4N6QFahC/w5vAJh4Ho52xk6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KMyNeIXj; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713450252; x=1744986252; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Q8liASnYD+YPWYkT0PWK1605RH/y4SMfVkrndA1iMPM=; b=KMyNeIXjxWrKa6XibqAbApOoOGsmGulQuAv4kbv2lSKBaY8xIlxPSM7j t0v7T8T/CWLhvxAwjqo8OmOWuuntWvex5pLCmM21WghkvKKX6DD5UygbG Qcozn6wbxZojylrBTOmBUAeryAtG40//Ih2xDwGWK7PeBCwxDP14OSul9 toUIPZ4VAqoC8MferN1uQSsALhCBoZeYgRKNoaqI8tnYoL3l1LrfkcL7p GtC71kl/H4morfzDCHOdcluNDtH3wAC6aC+d2dJWsrAB78S7ChzHI9+bw 01PpotDbgNHpptohuzzeQQblF1eLdVQ9THD2PUktvSmKpLRPVQPm2CZKd Q==; X-CSE-ConnectionGUID: lprb6clLS0m3lVvrxsZmuQ== X-CSE-MsgGUID: 3LxDbI8jTRyfGELmdR5c6A== X-IronPort-AV: E=McAfee;i="6600,9927,11047"; a="9158678" X-IronPort-AV: E=Sophos;i="6.07,212,1708416000"; d="scan'208";a="9158678" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2024 07:24:11 -0700 X-CSE-ConnectionGUID: V+rEpSbuT/Wkm0gBWdkukg== X-CSE-MsgGUID: TFK76s84Q5aop9x8DZ8azQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,212,1708416000"; d="scan'208";a="23079726" Received: from stechane-mobl2.amr.corp.intel.com (HELO [10.209.94.1]) ([10.209.94.1]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2024 07:24:11 -0700 Message-ID: <1d28f1dc-0aea-4b91-9df7-1a6d3a291e2e@intel.com> Date: Thu, 18 Apr 2024 07:24:10 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/cpufeatures: Fix dependencies for GFNI, VAES, and VPCLMULQDQ To: Eric Biggers , x86@kernel.org Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240417060434.47101-1-ebiggers@kernel.org> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240417060434.47101-1-ebiggers@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/16/24 23:04, Eric Biggers wrote: > Fix cpuid_deps[] to list the correct dependencies for GFNI, VAES, and > VPCLMULQDQ. These features don't depend on AVX512, and there exist CPUs > that support these features but not AVX512. GFNI actually doesn't even > depend on AVX. > > This prevents GFNI from being unnecessarily disabled if AVX is disabled > to mitigate the GDS vulnerability. Looks like the original commit was quite confused. Thanks for finding this. Acked-by: Dave Hansen