Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp32799lqt; Thu, 18 Apr 2024 07:46:38 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV8LmoYIAvexMP48nAF9i/imApdRNBsbMgpOUN3jzQ7CuoMBn1VnyCfrZuZ8eYZuVeABBcnjLIqxjUsJxXe2Pg6C1VXqisHaVyPxaRqPQ== X-Google-Smtp-Source: AGHT+IEbpLuit90g2nnlgGPKcBeq/bzClauKwpLcRC9BggRXTyl3KyefHJaFsqrF1+8C2OIldBsc X-Received: by 2002:a05:6214:8c4:b0:6a0:5279:55a3 with SMTP id da4-20020a05621408c400b006a0527955a3mr2824325qvb.32.1713451598376; Thu, 18 Apr 2024 07:46:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713451598; cv=pass; d=google.com; s=arc-20160816; b=Sc/R5UfAVTBUdjyTjpy2sI1SvYDkequuMjq6YUNqMr4PhY56HyEdwN35JidedNVUjO VDtFQ3e9G0jnaEQc1gOOpVMyNqtGK9diAB8TFU7vclNJ22YelRm6+Xg2IsF1XFlo4lQZ r++UFvjOuD8nTJya623RSjnubNN8LzPe/1EsEv7uURX+A0V3pukFUG8Nlsy0ZeFQg94z 09NCKzygLiQsngAbwb8XFVIuEPYDoF9UueQaNymtWa7HSZsa7GxVeAktHyLDAsqswSHu 6jIB/mUtKT5K9TBONC0iLLcyCqev2LhjmkSo9g36ddkMG8r1scRIbNRgEl/N/EhDRX50 zKdA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NN+K5KOtN9QCxC/bLqZ3ZX9SCeTen1cPHw50CtKFEYE=; fh=O6ZPf1UKCZmjHn59DJb//bz38zzyNit91aPML3SkAkU=; b=UJP6X+DJHvQaSNwNjHKbhkBBCVyzdEPS6tFpa2KbpWsFn93WyBt8LGLAxhGzu55zx5 bE/6fAqRMp0m97B/e6UFVHyWRdCUU42IwjQlrneRgkx88117CIdOf6jPOjzX07bAurFX pebmj7+rIheTiVxA/6yZsGOjNJcfCQPhZ/X8lk8Nr6licrJu5sGkrSCSQQkMjbYyjAs4 G8ZSzB4MAyHNwryIoJJvDuOgSrZ8/aD4Nf4GZM3Niri5jZ+cJIJYttfiEXfIX87nHyrv YcQmfENVelqenFD8e0wZjKJ5GgYZICV2rKiyAyU/fOukBXRqAjGqNFIVJExtumIf06IM 1Ocw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=FurfMoDy; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-150332-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150332-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id k14-20020ad45bee000000b006a0416d7d60si1590464qvc.558.2024.04.18.07.46.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 07:46:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-150332-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=FurfMoDy; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-150332-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150332-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1F66F1C21265 for ; Thu, 18 Apr 2024 14:46:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B82A5168AEE; Thu, 18 Apr 2024 14:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FurfMoDy" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56E4D168AE4; Thu, 18 Apr 2024 14:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713451569; cv=none; b=GKmdSIodZX8w5bYWDlQFmEh0eZvuGErcegp7lAJGdPRqFdiJlBa/HAaao/9FLi9SQFX7jmDZjRcPHuSIj2QpUUkeQnPO7brbDpfLGEW9SjHoaaaG6f3vtjnMRGWxZyYsdG7jG7Pbe5yt85Q+KUEjpqZV1lc/JTZGulWCU3fVdds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713451569; c=relaxed/simple; bh=NN+K5KOtN9QCxC/bLqZ3ZX9SCeTen1cPHw50CtKFEYE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lFpsvX5Vc9iWEY0agkXWhFKdaf7Vhk1Tk/FYou8c2bprJfgvpv3ccPd+Ygl3uQp2s8yg1gY56qJSeqVU9qAxFoCmOHfuUzdY4n7Oitj1e6HlyTaIsBjufrQbwE520DQ3kObIkpQ45FH44b+emau6+DgnwEFj6w2h6HpsaI/mhX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=FurfMoDy; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NN+K5KOtN9QCxC/bLqZ3ZX9SCeTen1cPHw50CtKFEYE=; b=FurfMoDy96LmZ+8CO7jEv9RwVL ku028zReZ5X7hG+mJ25z7Jxd8ZINweODNDcHXK4GocKKiqLfOdOT8eIneYfEiN2WIRNt4jnVZYrc0 EdWfWxGADTeJmnSz79fJAUFjWH40HlP5WHUvQrQlZWBaofuh3fRXQifnOF9LXrggFjOBjzZmDcmu8 EjWV5xsZc7qNQynXOwtkNh5RpbVfUN2hDVXglSSjMrAjQIkpwQ40YNxA47HExmLPxAyDEzcZb7hYg 4cTysIo/bLGnSe8NLwmjga8PEmOLU6t4arTk++DF73BZ6nGdbjMtuwPrirMHNqCIl/S2VYkrXvQjT sZLbz3pg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxT1a-00000002gMD-1PZA; Thu, 18 Apr 2024 14:46:06 +0000 Date: Thu, 18 Apr 2024 07:46:06 -0700 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Mikulas Patocka , Peter Zijlstra , Mike Snitzer , Damien Le Moal , Ingo Molnar , Will Deacon , Waiman Long , Guangwu Zhang , dm-devel@lists.linux.dev, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] completion: move blk_wait_io to kernel/sched/completion.c Message-ID: References: <31b118f3-bc8d-b18b-c4b9-e57d74a73f@redhat.com> <20240417175538.GP40213@noisy.programming.kicks-ass.net> <546473fd-ca4b-3c64-349d-cc739088b748@redhat.com> <5f3d434b-e05c-445f-bee5-2bb1f11a5946@kernel.dk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f3d434b-e05c-445f-bee5-2bb1f11a5946@kernel.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Apr 18, 2024 at 08:30:14AM -0600, Jens Axboe wrote: > It certainly is a hack/work-around, but unless there are a lot more that > should be using something like this, I don't think adding extra core > complexity in terms of a special task state (or per-task flag, at least > that would be easier) is really warranted. Basically any kernel thread doing on-demand work has the same problem. It just has an easier workaround hack, as the kernel threads can simply claim to do an interruptible sleep to not trigger the softlockup warnings.