Received-SPF: pass (google.com: domain of linux-kernel+bounces-150338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Lance Yang <ioworker0@gmail.com>
To: david@redhat.com
Cc: akpm@linux-foundation.org,
	cgroups@vger.kernel.org,
	chris@zankel.net,
	corbet@lwn.net,
	dalias@libc.org,
	fengwei.yin@intel.com,
	glaubitz@physik.fu-berlin.de,
	hughd@google.com,
	jcmvbkbc@gmail.com,
	linmiaohe@huawei.com,
	linux-doc@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org,
	linux-sh@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	muchun.song@linux.dev,
	naoya.horiguchi@nec.com,
	peterx@redhat.com,
	richardycc@google.com,
	ryan.roberts@arm.com,
	shy828301@gmail.com,
	willy@infradead.org,
	ysato@users.sourceforge.jp,
	ziy@nvidia.com
Subject: Re: [PATCH v1 04/18] mm: track mapcount of large folios in single value
Date: Thu, 18 Apr 2024 22:50:03 +0800
Message-Id: <20240418145003.8780-1-ioworker0@gmail.com>
In-Reply-To: <20240409192301.907377-5-david@redhat.com>
References: <20240409192301.907377-5-david@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hey David,

FWIW, just a nit below.

diff --git a/mm/rmap.c b/mm/rmap.c
index 2608c40dffad..08bb6834cf72 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -1143,7 +1143,6 @@ static __always_inline unsigned int __folio_add_rmap(struct folio *folio,
 		int *nr_pmdmapped)
 {
 	atomic_t *mapped = &folio->_nr_pages_mapped;
-	const int orig_nr_pages = nr_pages;
 	int first, nr = 0;
 
 	__folio_rmap_sanity_checks(folio, page, nr_pages, level);
@@ -1155,6 +1154,7 @@ static __always_inline unsigned int __folio_add_rmap(struct folio *folio,
 			break;
 		}
 
+		atomic_add(nr_pages, &folio->_large_mapcount);
 		do {
 			first = atomic_inc_and_test(&page->_mapcount);
 			if (first) {
@@ -1163,7 +1163,6 @@ static __always_inline unsigned int __folio_add_rmap(struct folio *folio,
 					nr++;
 			}
 		} while (page++, --nr_pages > 0);
-		atomic_add(orig_nr_pages, &folio->_large_mapcount);
 		break;
 	case RMAP_LEVEL_PMD:
 		first = atomic_inc_and_test(&folio->_entire_mapcount);

Thanks,
Lance