Received-SPF: pass (google.com: domain of linux-kernel+bounces-150349-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 18 Apr 2024 07:57:38 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: "Li, Ming" <ming4.li@intel.com>, Terry Bowman <Terry.Bowman@amd.com>,
	<dan.j.williams@intel.com>, <rrichter@amd.com>
CC: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/6] PCI/AER: Enable RCEC to report internal error
 for CXL root port
Message-ID: <662134e290d89_5eec229450@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240313083602.239201-1-ming4.li@intel.com>
 <20240313083602.239201-4-ming4.li@intel.com>
 <7172ec2f-7cba-460b-a6c6-9fff45ba938b@amd.com>
 <b4a721c2-567d-4ab3-8a85-963e3f323e61@intel.com>
 <91ddd182-cc71-480f-a1b2-e7c31b29a549@amd.com>
 <f0b85a37-ead0-4954-b7e0-dd09cbd9ab09@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f0b85a37-ead0-4954-b7e0-dd09cbd9ab09@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lrzSAvNjFKXVeab+Q2CNrsHswihODtb68LGzDx+zx9Owf+qKd9TO1GNleZDx?=
 =?us-ascii?Q?cMrZBNlIrPxlyUEwwcVqZX9KDz1BDxHEiG047MDhQlOvK7DaBKhn9TGiDHIt?=
 =?us-ascii?Q?tu/1jwgzxQ5n/IokkHLmHxqBeZaZAa49kvEyi0HU6Le0+jRZrT+0Uxja1m5s?=
 =?us-ascii?Q?VKZ3n/gvGfZumKXrINy/+1TXczynCWKpIoMPzdGrwfpYgu9Y+o7J3vKBhm3i?=
 =?us-ascii?Q?1OAtK59PF7hDHXHK+mUaAMz2+S5bSEl1hsOLAzvGrstvY3UUxj1NLBlwLClB?=
 =?us-ascii?Q?kj5G5nqpcZUvUsaEmaJNjHh+JwZRnO1NibdJspHjtb5lUvp7l+yq6y/zZvfj?=
 =?us-ascii?Q?wwEkt0rLr2UwBgQWKeOuVRd7RQYd5YBSxPMuPrtraIvLLwAJw7WKKG/YICz3?=
 =?us-ascii?Q?b0v8fNpHhR7vtLZ2YsUcGpGG/WZOK2Rf/F+jwF624VQwqykh3LnJMAssTWLJ?=
 =?us-ascii?Q?7g1kVA4iAjqiadyW/QoYciAiPdr/PbiRpweRfJKmwyiR6SCgAennWZV+bOBs?=
 =?us-ascii?Q?TIsjP4Ds3H0rJ3EjLkTKzHw6Yc1MeqFOUr6DHnfVHsS7qGkgj6NxolY5vsBS?=
 =?us-ascii?Q?nxRFI6w5/JoXrCiXSjzy67KzdF50FTM3xZKGKZW0oOC7IlwWr8oxOO8vwZrP?=
 =?us-ascii?Q?5sMSgpoYYnUbaTzD81ebwrG7GdmJnVXoF6msKosjzObfyX+czyerl880/2am?=
 =?us-ascii?Q?KBhxYGGnd5uUZkEsoG8LGSWS/8tNvJAq7FoBZREhXumzT3Rh+Blcm+SMDj1J?=
 =?us-ascii?Q?5lz8HcXr8QNQrGe/O/wI31LS1bzHRKd7952Xfzowr97u1pGLTglrbdvG3Kvm?=
 =?us-ascii?Q?YEiremX4j2xcIMyQq7SeuzzCv+dcP03a3eGPnwGZa0nBp2xELUEa/ySy5ul3?=
 =?us-ascii?Q?ZoivOnHwftnvQGIcyjtf9gGucLD+AVfwc8h8Ga9+L/EP1nIO0vTPzCXl52Gr?=
 =?us-ascii?Q?u1H8qqyouBSI8EZaS7OqpHOvkuWptU98Ny++pSDoTWaI9BLMislfWtjpnDSM?=
 =?us-ascii?Q?dWSS4Vrasl1bN2agJzsRh7EBv4NfHFzxnVY0jmmIqHE3NbLYOEJxWgL+ZlVe?=
 =?us-ascii?Q?JcBS0TnfQPBd2uwIPsNjM9a/1BAdtYHEzrH7k+aqI7zaBnB2L+GNHeKoUDce?=
 =?us-ascii?Q?SbneOsnm6PWzHJZuI0eqiCO343zLFvaEMVJWL24ft5mX+PjUKRDKIMJwnXNP?=
 =?us-ascii?Q?u2WbsecfHmJeCwA0dGgq21sBpcSlByAXfwy2tNWAJN5nm0gJJQp7F0oHYl8Y?=
 =?us-ascii?Q?EYFv47zQmQ6NNCGHBP50cFfVRpYbbc+Fij+rT22TlwVYvYraKTP8pzhGtN6N?=
 =?us-ascii?Q?Hss1c4o9GFMm2dDiAwUZrO7zRzyRWrd7apeBlMyz1irrGInAcxcGj0TS5djt?=
 =?us-ascii?Q?O45HXgVQYjXfl4JuKl9jENUKyAUGKe1XJNAXeIiNrHNs3VcwTSESK0AFkt/1?=
 =?us-ascii?Q?FkAsklwcjedwog5qeNZcr1RpnJr0t3f4R8o21+HK1VQAzE6LHgLA/DdKAQQJ?=
 =?us-ascii?Q?n+SnDWKK8zZdPurpEJRt3ue+h3rGyW7jVkliQD3RvsSkk3Ptc6dJbrHU3h6C?=
 =?us-ascii?Q?L630g6/0JWY9MhEGuYpyiBLIeztAlBE/pw3iyYq17M9JaEx5vBSqSbdx/e7E?=
 =?us-ascii?Q?aA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c605e8d0-09b4-4e5e-cc40-08dc5fb7e4cc
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 14:57:40.3927
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qHSZLZjVaOojWUtRbA+Low+c7PA7dzgFYQDAB1/QJhgj6Gy1gg394Ton5xY9TgGlIHbMwG53XpFX/08XdC48cyYjTwIxEvgNgLqj8is3awM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6320
X-OriginatorOrg: intel.com

Li, Ming wrote:
> On 4/16/2024 10:46 PM, Terry Bowman wrote:
> > The driver support is much simpler if RCEC does not handle VH protocol errors. Is there 
> > a reason to forward root port VH mode protocol errors to an RCEC rather than consume 
> > in the root port's AER driver and forward to CXL error handler? 
> > 
> I agree that is simpler if only root port handle VH protocol errors,
> but I think that software has no chance to choose if VH protocol
> errors reported to RCEC or root port, it depends on platform
> implementation. So I think we should support both cases.

The question is whether the CXL spec RDPAS behavior causes any problems
for platforms that follow PCIe rather than CXL reporting flows for
root-port errors. I.e. does it cause problems if Linux starts scanning
root ports on RCEC notifications?

I do think the lookup needs to change to be based on CXL host-bridge
detection and not CXL-type-3 endpoint detection, but otherwise it looks
like CXL spec wants to invalidate PCIe spec expectations.