Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp41811lqt; Thu, 18 Apr 2024 08:01:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXD3oCRe5m91JyR0bzaEtajukibpxuLVLEdqxAGATtIk92UVDpPd2jko+QwGbr9JQh+2CgyFxm82fjfkGbaNKl6amggE6To2T4Z0lxK9w== X-Google-Smtp-Source: AGHT+IHBFCMZ3omaRPbMNUXqbeFv8J3xT1mRkV7FeAH68CSVg5cl1WKb51Zoyqu7qPyHmnpVSO2t X-Received: by 2002:a17:902:9f87:b0:1e8:32ed:6f6d with SMTP id g7-20020a1709029f8700b001e832ed6f6dmr2975326plq.39.1713452467654; Thu, 18 Apr 2024 08:01:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713452467; cv=pass; d=google.com; s=arc-20160816; b=AHxwStbZx0HIr2R2a6CyO1IKyP7p7fBAXV2xLCt+aiDSi6nCj/y1MkdtmpJ9oNsFrB qGP9JkEP3Wh0xX3CsR3KVc6ztCqNGUWGr9RWBAHevMZOxnX/k22KH4oiMEPtuu3iYAFG TYnPA5hw+eH29rK2oklFTtVHdEiDMpvMxLYQcba+xbsQSZThqIza9uNEglpHLLLWGmXW JapA8cApf8VLNMEBA6RwabJ3mk93kRcoAXEKrSRA7WrimS27GJtm9wGqn1Nv0pMBUzNB 9jQqiFzP10wEBo/uz5P3SIkAaenIiDCx9rJ4oVov/iV7HOVjpKUCtE57Tk3Seot4pOFR ypnQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=2ZW/FZ3LOYDS3w3KGCimfYqRztdugr0FidbJ2WNUZAw=; fh=mHx57FZtZeh3meJ197TKLY87gwPluwlVtYR/TDJloVI=; b=EGhyol4P07gkAsTCOiWKO7mmYaXrcd6tQpUGGLfbcAa3jJUIbrzp8cNZNcZqYz+wMB wRgTimZIJiBf3uY5G5MFqcERtZlSoYFrh4qzCnAmUYoI0Ux7vnmh0RDtwxuTSsmGSN6r Y2cqg+/CEy+QC254+43Nb7cRmQdiSvmz256ytN8ypLV/c3n5uE/k64tVKwD84SMygCAA fzdO3V+aAmWDdcAHGN36gFlShfoHW8XVFNfAqiZ/7EDNOA/60TMAfIqwGMAGmjkP7LRN xzGXfo++DJzfhSHDL7KsYU9itmg8AFtMxMjLnjT/eRhjnK5pxp8BgCIelYfbhozOixG8 b3VA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=p5Dfm7D6; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-150357-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150357-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b5-20020a170903228500b001dc879b3b04si1653191plh.237.2024.04.18.08.01.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 08:01:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-150357-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=p5Dfm7D6; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-150357-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150357-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 20B8F2838CD for ; Thu, 18 Apr 2024 15:01:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C1F2716ABF8; Thu, 18 Apr 2024 15:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="p5Dfm7D6" Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37DB9433BF; Thu, 18 Apr 2024 15:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713452456; cv=none; b=MX6gMeEMz+BeJRMSmi5h190ByPdWspZrJevSFU0wrrMAza66zHkVJKajfsLyW98oA9Ffr/oRiiP71ajracgvLlMNZiR2i9SEo210TakvbT9odvMmZzdOMkk2x+U2M+v55AAmp8VicLrDje73YHkRA9EFfCEBVp6gGyn5NaB3PxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713452456; c=relaxed/simple; bh=2ZW/FZ3LOYDS3w3KGCimfYqRztdugr0FidbJ2WNUZAw=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=THHy28WDfKtFpcfNOPQTMtwbjXYo9E2uhTYcwKCZia50GKCrO6TVONlqlCb2sps2jA+U7iOfjj/EmZypMw0i6Tmnxu3PDFyFRwZCFyk+bGhRxvxza3wLqpfYMI6e2Clojgj0sU5ndn4Tra+TY/SsNettwflQ1Vhad2vWfeooYag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=p5Dfm7D6; arc=none smtp.client-ip=212.227.15.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1713452436; x=1714057236; i=markus.elfring@web.de; bh=2ZW/FZ3LOYDS3w3KGCimfYqRztdugr0FidbJ2WNUZAw=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=p5Dfm7D6SZwfH5wf9JB2c4KNQARwrMwTYL+iXeqAmXkLz3zphYOA7g74phSTnBV+ 1Wyy9Vrq8YYLEwUjicFT49xcu/XwfiP4gmZoJaaKuXmYBTqLIfdOGv9PAhQRoZyTk tf3uB9RgnIxutRVQ+yq3Torq1iux3EDbipsw/qh6FbbLxweOLKV5iqdg8AV3YjSto IWBcwlNdBJ5z4MYJUxdIf0UgW8HAB8doT/rorNDSxigPqo8Y9dp231w8vwkvGoFoe m820XYjl+IZvjj3N/z/c5yT+qTmtv9QRQ2kBn4isjizDrol5L6f4+2FROM7Ld2l8g QxvL4Kpv4iOV/cf+2g== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MPrPT-1sJnUN2vAJ-00OV5y; Thu, 18 Apr 2024 17:00:36 +0200 Message-ID: Date: Thu, 18 Apr 2024 17:00:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Wander Lairson Costa , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org, Brendan Higgins , David Gow , Rae Moar Cc: LKML References: <20240418131754.58217-2-wander@redhat.com> Subject: Re: [PATCH 1/2] kunit: unregister the device on error Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240418131754.58217-2-wander@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:LoYR5OOkNO1IMk0/llpub1AYS06M9QEB/iRygIyFAo8pg5Sd5HB cR3k/yJzI4bdUwtbFDI0041CcL+esda5DOoi53UItLnGW3Au1QPRL5R4EGUFU3Kx0bkLDk8 F4LX6kGJI24gAnvfeDbP4/yURGmTWuTq8aYcFmHTuOc44iIii03lYr7bpKezHsgA6YPpMif P2+EPliUoupjZbJDcagzA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:FUEOxYAIpJ8=;aRIxn8r1lavSmvU+iyLodHt+x1Y me99TOMMRVlJsgPI2fqMpf5R2ss6vpa/+Zg88ZQxIrtU5ah2S9wTrDh0uvmPmpBLOTBrT66ZT lg1rDe6MdbyT5/dIBuwyaQUwycUm7HyIJ3MjmBMhL8kUK2GWwNYP89YaGsgT6Eoio7ZEVlXvN Nc6S9aSTOPXYjvMV3+H0OGHIFQIRfVfPN2TM6257Na6O60J4P4bxaCqvocETdrBzzBs/0fU4V HK1JK/kmDXkFh1q3GMcVCtDED0YDjxZA7z4FR0pg/0SJV1zNouRW/5EIy/KoZvkvwqb48H0Ud 9SXU1U1dEq1bhT3TbO9a8HIloESg/0AOYKO0nN1OAYiI6YVrq/5Yvw4TY+z9MPiLyYVpL71FH Ai7PgpLcusdbvgrLDmX344E/H4u+KbldP9ZHmNCMalw8xUIm3U8tssJIJRikwPERJmX52cOIL ccNHz2oRNAzFzly8TqU3rtOV6ftDqSVMogsnkRlTizEl6RCRSD7MyLFgjALwN7UqggmGHWv0Q 6U25RUUp0Twsaci3Oi3me3Wt3jI5z/Vaqc4NE898yinRkiisp3X/kH8x70vSuq+fGVZFC/VMR oQnApURhLsw2kwp1k3zYTostkcwZa4qe7Gi6f8fhAFmL8pzp9Kulji2uBDvlESPvhb0+77h1z Ktn1WwzO612MKS7RC0rv4pqImahhRNc+oo8UH0r7FmUfjor320br87rhgYSk73Pq7o2efKpUe wSsOFfz8OrQrkPcChhhqapxy452PauwhfRTAyd/7Wh8Iy2OgiOfMsWqQ+PUp9ePCflqjRbgTD 7IwBeFQro85/HnbmFXZG0zVNwQqFwiycpZGWaL0YLfDu8= > kunit_init_device() should unregister the device on bus register error. * Would another imperative wording be desirable also for this change descr= iption? * Will the tag =E2=80=9CFixes=E2=80=9D become relevant here? Regards, Markus