Received-SPF: pass (google.com: domain of linux-kernel+bounces-150432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Sender: Tejun Heo <htejun@gmail.com>
Date: Thu, 18 Apr 2024 05:56:15 -1000
From: Tejun Heo <tj@kernel.org>
To: Sven Schnelle <svens@linux.ibm.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: fix selection of wake_cpu in kick_pool()
Message-ID: <ZiFCn2RLWhk7i4oB@slm.duckdns.org>
References: <20240415053550.538722-1-svens@linux.ibm.com>
 <Zh8EfxdVdiIj_27H@slm.duckdns.org>
 <yt9dpluogfw9.fsf@linux.ibm.com>
 <ZiB9rYBu-0qjsCbF@slm.duckdns.org>
 <yt9djzkvfc6a.fsf@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <yt9djzkvfc6a.fsf@linux.ibm.com>

On Thu, Apr 18, 2024 at 07:54:37AM +0200, Sven Schnelle wrote:
> Tejun Heo <tj@kernel.org> writes:
> 
> > Hello,
> >
> > On Wed, Apr 17, 2024 at 05:36:38PM +0200, Sven Schnelle wrote:
> >> > This generally seems like a good idea but isn't this still racy? The CPU may
> >> > go down between setting p->wake_cpu and wake_up_process().
> >> 
> >> Don't know without reading the source, but how does this code normally
> >> protect against that?
> >
> > Probably by wrapping determining the wake_cpu and the wake_up inside
> > cpu_read_lock() section.
> 
> Thanks. Should i send a v2 and incorporate your additional changes or do
> you want to do that?

Yes, please send a v2.

Thanks.

-- 
tejun