Received-SPF: pass (google.com: domain of linux-kernel+bounces-150439-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 18 Apr 2024 17:58:54 +0200
From: Dragan Simic <dsimic@manjaro.org>
To: Conor Dooley <conor@kernel.org>
Cc: Chukun Pan <amadeus@jmu.edu.cn>, Heiko Stuebner <heiko@sntech.de>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, FUKAUMI Naoki
 <naoki@radxa.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name
 for Radxa ROCK 3A
In-Reply-To: <20240418-skinless-aptitude-245665a7c757@spud>
References: <20240418130120.67663-1-amadeus@jmu.edu.cn>
 <d00953aab0f1c978e3720885a6844caa@manjaro.org>
 <20240418-drove-boasting-d189ee3e22e0@spud>
 <7fec3e2f4e16b1aca6cd08e1882bd885@manjaro.org>
 <20240418-skinless-aptitude-245665a7c757@spud>
Message-ID: <865d70eea51c18570d94a4fc86dcb5b5@manjaro.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit

On 2024-04-18 17:57, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 05:46:30PM +0200, Dragan Simic wrote:
>> On 2024-04-18 17:37, Conor Dooley wrote:
>> > On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
>> > > On 2024-04-18 15:01, Chukun Pan wrote:
>> > > > According to https://radxa.com/products/rock3/3a,
>> > > > the name of this board should be "Radxa ROCK 3A".
>> > > > Also update compatible to match the model name.
>> > > >
>> > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> > > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>> > >
>> > > Looking good to me.  I'll send the remaining naming cleanup patches
>> > > a bit later.
>> >
>> > What remaining patches?
>> 
>> The same naming cleanups need to be performed for the Radxa
>> ROCK 5 boards. [1]  I had some more cleanups for the ROCK 4
>> boards in mind, but I'll drop them after your NAK. [2]
>> 
>> Though, I'm not really sure why the NAK?  Those names aren't
>> used anywhere, neither in the Linux kernel, nor in U-Boot.
> 
> There may well be other users outside of those two projects that are
> actually looking at it - I don't think that adding a hyphen is worth
> disrupting anyone for, it seems perfectly clear without it what board
> this is.

I see, it's perhaps better to stay on the safe side.