Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp116401lqt; Thu, 18 Apr 2024 09:53:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWISFl9RENxTp9UzE3e8uEaA2ODxuVvzhij77I1XpkhY8mMjOkMLieT9BAxcpodYSITL16Fca4yS2FmcwK/UD5ijnfhm+7XdJPdnKiYyw== X-Google-Smtp-Source: AGHT+IHe+ITdVIRJepN4m9L/Z+QqWyjuI3YO/jR7ry6O8odTUHghHVCnYBWye4rMmM0YzyPOrJZw X-Received: by 2002:a05:6a00:17aa:b0:6e6:b4f3:19dc with SMTP id s42-20020a056a0017aa00b006e6b4f319dcmr4528323pfg.7.1713459184149; Thu, 18 Apr 2024 09:53:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713459184; cv=pass; d=google.com; s=arc-20160816; b=SMhWevNKHWQGFTLOUocNbjtFMvadZUrQ0deEnhPLq+n1LSefe0BSlEtz40u7pqmzK4 qefMYF9F6tgFnxjER0a/3MCMtIAHmNn/rowWdY0P/yLf2dit3eSx7ixh1Eb+x5TJdzVg HuZpUJm58JiDy/j/cmcC3zEdx5k07Sv1Nh8+XVZYD5NM87BhpdAL2gGWXm7mQC1IVdcl ftd/thwJ42J3Z5CqzOaewwD15aV+9ZeA6Q+LYQfkOdoHfMKxFcucd+sHf8zXEZV6G4Ko Oxy8J2I2GQ+jBA6NeRZO4CIWKYI/cKAUfV03lKyCsBIUsLruxLHGPVQJFEMlmHv2JCUJ H1hQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :dkim-filter; bh=/x44WfF5SQjqBQwqGks3DVpPDx/QzjlIKoFfU1B3cvY=; fh=ujksmUrBEjpGhQjWbrjZMx9PDXUXbYR/j4y8MAq1x1o=; b=e077HgcDvqBsOSc/h/Gcuue6GOWOyWop3INFwOeE7vzMVdfa+Lp76MBWEr5z7b3efe UEp9ksZTIZSH8qcTbuqcy5H6wB2E0Qeu3iGnApepkhIckjwjlEWcG+ivglUtEzAv6X1b ONNan7nVCyN7ibQmALDKqiW/LGsbM38O0C+803aye/vs4k0blZhvvALsVaV/LXmA7Zm4 qPk9JV6TZBBy5z6YR2BeJOxwgbKI4cGRsOBsRwJW1h6Eu46Y1Yi4gPy9q31qCot76VZv WB8hKdiYHLOD3A6FGKQgzvsFUxzS/qPViWOy0KPMwrrXsfyNxCoy2tjjW6SixG7Uwy6q jwLQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=S8gSEAbP; arc=pass (i=1 spf=pass spfdomain=linux.microsoft.com dkim=pass dkdomain=linux.microsoft.com dmarc=pass fromdomain=linux.microsoft.com); spf=pass (google.com: domain of linux-kernel+bounces-150517-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150517-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y8-20020aa79e08000000b006ed2669d23fsi1779745pfq.135.2024.04.18.09.53.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 09:53:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-150517-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=S8gSEAbP; arc=pass (i=1 spf=pass spfdomain=linux.microsoft.com dkim=pass dkdomain=linux.microsoft.com dmarc=pass fromdomain=linux.microsoft.com); spf=pass (google.com: domain of linux-kernel+bounces-150517-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150517-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 891CE28407A for ; Thu, 18 Apr 2024 16:53:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 06841176FA1; Thu, 18 Apr 2024 16:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="S8gSEAbP" Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E8114171E48; Thu, 18 Apr 2024 16:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713459134; cv=none; b=jbf6zsvsksrXDTKLUIzTkhAJNsogx3sZo7seDhgnEN8F/Y62aiMW5LaHTf6x9AmV2KXwZ5LF4hxubOMgd7plNyGFH4qz35OwwQHZRZp7yLnegF1h1SHevt938vIxXD4ZDJfmqvIjIjJiw/r1IuhVqkxITFqyccR5svA1qNHbn0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713459134; c=relaxed/simple; bh=8VcU7ok/r82OU+vZIxsUsvhZaWe+LK6zJdpDqotEYWU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=EAGqJpcySOuGL/CkJybB/pKv+MQ4c4WM4uKkc9gg1MC9EQwIRCQ7pmJbfak7CTP8N1Q6xMAzOfyBSuWvxq59lh7iWEyBTqzRt/Iz9rrX/mo2hmd1liALtTyVOVYkGz0HLeSGGwbUgip+T2GxTDwyytsLZYgpKFnwt3G5R0RtL9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=S8gSEAbP; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id 8B5A920FD8ED; Thu, 18 Apr 2024 09:52:11 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8B5A920FD8ED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1713459131; bh=/x44WfF5SQjqBQwqGks3DVpPDx/QzjlIKoFfU1B3cvY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S8gSEAbP7oFx+NXohcWbfbRDEZnrNibtPJo/tafCfJDOu8lxWfIdQRXsklDU6SH++ lr1jGiv6YQLHwZOtyntrpeh6m7vaZxToEJb5wMEio3qQWX+leeI079OwDmTWdBXkcq t67gKLE9aCPiRqH47oGrfZQ3fQ9MZ+MFaZZkriyc= From: Konstantin Taranov To: kotaranov@microsoft.com, sharmaajay@microsoft.com, longli@microsoft.com, jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH rdma-next 5/6] RDMA/mana_ib: boundary check before installing cq callbacks Date: Thu, 18 Apr 2024 09:52:04 -0700 Message-Id: <1713459125-14914-6-git-send-email-kotaranov@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1713459125-14914-1-git-send-email-kotaranov@linux.microsoft.com> References: <1713459125-14914-1-git-send-email-kotaranov@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Konstantin Taranov Add a boundary check inside mana_ib_install_cq_cb to prevent index overflow. Fixes: 2a31c5a7e0d8 ("RDMA/mana_ib: Introduce mana_ib_install_cq_cb helper function") Signed-off-by: Konstantin Taranov --- drivers/infiniband/hw/mana/cq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/mana/cq.c b/drivers/infiniband/hw/mana/cq.c index 6c3bb8c..8323085 100644 --- a/drivers/infiniband/hw/mana/cq.c +++ b/drivers/infiniband/hw/mana/cq.c @@ -70,6 +70,8 @@ int mana_ib_install_cq_cb(struct mana_ib_dev *mdev, struct mana_ib_cq *cq) struct gdma_context *gc = mdev_to_gc(mdev); struct gdma_queue *gdma_cq; + if (cq->queue.id >= gc->max_num_cqs) + return -EINVAL; /* Create CQ table entry */ WARN_ON(gc->cq_table[cq->queue.id]); gdma_cq = kzalloc(sizeof(*gdma_cq), GFP_KERNEL); -- 2.43.0