Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp179327lqt; Thu, 18 Apr 2024 11:39:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVRd8lLog5aRZ5kvkfDc6//zneqiRYeggteToO3viDD3Xr2W7EpeRbq8/Agd3E9qJdPAuB5uLfdo0f6kzHA28E7af4cKvu+bg5nPeNZyg== X-Google-Smtp-Source: AGHT+IEE6ixYsRGWS7NBOVM2ULRs6/kzX49iQmbfh+wMdn1WFoLBPjJn4r53GkcprLYp4ZjQmZHi X-Received: by 2002:a05:6871:3210:b0:22e:9792:97ed with SMTP id mo16-20020a056871321000b0022e979297edmr3496476oac.38.1713465585949; Thu, 18 Apr 2024 11:39:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713465585; cv=pass; d=google.com; s=arc-20160816; b=MXJfXGo3BYl4orXhYliBPlQy7uGPjvfQ9+CYtESN/tXxlVCn+O94YTYL7uCsB3y3R8 5nHQiewcdXsGqCTvac3w+9tj3M2omyqT3gO3OLzLyBjAD/7z7x0rAhhMrV0MQO+KD9pU 1Nlm9n4JdxgqGQ8AqJtE1QUSboZ7Tk7k1Obt2ywB/6NYXb0zFmbRI1r/An+2gfRkmFos AO3eKGjiNPiL4XduuD1UawQ7OlRDCenMdRlNgcCbOXSpTEH9f/+zi5Hnafih7SW6cb/Z AF6yr+Jj7R9cUP5ngEq1tYm0KAAXQdABB1buFoRWwUIfGs5IIVrnOY+QD3lp90Ekubim ZTng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1NHcpbW6y3BZbQqvYCxr7LToRLFCWxCOy6hjQ/k0/AI=; fh=JIjVh0v1dlB+ZL/7qsySN/Gq6RNt7VJqriMUCyfa3vY=; b=zZ71nFjb9yBlJnvTdL2jsz+DQdqNDyptaAPvOZPwUKwgMRoikiEPLJ9MMRPQlCGLM4 teChrDXudrqoCXqhxynKVlqfwDOzrIl963sGfOIqFbbq+OV9qTKIYW6JfrFm/pBBc4jZ YgRhaLDdp85zZx7TW95nNYccsEC9ytMvjq8vmoaMIfgBNasbEDUmH8YAEvpAkNgjG7zT eIgkhLYl6etNCVw9diTWjKll3OdkIHVjQmGpgPVK60Lldp015nz2MfEr9SDE8cWJlS95 2UtLf+utdvRa36fnsH7YkgCx6rAqrsGQ9SA70U1S8yFHGXmYUVcsgLtaojyhNDoYZLRO qZOg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WBDr+AbG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-150637-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150637-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id g9-20020a636b09000000b005f751e064d4si1841938pgc.783.2024.04.18.11.39.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 11:39:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-150637-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WBDr+AbG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-150637-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150637-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 87F6B2832D7 for ; Thu, 18 Apr 2024 18:39:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7613517A93E; Thu, 18 Apr 2024 18:39:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WBDr+AbG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D58316C845; Thu, 18 Apr 2024 18:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713465576; cv=none; b=X/Zh5vhG7Q3lBsuuh/EjqNuHQS4pGIXNhv+sBugzzkehNgK70afnGbnvLKmB3M6UbaTUK8k3XquKnwfcF6Y+GP+B9JshlBO9d99iy4c3ebt6VzNhIq6xVQxb0sZupbaYIX5ax9uyETv09YhSTYDPgfZglK34WGF7zYupXWEZ+aM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713465576; c=relaxed/simple; bh=x6lJS0NA7gStQdsKP4gCf9gYcQbe5tpoNsr9tDbm544=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WibI18AaKGcdjC066uCYNe0v6tLki0o1DylTvQMWyw8lpX5OMZ4XOq6rMtOlw7MHmjeUFPwpQCyWeILJ5DMqpsRiSPKxh6DjbbOgFfAWIn9x81BCCVRV893yelK+qGyM7oTfAhoI3dyiIgejocNrnBMuKzRSsG9roIOijhpB6uQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WBDr+AbG; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1694DC113CC; Thu, 18 Apr 2024 18:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713465576; bh=x6lJS0NA7gStQdsKP4gCf9gYcQbe5tpoNsr9tDbm544=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WBDr+AbG2T3QYewowJUP6w7Kw+9SbCxxx+yj1PJLE9c4jjXcyBN5LLmcKydXEYJg3 NkGlojFgq92aTTGDrOWUtXi3WoHOW1TKDYjNzc5BAFQ4fFTgyVMnrd62NMUur8qTWY rWtQHhN7Ky3uG6pDXYNFgDBaRuRYOfWL6fx0KxOcCezK6dbUK4Eee8JhS+qpmbBT+E ah0LQ3c0zPANMZtDsRd892PjKERv9ekVgypV1G/sC6Vab4FIcrLZe5R5GlGDNGC3U8 IK1rZIyC0Zq/Mmzvive2UWnlRvfxRfcAsNvdMVmgFlZCmbPYhvQaV72f4Wtxc19Rp+ hSIEOfVopz5Ww== Date: Thu, 18 Apr 2024 19:39:32 +0100 From: Simon Horman To: =?utf-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesse Brandeburg , Tony Nguyen Subject: Re: [PATCH iwl-next] iavf: flower: validate control flags Message-ID: <20240418183932.GP3975545@kernel.org> References: <20240416144325.15319-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240416144325.15319-1-ast@fiberby.net> On Tue, Apr 16, 2024 at 02:43:25PM +0000, Asbjørn Sloth Tønnesen wrote: > This driver currently doesn't support any control flags. > > Use flow_rule_has_control_flags() to check for control flags, > such as can be set through `tc flower ... ip_flags frag`. > > In case any control flags are masked, flow_rule_has_control_flags() > sets a NL extended error message, and we return -EOPNOTSUPP. > > Only compile-tested. > > Signed-off-by: Asbjørn Sloth Tønnesen Reviewed-by: Simon Horman