Received-SPF: pass (google.com: domain of linux-kernel+bounces-150636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <36453f2f-3a2f-ae8b-215f-da9972f14d6d@amd.com>
Date: Thu, 18 Apr 2024 13:38:49 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v3 02/14] x86/sev: Make the VMPL0 checking function more
 generic
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev,
 svsm-devel@coconut-svsm.dev, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 Dan Williams <dan.j.williams@intel.com>, Michael Roth
 <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1711405593.git.thomas.lendacky@amd.com>
 <1b0d8ec8e671ad957a2ad888725ce24edeedf74a.1711405593.git.thomas.lendacky@amd.com>
 <20240417114658.GHZh-2sk47TZgCp4Mb@fat_crate.local>
 <505dcf34-93ff-643c-b149-8ef9ce90c023@amd.com>
 <20240417205048.GHZiA2KGbFFTQFyTAM@fat_crate.local>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240417205048.GHZiA2KGbFFTQFyTAM@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UkhZaW9ieXB0Rlp4ME9OVU1jbmNYLzE2NS90aGU4ZTdhRnZQekhDMHhiN3ZF?=
 =?utf-8?B?M21UVHNpNlFoQ2pOMEpXVnRtdjhMZGNVcEhjaFhpNk5NOERIQ3MvSTV3NllL?=
 =?utf-8?B?QVJLcmxxeFFuWDNsYkl0VnlqZHBwZlc4TkZmcFBLK29PWHgxTGRjRWdHcnZr?=
 =?utf-8?B?TWk0bkEvYlFNZXpsVVhnakorV3VqKzRWN1dOUThPbGV4emFSYytnSWluME1t?=
 =?utf-8?B?dXgwcERHSFUwWjI1Nmx4cGppV3gzK0VSN0N1OXlsbFhOUVpGcjZzc01UVFlC?=
 =?utf-8?B?Ni84akQxbEV5OGFqM1RFVWkzeTAxZjB4ZXVFamlVUWw5V0VLaTZnNWUzaXZj?=
 =?utf-8?B?WWtNYXdKS0tvdWhvY2ljWFRqcm14U2szRXBuUXg4aXp1NTJjUjBXMnJnZlUz?=
 =?utf-8?B?ZC9IeWpvb3NFVDA5aVBCL0p6V2tEdEJpZjliczl6WXc1cnY3VnZNSWxpRzlJ?=
 =?utf-8?B?Yzk4VGpBcXlhVWVzVEwxc3I2TkFlY3dEUlNsaGRiTjN2ZVlXYWl6dDZPRVlP?=
 =?utf-8?B?TXJCc3BrT2dSZGhJSlBlY0JoUk4vS3AvdkhhOEJaV0E4MDJSSVFDalFjLzFE?=
 =?utf-8?B?SC81TDF4QjQrOFBIZmJDWmlxeEJ3Z3NlMmNydmY4Sk9sUHpYcnlJYUN5dFMr?=
 =?utf-8?B?OHVyNDUvT3RseDNGQmFyNkwzM1pkRzBKSFozeXBBN01JN3NySktIVE03amJI?=
 =?utf-8?B?WFUwMi9tbGs3WHdBb01Mclc0SERnQ2xMd1JuTW1rM2gyNVYyaEd0VzdFZjdN?=
 =?utf-8?B?VUprYnRzaDEySDU5SldlNU1SemhxNm9yRnlzbnJEQWs0eDBHSGFUWlJTaFNx?=
 =?utf-8?B?bTBsdXVlTUVITzU2TktwMnFDN1BsaDd3elc0QlZxK0RtQ1g2NURXU2F5S2JF?=
 =?utf-8?B?MEhjNlN4MTA0Q1d3dVYzOEtkS3ZaZXVGeEF3V3E3MVFzcXFwTi9Wc0NwMU9k?=
 =?utf-8?B?cENwRWJ4VkRicUdDakRqL0NsYXFzaVViRkNpZFNFVEZrazFzMkZLcWtaN3dJ?=
 =?utf-8?B?ME5TNTBMRzNjUFNOS0FvMlBvUElhV1JhbUltNUNCeWJhc2xCVkt3cUoyeVQ4?=
 =?utf-8?B?UkFzVngyQzJodWVEYUtmUDJUWkdxdU1kUTRaM2VqcC8vM3NnTy9wbG5hdU9D?=
 =?utf-8?B?S05oaVpFd1hyT3c1U2liNVMwckZxYjBKYVg0UFlGcEx0VWZKcjhTRG9KOC9z?=
 =?utf-8?B?eUIvTDllU1lsUUhHVlRPSjZWQ3FvR3lqZ0RhTjlhb2F2NjdKaFVMZTBjN0Zw?=
 =?utf-8?B?YUpKUVBTVDJESnZCTDFlWkxFeXp1VDZ6TjA2VDd2M1NlcURqcm8wemV5WmZK?=
 =?utf-8?B?QTBMRTF6Z044Ukpta1lXYkl5cU5SRmx2S0FmSVVsS25CdWZKS05GSDV3aFE5?=
 =?utf-8?B?RTFRakpMKzBDTDBZSWNxUXdLUjVzeWNvYXZpZENrcTkwelJTbng3K1UxYytl?=
 =?utf-8?B?RlYwV1J5SHQweDhvNzNodDA3RnpDNUxNYjRzeE9hb0tkeUpXOXhybjI1eUFT?=
 =?utf-8?B?SHk4cjNTUWFnUnNUWks4UGgyQ1FPaENTNWRlbzVmM2IxN1k4WVFnVmxNVDY3?=
 =?utf-8?B?UnB3UWRtTGErRUZmMkl1SjJ2UGVvMVNqYmJRbld3eGxPNXN2TTZER2tvRFUz?=
 =?utf-8?B?akIyRlhiOUtBMXpheGtndUZGMFN5N0hkaDVFYjhHQlc3bmcrQkRpKzRWbjhO?=
 =?utf-8?B?OVlDNXhJOFhPS0JNRkp3K0hNb1VmOFZ5V2lETFdqS2JJa0pkUHVNL0d5c2I1?=
 =?utf-8?B?cnBsbXJ4NTZMRnN4UGd3V1RBMmlqY2xuQXBPOWhHaWJtNWExYmhIaDBoWjJU?=
 =?utf-8?B?M2NaTURiaHFOcU1WakdRaU1nb1RuaFVLVGRaL2JRaSsyMEJyb3NxSlhnWVdT?=
 =?utf-8?B?ZlNFa0lxRDQ2Y252SU5qcUJHeXpxeGh6SzhOZEhrZ1FrdWNLZFdRNWI3cHdr?=
 =?utf-8?B?dERaMW1IOUkyTE5NcERUMnBFclhLZnZpbXZHSndTUVUzMGk5dC84Z2hNRTZD?=
 =?utf-8?B?NE1kUDRtWjgyRzFEaTJneHJOZDM1UlNCdHhVb2kwMTBWbDVnbXZwNzFyQjFr?=
 =?utf-8?B?YTdRSHJoY2FMa3RvbE9qcTR1dWZKMytJWWxwWjI2cllaSmE1dmpHTlg0YVFk?=
 =?utf-8?Q?hKhFXurtBrVYSPT4Dr4pPzEVj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a8bed4c-bfda-444a-17ca-08dc5fd6cb8a
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 18:38:52.3625
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yLKLcALUofcjOPF9S1VyOa39XsfW+33drnYp2V6U8TcGE8S7sgOS0eVgZmyoeg18AkPyeuXybLBonZUC0wwzNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7590

On 4/17/24 15:50, Borislav Petkov wrote:
> On Wed, Apr 17, 2024 at 03:35:53PM -0500, Tom Lendacky wrote:
> 
> Yap.
> 
> The point is, it is calling RMPADJUST. And it does modify RMP
> permissions of a guest page.
> 
> Thus, if you prefer, you can go all out and call the helper
> 
> 	rmp_adjust_permissions(unsigned int tgt_vmpl, void *pa)
> 
> and make it generic from the get-go.

I think I'll just eliminate the function then and call rmpadjust directly, 
that should make it clear.

Thanks,
Tom

> 
> And then have the macro wrap around it in order to explain that
> particular use with the macro name.
> 
> If it is still not clear what I mean, lemme know and I'll do a diff
> ontop.
> 
> Thx.
>