Received-SPF: pass (google.com: domain of linux-kernel+bounces-150651-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 18 Apr 2024 21:50:01 +0300 (EEST)
To: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
cc: Hans de Goede <hdegoede@redhat.com>, corentin.chary@gmail.com, 
    platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, 
    "Luke D . Jones" <luke@ljones.dev>
Subject: Re: [PATCH v1 1/1] platform/x86: asus-wmi: add support for vivobook
 fan profiles
In-Reply-To: <20240418181057.2688-2-mohamed.ghanmi@supcom.tn>
Message-ID: <772e3de4-4e42-474e-8a7f-75e592756053@linux.intel.com>
References: <20240418181057.2688-1-mohamed.ghanmi@supcom.tn> <20240418181057.2688-2-mohamed.ghanmi@supcom.tn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-1091724370-1713466068=:986"
Content-ID: <b26a45ef-4e93-3195-e1bc-1456a1a7cc01@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1091724370-1713466068=:986
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <fa09e14c-8e07-1dd4-a33d-8cec3c7f03ee@linux.intel.com>

On Thu, 18 Apr 2024, Mohamed Ghanmi wrote:

> Add support for vivobook fan profiles wmi call on the ASUS VIVOBOOK
> to adjust power limits.
>=20
> These fan profiles have a different device id than the ROG series
> and different order. This reorders the existing modes and adds a new
> full speed mode available on these laptops.
>=20
> As part of keeping the patch clean the throttle_thermal_policy_available
> boolean stored in the driver struct is removed and
> throttle_thermal_policy_dev is used in place (as on init it is zeroed).
>=20
> Signed-off-by: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
> Co-developed-by: Luke D. Jones <luke@ljones.dev>
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
> ---

> @@ -3618,38 +3623,38 @@ static int asus_wmi_custom_fan_curve_init(struct =
asus_wmi *asus)
>  }
> =20
>  /* Throttle thermal policy *********************************************=
*******/
> -
> -static int throttle_thermal_policy_check_present(struct asus_wmi *asus)
> +static u8 throttle_thermal_policy_max_mode(struct asus_wmi *asus)
>  {
> -=09u32 result;
> -=09int err;
> -
> -=09asus->throttle_thermal_policy_available =3D false;
> -
> -=09err =3D asus_wmi_get_devstate(asus,
> -=09=09=09=09    ASUS_WMI_DEVID_THROTTLE_THERMAL_POLICY,
> -=09=09=09=09    &result);
> -=09if (err) {
> -=09=09if (err =3D=3D -ENODEV)
> -=09=09=09return 0;
> -=09=09return err;
> +=09if (asus->throttle_thermal_policy_dev =3D=3D ASUS_WMI_DEVID_THROTTLE_=
THERMAL_POLICY_VIVO) {
> +=09=09return ASUS_THROTTLE_THERMAL_POLICY_FULLSPEED;
> +=09} else {
> +=09=09return ASUS_THROTTLE_THERMAL_POLICY_SILENT;
>  =09}

Thanks for the update, braces are unnecessary here. Other than that, this=
=20
looks fine:

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

(This was not v1 any more, although the v1 was sent not by you but
Luke).


--=20
 i.
--8323328-1091724370-1713466068=:986--