Received-SPF: pass (google.com: domain of linux-kernel+bounces-150657-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <9a18b752-c13a-4b46-ae71-59b8372dd953@quicinc.com>
Date: Fri, 19 Apr 2024 00:31:51 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] i2c: i2c-qcom-geni: Add support to share an I2C SE
 from two subsystem
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <andersson@kernel.org>,
        <vkoul@kernel.org>, <andi.shyti@kernel.org>, <wsa@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <dmaengine@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>
CC: <quic_vdadhani@quicinc.com>
References: <20240327101825.1142012-1-quic_msavaliy@quicinc.com>
 <ccb312aa-3c4c-41bb-a3f4-b94971edb346@linaro.org>
 <b7125064-4b20-438e-ac1d-7107d28b1bf9@quicinc.com>
 <f4cbacca-c2e7-42e7-8ed9-dbc6bb59f1ce@linaro.org>
Content-Language: en-US
From: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
In-Reply-To: <f4cbacca-c2e7-42e7-8ed9-dbc6bb59f1ce@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

Hi Konrad, Thanks for confirming your preferences.

On 4/16/2024 5:14 AM, Konrad Dybcio wrote:
> 
> 
> On 4/2/24 08:21, Mukesh Kumar Savaliya wrote:
>> Thanks Konrad for detailed review. For dt-bindings sending a separate 
>> patch soon, rest comments tried to address and updated patch V2.
> 
> [...]
> 
>>>> +    if (of_property_read_bool(pdev->dev.of_node, "qcom,shared-se")) {
>>>> +        gi2c->is_shared = true;
>>>> +        dev_info(&pdev->dev, "Multi-EE usecase with shared SE\n");
>>>
>>> How would this line be useful in my kernel log?
>>>
>> It informs that particular SE is shared between SEs from two 
>> subsystems, hence respective debug can happen accordingly in case of 
>> the issue.
> 
> This amounts to "not very useful". As an end user, I couldn't care less
> about the nitty-gritty of firmware-hardware interactions, so long as the
> thing works. You must not spam the kernel log with debug messages, as it
> slows things down and makes actually useful messages harder to spot. If
> you want to keep it, use dev_dbg.
> 
Sure, will go with the dev_dbg. I am uploading a separate patches for 
i2c and GSI DMA sub system.
> Konrad