Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp206761lqt; Thu, 18 Apr 2024 12:32:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU9Ssu6fTJHYAhaxMV1U3BWoPMQcRXXEqCert40WjeWRksbKwXLQvX41os0bblgWH0oEmbXJoecH8MVHNPv8lHKybDXuEKNdbgy/p2S3A== X-Google-Smtp-Source: AGHT+IFcXMRKqV+q86McICW0AJ20a73XrfWCgBemytF4g7P05+6cMBuZr+uv92ABa2Gr9ICBAy+8 X-Received: by 2002:a17:90a:77c6:b0:2a9:f861:223e with SMTP id e6-20020a17090a77c600b002a9f861223emr129993pjs.29.1713468778514; Thu, 18 Apr 2024 12:32:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713468778; cv=pass; d=google.com; s=arc-20160816; b=zII/uQPlyh8YYrJhd94GdwZUpDFc/Qmfg83BgjpUvt+g0UUI+4wPOnvfkEduJF2pQ+ zLlSc/3avV7B5/YfZUsFiSB9L2ZjAxMWBBzLI3bRMjhJvOgOmiFPq92cstLAx8R7BRvc yOmAxNlcYUZ1ZdyOJuLBVxsgGO3q07LuEuRK3YtrZg5Fkl8g2rd+Cb4jvGyduNBD2/ao hH4mMcQ5Ltr9aJy7mhclGIKDshldLUCuJ2RpXM5KX/Quvhj+jWzIWBYCVsppEs4Xffih OFXooTPmsEbHvOS7fYd2j6FQ0XNJDBUbNKGQm7JxvwOZVLOKvWmetZj8GGpiwS8K3dH4 ZHvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jS9XtXBQrZet5XPkh1K3sF1qtoObYT6Zcj9iCBqZalU=; fh=4VSRY2YZZNsxdeerOE+XFxbfuL/Gs6xY5GpsZIwMQng=; b=fB6QtcMWX44xjeo0FwhYQzYOIk5EC9tZejMGkBnyGkf1jrx3mKc2YCIqj050KEZXAh zR3Ct4l9En8lrvYWd7LdcgGYv7nVDclqglig8LH8djOlCXrO5xU1heS5SIoErmRIExRR 7+V2Flt+Lv0qqX6g5Z8FEHAN7Ha855DlM/w9XBE7oZWJWqI4TCl4yU9XcyRiywAJxgr0 OOGoSrHeCoL3MioBUI4BFkQB9mEcjfKe5mhUm1MJetLiBvXP1auvJCgbtuQauiaKhZ8z CUCCu6SKKh2oRPjlKA1EQBAHKEwncAXEc65rFz9EnaLL5NchyJFgQ37C8aFglkxU65OI bi/A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aT4+SUVu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-150667-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150667-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id c14-20020a17090abf0e00b002a28c2409c1si3763385pjs.30.2024.04.18.12.32.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 12:32:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-150667-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aT4+SUVu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-150667-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150667-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C24DD2872F6 for ; Thu, 18 Apr 2024 19:15:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 777191836F3; Thu, 18 Apr 2024 19:14:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aT4+SUVu" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D1A517AD95; Thu, 18 Apr 2024 19:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713467678; cv=none; b=NAvVorRI0tNT11tFJutM5LGYqgY8/0APLnCxda42J5ZxpAACIFGTLS3Urjc3GYWHnNnbAWI6jFSKno8qleznhtEyXfHkKIdl8rHzMs8TGhSNzZUB1TQgZRHoUVqoiLNr5BFsz4t/S07BtVplMb31ZIpaFaYW6sKnK2i7TlH2z24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713467678; c=relaxed/simple; bh=mhRK8WqHAmId8+57KRORlqSGMeDT3cBm+P8OnWokrqw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CjkSZK2GcvieDplc24DA0ooSmgrf58korpd5SiALt/siTKLctsts6fcJ8qnxbikYjo0nya67KC0IsGaFvEYGkeJbNcDrJb2ToE0p/zwuG3II4Xi+Xkp+fENHY9sZaa86rKkomJo1tK9LzdS33vYM/EmW2+sS43NIleFm2QL+mbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aT4+SUVu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83F56C3277B; Thu, 18 Apr 2024 19:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713467678; bh=mhRK8WqHAmId8+57KRORlqSGMeDT3cBm+P8OnWokrqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aT4+SUVuFxMkxXfL2gcOl9s9iruhLdqKRdEE6xlp2UAScPb0NRS8mEnYjWcKzD2P2 h1qBScI/1rOFPdcjZtxikWsPvS9gWasR+ij5aCgH2nlq9vgK0gbOrSNQoMeS40NL9s wJgc3WdAnlLG+Wd9IAEddj9XIXQ+TmkG0Jkbx22Dj5Ogm4iVN6AEyB52tB3ux3ZBFP vj5X7xeZV+yAgkMe/DGw4xiK+T300QtzA7qlUpkxyLZ69ZkBW5LB4CYLuuggVEcZaL NNM0saOA7f10D3bOHbhljsgll/WMgKBkxhpP9tXrj5hNzkDINdjMCz5GeOpZFp9+7J yCzy1R2kI4s/A== Date: Thu, 18 Apr 2024 21:14:34 +0200 From: Andi Shyti To: Piyush Malgujar Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, sgarapati@marvell.com, cchavva@marvell.com, jannadurai@marvell.com Subject: Re: [PATCH v6 4/4] i2c: thunderx: Adding ioclk support Message-ID: <3yapowxkxgsd2iq33trm7blpacmehmrbpk2jcffte7supz6ugd@lnsmw5wfj3nc> References: <20240402134018.2686919-1-pmalgujar@marvell.com> <20240402134018.2686919-5-pmalgujar@marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402134018.2686919-5-pmalgujar@marvell.com> Hi Piyush, On Tue, Apr 02, 2024 at 06:40:14AM -0700, Piyush Malgujar wrote: > Read the ioclk property as reference clock if sclk not present in acpi > table to make it SOC agnostic. > In case, it's not populated from dts/acpi table, use the default clock > of 800 MHz which is optimal in either case of sclk/ioclk. > > Signed-off-by: Piyush Malgujar just acking as a reminder to myself: Acked-by: Andi Shyti Everything looks good, if you manage to split patch 2 in two different patches, then I think it's good to go. Thanks, Andi