Received-SPF: pass (google.com: domain of linux-kernel+bounces-150728-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: iad51458e:Fastmail
Date: Thu, 18 Apr 2024 13:01:17 -0700
From: Boqun Feng <boqun.feng@gmail.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: Benno Lossin <benno.lossin@proton.me>, Miguel Ojeda <ojeda@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Wedson Almeida Filho <wedsonaf@gmail.com>,
	Gary Guo <gary@garyguo.net>,
	=?iso-8859-1?Q?Bj=F6rn?= Roy Baron <bjorn3_gh@protonmail.com>,
	Andreas Hindborg <a.hindborg@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
	Todd Kjos <tkjos@android.com>, Martijn Coenen <maco@android.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Carlos Llamas <cmllamas@google.com>,
	Suren Baghdasaryan <surenb@google.com>,
	Arnd Bergmann <arnd@arndb.de>, Trevor Gross <tmgross@umich.edu>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH v6 3/4] rust: uaccess: add typed accessors for userspace
 pointers
Message-ID: <ZiF8DcuGw1KgD4Tz@boqun-archlinux>
References: <20240418-alice-mm-v6-0-cb8f3e5d688f@google.com>
 <20240418-alice-mm-v6-3-cb8f3e5d688f@google.com>
 <5fd684d8-d46d-4009-bcf8-134dab342322@proton.me>
 <CAH5fLgiMLxmmm0AVX_5HQF61FzzN69GCKabrr-uM_oV-rRMuHw@mail.gmail.com>
 <c6239407-8410-49e2-a8a1-16be8468ab88@proton.me>
 <ZiFWIFMSBbU0i8JF@boqun-archlinux>
 <CAH5fLghTqbK-b4z_GJYJF9PFj8JkkKE+dNNpELFZspC2o9Oa1A@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAH5fLghTqbK-b4z_GJYJF9PFj8JkkKE+dNNpELFZspC2o9Oa1A@mail.gmail.com>

On Thu, Apr 18, 2024 at 09:35:53PM +0200, Alice Ryhl wrote:
> On Thu, Apr 18, 2024 at 7:27 PM Boqun Feng <boqun.feng@gmail.com> wrote:
> >
> > On Thu, Apr 18, 2024 at 04:23:06PM +0000, Benno Lossin wrote:
> > > On 18.04.24 15:17, Alice Ryhl wrote:
> > > > On Thu, Apr 18, 2024 at 3:02 PM Benno Lossin <benno.lossin@proton.me> wrote:
> > > >>
> > > >> On 18.04.24 10:59, Alice Ryhl wrote:
> > > >>> diff --git a/rust/kernel/types.rs b/rust/kernel/types.rs
> > > >>> index 8fad61268465..9c57c6c75553 100644
> > > >>> --- a/rust/kernel/types.rs
> > > >>> +++ b/rust/kernel/types.rs
> > > >>> @@ -409,3 +409,67 @@ pub enum Either<L, R> {
> > > >>>       /// Constructs an instance of [`Either`] containing a value of type `R`.
> > > >>>       Right(R),
> > > >>>   }
> > > >>> +
> > > >>> +/// Types for which any bit pattern is valid.
> > > >>> +///
> > > >>> +/// Not all types are valid for all values. For example, a `bool` must be either zero or one, so
> > > >>> +/// reading arbitrary bytes into something that contains a `bool` is not okay.
> > > >>> +///
> > > >>> +/// It's okay for the type to have padding, as initializing those bytes has no effect.
> > > >>> +///
> > > >>> +/// # Safety
> > > >>> +///
> > > >>> +/// All bit-patterns must be valid for this type. This type must not have interior mutability.
> > > >>
> > > >> What is the reason for disallowing interior mutability here? I agree
> > > >> that it is necessary for `AsBytes`, but I don't think we need it here.
> >
> > Hmm.. technically, if the interior mutability behaves in a way that each
> > byte is still initialized during the modification, then it should be
> > fine for `AsBytes`, for example and `AtomicI32` (implemented by asm
> > blocks)? Not making any change suggestion, just checking my understand.
> 
> No, that's UB. When the type is not interior mutable, then any two
> loads from the same immutable reference may be assumed to return the
> same value. Changing it with an atomic would violate that since the
> value changes.
> 

Oh, that makes sense! Thanks!

Regards,
Boqun

> Alice