Received-SPF: pass (google.com: domain of linux-kernel+bounces-150793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 18 Apr 2024 17:08:20 -0400
From: Frank Li <Frank.li@nxp.com>
To: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	Liu Ying <victor.liu@nxp.com>,
	Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: dsp: support imx8ulp dsp clocks
Message-ID: <ZiGLxBa8CMsaRSTc@lizhi-Precision-Tower-5810>
References: <20240418203720.8492-1-laurentiumihalcea111@gmail.com>
 <20240418203720.8492-2-laurentiumihalcea111@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240418203720.8492-2-laurentiumihalcea111@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6kaikUrqYMMDIbuLdyvX5SxETWxzfaVL8J2JS34lOfTUldC3S4tGHm/1mjjw?=
 =?us-ascii?Q?0XHZkSG8ybhsKt3EPTGZyg/e5D7jRgvx0kYqPUuwZJ7cqnlePMbbclDlkqM8?=
 =?us-ascii?Q?uiOht5WBDsBOyb2iZI8lUdp1C/IZUEA0FDDUVYSOIeIweT6rGYaI0U7lFl4Z?=
 =?us-ascii?Q?C7US7qwGiGT7IyukDl+V5SbpiYCkn0YKN9LjS7K9+Tn4EUzEHINj+/ZbzGez?=
 =?us-ascii?Q?9Nr/mV1vNn5O7YmjW5goZ7QVqCOUk0bsaCng8pLdYXol7+yVJoKlNSCPSgvt?=
 =?us-ascii?Q?b6NfnTyGbi9taQNGPu/+tyzMqya2ZdoF/rla/OsI5jdco+95EEzKm4fYZmoa?=
 =?us-ascii?Q?ZTkOU64szGvY9uzkKDTZMpzSXGnMJqj9Jw82Yc0iSCDwaZ4tsR82xODWoJ5M?=
 =?us-ascii?Q?WsTcOvXejiS6n8EuNWOaBgqj++pqCv0o6nBqiYmTd9YYGTjMiAFNRNdFZH9k?=
 =?us-ascii?Q?aoYOqwxz89fY1KIfe1vXOb2IiggSEdLSbfa32p6N+QKHaUD60Jl8HJqbhoq1?=
 =?us-ascii?Q?7g0BrTfXRzKZt18DBFTlK9ngxIoLe3bWDEDu/N8oMRtblPfAvGD8EmsA/Wja?=
 =?us-ascii?Q?akYQWc5BEd28uh1WUDZ9DAIAIgEVpgiSMYvtmDXH1JaRztLck/0TsTeFuJWH?=
 =?us-ascii?Q?vPycXjuCcgcJDvhiSM5HgQteoWZa0mR9M/U86FJe4h9oZqXsJuoU3ZUgRc7v?=
 =?us-ascii?Q?nk5DE7YVp7/HX9MT04hk3y+kHP7z1F4aAYhI7PbPBqsxWXm5Hvog1rLssAPe?=
 =?us-ascii?Q?9hcdMDIB4mQM6dNatSmkThRdOMTYed5XMh6Aj5Zoj3cf9OkYvzTk+F37q01C?=
 =?us-ascii?Q?YsEPdYMm6tiP2SuWhbHHwthtnv9ndE/kQHDu1bFyZC9yNFePt8vx9rGxcoxB?=
 =?us-ascii?Q?hFnwlOgu27NtPxbI41kQ1eEQvdoTZ4NpgKQ+UTurujGJoKtn6aSi8lNwe5ah?=
 =?us-ascii?Q?hD7m86WrJIp/GMOIKn3i/z5LtozkqmGwMLZUwQvrPlWDhcj6B06v2fm4whYW?=
 =?us-ascii?Q?EaErQgTDa522YzKFqvUoMi2EWQpZ54D7ECJGo7WMIxjUsLl+eRfZFSCTUU4I?=
 =?us-ascii?Q?SLMKcAnPAEbW7cfVn+gV/KgnUuzykCKsLZzUYAtGBOXYHr6qtPpGg+yK/3nZ?=
 =?us-ascii?Q?mxRPi1VETupdMsMulnsjJAdamw/+TURp9QV0EinwgIYCvmsuvLxcUD372ZnI?=
 =?us-ascii?Q?bT8QDyi2T+cy4w48avTEXqHJlEvohTgvy84Zyt8wAMK54UVJEUbS8tjNu9D9?=
 =?us-ascii?Q?2qYgl+1d2F1k9mm82Uky6h9g6D+yDdqQOpmDILfLb1QJT+I7QLghnUwoVbNn?=
 =?us-ascii?Q?ewuIwMzkItQfwWMYjh4dkmlxxkUQcouVOSpLrdEE7duRCuMkEryetWmpS4zj?=
 =?us-ascii?Q?17LmgjK/JTqUu8H8TVDnxD5WSy6P5phgPeNUvx4sv+yx2SlOkbeUXQEHQArC?=
 =?us-ascii?Q?gGNYdiIS/esQO2/ya+Cy+OZFT1eLeiMITUcI89VxlCWGNcJgyabyRADtxOYx?=
 =?us-ascii?Q?yo4RQVbMvRW7V/yYiFeRrD9Jorpo0BiAWgdUmt+9gHwlzMk6GgHKK2BojQlt?=
 =?us-ascii?Q?JPARDTwwfMBJYYCBkJhU+tCe31AeIWPjYr8eM6IF?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39414b12-3fc9-4aa0-42c0-08dc5febb265
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 21:08:29.6178
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L5veAqGTfQY3aV8rXoFRyXsa4nlKhdB8NTpWjEyKjEwrB+wnE2FBLD4o0gsNO+sU9na8lR6/WUb3Fof6yj71JA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8014

On Thu, Apr 18, 2024 at 11:37:18PM +0300, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> i.MX8ULP DSP node needs a MU clock, but doesn't need
> a debug clock. Change "clocks" and "clock-names" properties
> to allow for this case.
> 
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---
>  .../devicetree/bindings/dsp/fsl,dsp.yaml      | 51 ++++++++++++++-----
>  1 file changed, 39 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> index 9af40da5688e..4a39d57b1cc6 100644
> --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> @@ -30,22 +30,12 @@ properties:
>      maxItems: 1
>  
>    clocks:
> -    items:
> -      - description: ipg clock
> -      - description: ocram clock
> -      - description: core clock
> -      - description: debug interface clock
> -      - description: message unit clock
>      minItems: 3
> +    maxItems: 5
>  
>    clock-names:
> -    items:
> -      - const: ipg
> -      - const: ocram
> -      - const: core
> -      - const: debug
> -      - const: mu
>      minItems: 3
> +    maxItems: 5
>  
>    power-domains:
>      description:
> @@ -93,6 +83,43 @@ required:
>    - memory-region
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8ulp-hifi4
> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: ipg clock
> +            - description: ocram clock
> +            - description: core clock
> +            - description: message unit clock
> +        clock-names:
> +          items:
> +            - const: ipg
> +            - const: ocram
> +            - const: core
> +            - const: mu
> +    else:
> +      properties:
> +        clocks:
> +          items:
> +            - description: ipg clock
> +            - description: ocram clock
> +            - description: core clock
> +            - description: debug interface clock
> +            - description: message unit clock
> +          minItems: 3
> +        clock-names:
> +          items:
> +            - const: ipg
> +            - const: ocram
> +            - const: core
> +            - const: debug
> +            - const: mu
> +          minItems: 3

According to your descript, look like only clk "debug" is difference.

How about

  clocks:                                                               
    items:                                                              
      - description: ipg clock                                          
      - description: ocram clock                                        
      - description: core clock                                         
      - description: message unit clock                                 
      - description: debug interface clock

   clock-names:                                                          
      items:                                                              
        - const: ipg                                                      
        - const: ocram                                                    
        - const: core
	- const: mu                                                     
        - const: debug                                                    

allOf:
   if:                                                                 
     properties:                                                       
       compatible:                                                     
          contains:                                                     
            const: fsl,imx8ulp-hifi4
   then:
     properties:
       clocks:
         minItems: 4
       clock-names:
         minItems: 4

   else:
     propertyies:
       clocks:
         minItems: 3
       clock-names:
         minItems: 3


>    - if:
>        properties:
>          compatible:
> -- 
> 2.34.1
>