Received-SPF: pass (google.com: domain of linux-kernel+bounces-150797-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 18 Apr 2024 17:17:52 -0400
From: Frank Li <Frank.li@nxp.com>
To: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	Liu Ying <victor.liu@nxp.com>,
	Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: imx8ulp: add DSP node
Message-ID: <ZiGOAMjCyetzI+4J@lizhi-Precision-Tower-5810>
References: <20240418203720.8492-1-laurentiumihalcea111@gmail.com>
 <20240418203720.8492-4-laurentiumihalcea111@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240418203720.8492-4-laurentiumihalcea111@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WmaU9bRyxUgr0PU/jFaNpQbVe/TuNh7wENJybTwvK2sodFubTwV8ag90yVp0?=
 =?us-ascii?Q?5tDU3nDUA6DTPoThZnqyBArefmiO0EuCHgUaQebpAC/1++QB7YgeuDuSAn9M?=
 =?us-ascii?Q?VmP96A7bEqGshMvcNAwdMfy1/YedF+ml+EBql+MxXRFCd4eIvTk0jlXkeeBp?=
 =?us-ascii?Q?kmPFHaTLhwgrtn7072tOqT2uXnCdvD7c4JxZFcXO5XDKPkMIPbnxjXNhOdHh?=
 =?us-ascii?Q?8QGhfm3xYkxbHrs9PtfUIQqq52ecpYn0iCh8uAO0xIo9KuqToPeg8APuiXgu?=
 =?us-ascii?Q?BlI+md2xfs2pJ/b7lJH1Y+kXP2BJgCBOvs83X/67PcvLnxRJ6a4gn8b//8ev?=
 =?us-ascii?Q?IAISp46hWIQgQtABRRlaGMIRiBquGKcQU57QWHKAWCus0BhF7HZXzjlwTdKz?=
 =?us-ascii?Q?QMhdMyjtJMwSDV0X/ROs+6FcQ6ysu/QNxjnJrm6GYyH8tcT+sV2EbeIn9nGf?=
 =?us-ascii?Q?2mOYlCoiLBoq3NI4OjBCpFy2R6fFPJQkktQT1dq45kLCOseeak96RTpCAZqp?=
 =?us-ascii?Q?pVzQO4cY7cyf9AVo3CZc3hK0GmHUcoW9m1HV+P+1mLGWXC2lU0WrE8YMGuEN?=
 =?us-ascii?Q?77Fq81hT0H+ILWW/ULdAEgtYjmOy968sxum484iWAyG5+kKX5EhNMDje7+77?=
 =?us-ascii?Q?qYP1OZ61XaNyaLJj1vHT00rVBqmzOwR6YdE+SVbL9LVyqCn5unJ16iuUo/nR?=
 =?us-ascii?Q?Za5IIdz1ditQsIJSCBM0pLn2qdisHbjgh2j6RtI8Ro+1gPFrPt7Sp+A/BxZO?=
 =?us-ascii?Q?Mo7+FLperbjC1VE5Ck6PkxbJevr2fB2OmN2urLfSMLlzSi/y45jHXYroO1XS?=
 =?us-ascii?Q?0L3FJajVRXUtd82r/lm98Au1WI8BwR8eadhRF79/Qikb0Z1tx5l5jAqWAe5L?=
 =?us-ascii?Q?XzXqFyr6kuX5cnSNxq2uLGvho315VskhgQI6DC8yFkRwaHcIoQ9B7CaQpiEP?=
 =?us-ascii?Q?GN/M75QcQTEXrR0a/jhhiwkXDefRcN4FvOauJKv1oNeRJW8ae5ttd2RUcUjh?=
 =?us-ascii?Q?OEDK303NqW8Se1+uEaphlTgK9y49L6CgzDzvpZcGAxAHIZafA5YnvA2j4CMk?=
 =?us-ascii?Q?19xjTR2I6QyjwpwukLNIz+ZxIFr+HHZ44wA5WXJp8r+BUwuXJSQcw+4hsjAK?=
 =?us-ascii?Q?wIxCLXijoaFePO9me+I0Ui2e9LO4h9tR1wWBm49EC8AcB3gEHUJOzwA0sWsV?=
 =?us-ascii?Q?ib/3uzMuL7mc3zj0cfsVBUUYzUlN/qyn4c9yCoV9Pkp5O8zndHWRfm+1BlTA?=
 =?us-ascii?Q?hTnJfqxl23zdSehPs/2TZvYnN6nD5XWc1QwIpPNWkW31KTDnVXh9ZtPEvokS?=
 =?us-ascii?Q?2B2/Lgx/P0j5XZT29KnjbKoVefOn7O8lfcRD+mthFLbTysgVzH72GEcFlq/8?=
 =?us-ascii?Q?GVxKVxGYB5SVWumVM+MIVeasXREepkU02vZfGw1uHCUCPAyJPQbRGXkf7XrL?=
 =?us-ascii?Q?W7u9o8KZqGZ4E41F6suhBpGk/k2oXfkhLjbYO7RsyMCM84ENE9JQGKKBv03/?=
 =?us-ascii?Q?zfYN0gCdbudJxzSYaFGIHCu16wnKeVsQU7XR5dVisgEW9wTE6RQBFZ9o8gqO?=
 =?us-ascii?Q?G8z6tMip62mtQznx2tmecNMSypBdHkQU3QTdLCRA?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d34f7728-f4fa-4efc-b870-08dc5fed0757
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 21:18:01.8834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6WMmWhFZTW3LP5PeOpo3lxRHHtWkNe1nmmpBO4OHIV99bQy6s222AAEr+gPY/5EII3fj/JdfcBVDKcQBJiHoRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8954

On Thu, Apr 18, 2024 at 11:37:20PM +0300, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> Add node for i.MX8ULP's DSP core and its dependencies.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 39 +++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8ulp.dtsi    | 22 +++++++++++

8ulp.dtsi and imx8ulp-evk.dts need two patches. one for imx8ulp.dtsi, the
other for imx8ulp-evk.dts.

Frank

>  2 files changed, 61 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> index 24bb253b938d..5dadcbba370d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> @@ -67,6 +67,32 @@ vdevbuffer: vdevbuffer@a8400000 {
>  			reg = <0 0xa8400000 0 0x100000>;
>  			no-map;
>  		};
> +
> +		dsp_reserved: dsp_reserved@8e000000 {
> +			reg = <0 0x8e000000 0 0x1000000>;
> +			no-map;
> +		};
> +
> +		dsp_reserved_heap: dsp_reserved_heap@8f000000 {
> +			reg = <0 0x8f000000 0 0xef0000>;
> +			no-map;
> +		};
> +
> +		dsp_vdev0vring0: vdev0vring0@8fef0000 {
> +			reg = <0 0x8fef0000 0 0x8000>;
> +			no-map;
> +		};
> +
> +		dsp_vdev0vring1: vdev0vring1@8fef8000 {
> +			reg = <0 0x8fef8000 0 0x8000>;
> +			no-map;
> +		};
> +
> +		dsp_vdev0buffer: vdev0buffer@8ff00000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0 0x8ff00000 0 0x100000>;
> +			no-map;
> +		};
>  	};
>  
>  	clock_ext_rmii: clock-ext-rmii {
> @@ -95,6 +121,15 @@ &cm33 {
>  	status = "okay";
>  };
>  
> +&dsp {
> +	assigned-clocks = <&cgc2 IMX8ULP_CLK_HIFI_SEL>, <&cgc2 IMX8ULP_CLK_HIFI_DIVCORE>;
> +	assigned-clock-parents = <&cgc2 IMX8ULP_CLK_PLL4_PFD0>;
> +	assigned-clock-rates = <0>, <475200000>;
> +	memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
> +			<&dsp_vdev0vring1>, <&dsp_reserved>;
> +	status = "okay";
> +};
> +
>  &flexspi2 {
>  	pinctrl-names = "default", "sleep";
>  	pinctrl-0 = <&pinctrl_flexspi2_ptd>;
> @@ -176,6 +211,10 @@ &mu {
>  	status = "okay";
>  };
>  
> +&mu3 {
> +	status = "okay";
> +};
> +
>  &iomuxc1 {
>  	pinctrl_enet: enetgrp {
>  		fsl,pins = <
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c4a0082f30d3..99ed8c1ee57c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -198,6 +198,22 @@ soc: soc@0 {
>  		ranges = <0x0 0x0 0x0 0x40000000>,
>  			 <0x60000000 0x0 0x60000000 0x1000000>;
>  
> +		dsp: dsp@21170000 {
> +			compatible = "fsl,imx8ulp-hifi4";
> +			reg = <0x21170000 0x20000>;
> +			clocks = <&cgc2 IMX8ULP_CLK_LPAV_BUS_DIV>,
> +				 <&cgc2 IMX8ULP_CLK_HIFI_DIVPLAT>,
> +				 <&cgc2 IMX8ULP_CLK_HIFI_DIVCORE>,
> +				 <&pcc5 IMX8ULP_CLK_MU3_B>;
> +			clock-names = "ipg", "ocram", "core", "mu";
> +			power-domains = <&scmi_devpd IMX8ULP_PD_HIFI4>;
> +			firmware-name = "imx/dsp/hifi4.bin";
> +			mbox-names = "tx", "rx", "rxdb";
> +			mboxes = <&mu3 0 0>, <&mu3 1 0>, <&mu3 3 0>;
> +			fsl,dsp-ctrl = <&avd_sim>;
> +			status = "disabled";
> +		};
> +
>  		s4muap: mailbox@27020000 {
>  			compatible = "fsl,imx8ulp-mu-s4";
>  			reg = <0x27020000 0x10000>;
> @@ -520,6 +536,12 @@ per_bridge5: bus@2d800000 {
>  			#size-cells = <1>;
>  			ranges;
>  
> +			avd_sim: syscon@2da50000 {
> +				compatible = "fsl,imx8ulp-avd-sim", "syscon", "simple-mfd";

Any driver actually use "fsl,imx8ulp-avd-sim"?

> +				reg = <0x2da50000 0x38>;
> +				clocks = <&pcc5 IMX8ULP_CLK_AVD_SIM>;
> +			};
> +
>  			cgc2: clock-controller@2da60000 {
>  				compatible = "fsl,imx8ulp-cgc2";
>  				reg = <0x2da60000 0x10000>;
> -- 
> 2.34.1
>