Received-SPF: pass (google.com: domain of linux-kernel+bounces-150848-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240418-dts_8qm_audio-v2-0-e40fe76b60a6@nxp.com> <20240418-dts_8qm_audio-v2-5-e40fe76b60a6@nxp.com>
In-Reply-To: <20240418-dts_8qm_audio-v2-5-e40fe76b60a6@nxp.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Thu, 18 Apr 2024 20:03:52 -0300
Message-ID: <CAOMZO5B97mYVfh_JsWUOY7GE+Ag7x83mV167T3xEOY1o9YMmJQ@mail.gmail.com>
Subject: Re: [PATCH v2 05/10] arm64: dts: imx8qm-mek: add i2c0 and children devices
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, devicetree@vger.kernel.org, imx@lists.linux.dev, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18, 2024 at 1:37=E2=80=AFPM Frank Li <Frank.Li@nxp.com> wrote:

> +       lsm303arg@19 {
> +               compatible =3D "st,lsm303agr-accel";
> +               reg =3D <0x19>;
> +       };
> +
> +       fxas21002c@20 {
> +               compatible =3D "nxp,fxas21002c";
> +               reg =3D <0x20>;
> +       };
> +
> +       isl29023@44 {
> +               compatible =3D "isil,isl29023";
> +               reg =3D <0x44>;
> +               interrupt-parent =3D <&lsio_gpio4>;
> +               interrupts =3D <11 2>;
> +       };
> +
> +       mpl3115@60 {
> +               compatible =3D "fsl,mpl3115";
> +               reg =3D <0x60>;
> +       };
> +
> +       max7322: gpio@68 {
> +               compatible =3D "maxim,max7322";
> +               reg =3D <0x68>;
> +               gpio-controller;
> +               #gpio-cells =3D <2>;
> +       };
> +
> +       l3g4250@69 {
> +               compatible =3D "st,l3g4200d-gyro";
> +               reg =3D <0x69>;
> +       };

Same comment I did yesterday on another patch from you: none of these
node names are generic.