Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp359333lqt; Thu, 18 Apr 2024 18:59:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWjWQisBdRb+upf3NwhQXT+/ks2BNETrQuWNkTteuVWaWdwW0l4JWk9PQ3Qeh/zRo4DNlTBjpMwJI8EDgQy+1//jhMrm6zz53GismDu0Q== X-Google-Smtp-Source: AGHT+IEWmJjlKUcGHPX37mN26QBhPS+Xtz0Z3jdqOpTO7zWUc1VeUs0wCLCHm91Nqum/3eO8vj4Q X-Received: by 2002:a05:690c:c:b0:61a:c992:369c with SMTP id bc12-20020a05690c000c00b0061ac992369cmr760401ywb.43.1713491987881; Thu, 18 Apr 2024 18:59:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713491987; cv=pass; d=google.com; s=arc-20160816; b=Fp1PCoTsY6VaKZp9qYW3fhjo6oPaJBnkofnXT2yfUi2HoU7IpvaOl/y2oBP0xvORU1 Gy8BLQGCp2PKbgZqGGldvg9MxPuWiO8/BvuqYEso+Az8jrXmIK+8U7THY9mjIyubteq9 ld9p0PmwhlFDdwAaBfrLrgcifCT68d+Zvll5Z/pEoAhqNdKogq/P57y/r/twOR/Qbg6K XEt4Mkfw8wcWillpVCzMbKzKSJOPy3FlGzER+RdadR+j+FULWIRALTxyu5rdLrx0sSCv olxPQosUD7r3whkWn9IutHcuyH2Dv0MMDTR2NT/ElPNSwai1q0W0HZGVqw3mUqgaTCDd w70A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=q2ywmLttUMoK4v1U4w1AhQVdH6Bjo9hICwwJ+SJET04=; fh=MUR88bFMIx3vFKp/j9Y9fWtpE04vvnu3U9YY6g14FHI=; b=Mht2r1abTz6sSLDRUghSVUySJG0HlQdiJRBgDEKSQpyEZEW0ZoKbOCUtU7KPUmuqNd lXmSsv8Pkx+30zAN8GHjptUiDgFINvGyP3gxn32Ct6KIFsYKHg7t/QqBxiJg3hctpccF 6q5txglJf+BN/5lzwCLJqA5SVJI3hLivYW0t+zCNBuHWHBsdS9F/Feh4qMUeTRDunIL7 PwV01cyWjxFbxDxuDeSEydDnK1H7YIk9cnrjs5MJhEbvqPecHOuEqAEqZW/U+vaymYu6 vCbVqTtRyxSx9UahnvQ6MpfWl3byP84PhbQ01Lycew0hoNoaDBlmFYF+6QlBuhUFW2m8 Sybg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QDziLBJi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-150923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150923-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id s5-20020a05622a1a8500b0043502fb01e5si2950826qtc.347.2024.04.18.18.59.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 18:59:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-150923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QDziLBJi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-150923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-150923-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8EB071C21D50 for ; Fri, 19 Apr 2024 01:59:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4F5F24C8A; Fri, 19 Apr 2024 01:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QDziLBJi" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F0DB138C; Fri, 19 Apr 2024 01:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713491978; cv=none; b=sNJ0Ap5OZHoKOfTq8odT4K/Z7a4RrZMqCu3WHZWpsfs5EWbGAqtIjsZIi+5N/SSigssteKmoJ/1M2g6p1b8Z7tATmN3WhRmokFJCVdeuaGc1pmUrMolVNQu2G6o51NZ5kdUcLYjXNniNv6XUhawy+/Fsaca2mha5WEabkMgo3G8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713491978; c=relaxed/simple; bh=JZVoM+QdB6JxkGZNBvN6H90f7S3tp6VIhdOo4EXC2Pc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rjaC4lL7J0Ii7UAjU5SvPaBGQcTKCru+z1l2lWWSbBhJw5IASyD+z1TD70prgrA6A3auhhnjyc1qonPzrFJ+2/5IuaAhN8KJXkHFgLVfxAAsimhK71Q1mgsdhoT224IeMk9+ObijgLHzFGIfg8CPycNFl1V0sb/3BQhgrAJI8xI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QDziLBJi; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E96A1C113CC; Fri, 19 Apr 2024 01:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713491977; bh=JZVoM+QdB6JxkGZNBvN6H90f7S3tp6VIhdOo4EXC2Pc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QDziLBJi1CKzx+8mZrIz1TyoVFnB0J3QJNkCHXrXpzWzx1YBC0zPy4Vs0Y20P2aAS uwUAkvLbSf9TVuaf7YtRgUXOvmu0T5mE1WHgtCC+TpCnxxTiA8w6TxMysuOwgpPEUv r2PXulyOxW+4XYp2pOyTJSolpoA4c7NKuGO71+/PgE87bqYcp0mS0uoptiBuwXBV/J jqOXYgxBZXppgoPu8HYW6XnwI07rEhsrty53y95qOWIg5WsVQp2akvjw0slFcFfv2/ J8Tu4FK/gGUPP3l7EiNugVqZ1vL9evaxdFyjQCEP/ge8WuFLVL5fx4jxxQ2aTnfp3o r/D+PRyxRwupQ== Date: Thu, 18 Apr 2024 18:59:35 -0700 From: Jakub Kicinski To: Danielle Ratson Cc: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v4 07/10] ethtool: cmis_cdb: Add a layer for supporting CDB commands Message-ID: <20240418185935.2b0ec734@kernel.org> In-Reply-To: <20240418103455.3297870-8-danieller@nvidia.com> References: <20240418103455.3297870-1-danieller@nvidia.com> <20240418103455.3297870-8-danieller@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 18 Apr 2024 13:34:52 +0300 Danielle Ratson wrote: > +static inline u16 > +cmis_cdb_module_features_completion_time(struct cmis_cdb_module_features_rpl *rpl) > +{ > + return be16_to_cpu(rpl->max_completion_time); > +} nit: please drop all the inline in this file, the compiler will 100% inline this anyway