Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp431006lqt; Thu, 18 Apr 2024 23:07:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXgeOzMRNtVJ/7RcQ4/F/TqCQ6ueM0BA7JtPDdVUNaDXrjIhceMMpuvkoklh1hzFXs95jlHUWC85GS8HuK8Q3gT7wL5eEiSppjZ7O7q3Q== X-Google-Smtp-Source: AGHT+IE1hX5ms36frYGvODrfzyFRH4Xm7OMv1hNFbR5RRnZGm6s39odWV40HyxuPMSGbkNw964K+ X-Received: by 2002:a17:90b:3755:b0:2ac:9ee:5256 with SMTP id ne21-20020a17090b375500b002ac09ee5256mr4216946pjb.0.1713506851075; Thu, 18 Apr 2024 23:07:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713506851; cv=pass; d=google.com; s=arc-20160816; b=z+qdB91UrE1a5bSCiZf7F3tN6lTi+bbjhY2nzyZh1JdCM86bW+axNQUdTdmTHzCUKB GcmcM9A1U33nqg6GWrB+C6WHQe8n/AY3DHacchQvgvGaSZdzhiOY0AtSKrG7XdCIVNZM kIb3wWxXlo+Lz2xKUHhB73SOo7RyITpRGyb4okx3cg4jC3+JaLjhNK/MroM84gx+DemU xTxckNJSeHNoRDTh9kUeJ4J0JYlXF8JhbZ6lwjgdLU6XVpk8YjNypxzR/uTgQ3zZpQbu wY8P2jknuXB96rx5jb3AUwIyUYkBuj4B1h6un2DEoFOQoZ3ncW4PghOPRVho1W3enjzf gL6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TC5xbYJQkuB0KrYrGPpivZMrB8ng5DHf5neZWoJILog=; fh=d6BWMNttNqg36TiJ9ZgHgVrTbZRZgsPOzSKo1FxMu7s=; b=tw4Xc7/7Xhf8H0ptQCvF3oFSoWjVU3+MpoUC/n0WKWRTp4kI9jn5TjAswkQxh73iFg Yn3qCfgdz4uYgYIay6bHakS/6H1te6dRmNt1GmTV3z+Yf8cvFMulNCSV9CBz+KOYmnxD 79r27HraDW8K+v24g6HRDiIVH8mrmJvbZgZQGMc5wBmH2vtKTiID2ri1dTY9jGwC1av8 nvBLq8GBDEiDT3VogdzBqhh/bUjinCCaB4naCSuvNLR9kt6FlXXInZUa5iCU9UufMTke 1CR8rCz894DYs0s6EK5Y23afXYflZ/lm94WbH7gblxi1lfh/hABwL33IfpcpjSK8Bq7d iP/g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WNlDWGD6; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-151037-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151037-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id z16-20020a17090ad79000b002a08fd2c322si4604288pju.116.2024.04.18.23.07.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 23:07:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151037-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WNlDWGD6; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-151037-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151037-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 086D82846D0 for ; Fri, 19 Apr 2024 06:07:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25F45D51C; Fri, 19 Apr 2024 06:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WNlDWGD6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F077C121; Fri, 19 Apr 2024 06:07:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713506828; cv=none; b=kxD5dF4zadK8qUOoebkK4rmt+XDhqpCy903NwFRodDd4rQO1hbGh0sSsF/SV7pVEjg548UJYb6qfDwmOwJGz9EZ1VZqJyni7iwQ9RgCUJ4hWv8LyeKzFM4IweWdOJMVBwZRxSCQaf7+UhQHclDzUY/za3WXBgsZ6gVAKW6HjBEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713506828; c=relaxed/simple; bh=q/7us5n3dTmlIJdrg9CFZY9TJi5va1SRXgR2lP4H0mY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QErT8QvQ+5Ul7XRg7jmhlZS4glxBy2XJMN1ThSNIhnGVkEskMyamzAX3T9l9eKqo7iYmt4yFieBC2R78L2dfWZ19092IarjYGRy0C2+LTv5cTDFbzN44qDR0hmFPeyThnAViz0HqyHjPCtI5p8FaDom+XkYMzwE20YdA7EZT+zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WNlDWGD6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66657C072AA; Fri, 19 Apr 2024 06:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713506827; bh=q/7us5n3dTmlIJdrg9CFZY9TJi5va1SRXgR2lP4H0mY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WNlDWGD6iNGT6PbaoXLOdz2U8frQN5uu+XH9/a305fwMcZ+YW6LM3StUJal4BnEsl zurirrLPoWLcU45cp9pIVZstKy3XZ1WNko1G5WY5kqKfkFKmVwb5mZUAHdKUO9CrL8 wXrxf31NkhOdV5NLXji5TSN0G3sgcA75CnCaVXXM= Date: Fri, 19 Apr 2024 08:07:04 +0200 From: Greg Kroah-Hartman To: Markus Elfring Cc: Wander Lairson Costa , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org, Brendan Higgins , David Gow , Matti Vaittinen , Maxime Ripard , Rae Moar , Shuah Khan , LKML Subject: Re: [PATCH v3 1/2] kunit: unregister the device on error Message-ID: <2024041949-print-cried-85fd@gregkh> References: <20240418210236.194190-2-wander@redhat.com> <405247be-09e9-4a2d-9363-93b5862fc615@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <405247be-09e9-4a2d-9363-93b5862fc615@web.de> On Fri, Apr 19, 2024 at 07:40:43AM +0200, Markus Elfring wrote: > > kunit_init_device() should unregister the device on bus register error, > > but mistakenly it tries to unregister the bus. > > Would the following description variant be more appropriate? > > kunit_init_device() should unregister the device on bus registration error. > But it mistakenly tries to unregister the bus. Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot