Received-SPF: pass (google.com: domain of linux-kernel+bounces-151054-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <945d1e73-21f6-4a56-81ee-9625491f3b26@vivo.com>
Date: Fri, 19 Apr 2024 14:25:04 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cgroup: make cgroups info more readable
To: xiujianfeng <xiujianfeng@huawei.com>, Huan Yang <link@vivo.com>,
 Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
 Johannes Weiner <hannes@cmpxchg.org>, cgroups@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
References: <20240409021826.1171921-1-link@vivo.com>
 <9d01ab99-bbfd-536b-a375-9c44f988aa9a@huawei.com>
From: Huan Yang <11133793@vivo.com>
In-Reply-To: <9d01ab99-bbfd-536b-a375-9c44f988aa9a@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?LytGTVErMkMzTHNxNTZ3RC9zVWhXaG94RWVrTkdJZ2hrNGFVcFo4MFR1Ti9x?=
 =?utf-8?B?VGFJQ0RwdmVnWGtBUkpYd0pzRm8zTkdkTTZhcDRyWXlFeWxweDVhTGZNYlRH?=
 =?utf-8?B?RkMrakROMVpXbkJyekorMTlOSFNScE5xelpZaU5PNUdMNXZXVVNIQkJiSmNG?=
 =?utf-8?B?UDJZVklJdGY2dUJKaVgxZUtyejBzeVQ0Tk95MlU4WHhTWVM3c0IzWW5NR0cr?=
 =?utf-8?B?TEk1YkFJdHJyS1p4OUtXazVXYmpNbE5yYUkvUkFSbW85UDJ0K0dKSFFUV21E?=
 =?utf-8?B?RTRWVzhLVk5yTlJuQnNKb0h4ZHNLd29FSGVZK2k4bU95cGtlMVRkSDIwRGNt?=
 =?utf-8?B?Ym96Ris0T0VVaTdja2RyY2NyVnAxa2FvMThIUVF6SEsrRTA5emJ6WFZQQy9y?=
 =?utf-8?B?WlBPVE1vQjJSbmk2Z0FwdVQ0OFZFK3hzWkFDMkFxRnJFMm9oMEFBTmlFNmt5?=
 =?utf-8?B?TnR1UUIwZ0Mzeld6bjIzZGNNRGhTQXJwK2h1U09SWTY3aEwrekJGVnZLNmoz?=
 =?utf-8?B?UThsUTkyN2M4OG5GQis0K29UWjV0enpjUmprTWt4cjVYQk9VZmFIbFcyaWd0?=
 =?utf-8?B?U1FTa2ExeEZ6QmxTVm1qVFA2dGZ5L3B5MGJ5Qmh6UjlTL05YR1hWcDJkSTRm?=
 =?utf-8?B?MU9qdW5JaHVGWEEyYVFOYjZHbWlaTmhvR0oxMkhsU1UvNnRyamZZSXRZM0Y2?=
 =?utf-8?B?VDZBRThSZDNnSGI0T3hPZVN2V3MxYzNBa2d4cC9hOVRaWW5TaklacG1ubXNP?=
 =?utf-8?B?ZTE0ME9XeGFQbUNqYlVucEh5RVNxbjdvT2pCZDhBb1YzOXNXNHM4dHBMYmVu?=
 =?utf-8?B?ZW5BUEVtVWNzSmtKbzlBV1llanVHL3FFVDVGblNkR2ZWd0JqL3UzMDJyNnlo?=
 =?utf-8?B?NDlGL3VUVDgwTEpTWkFoQVJDUGJNc3MrZHdweUZDOGlnaTFrQ054QVZkUUpO?=
 =?utf-8?B?UGRBV3ZOZGUxS0RVS29kRjJYdEdCY3RMV1IxMFAwMGNIUVBPZFlrVHZiZWcx?=
 =?utf-8?B?UFQwVytMSUhFWldRN2MzU2UyMFU0Z3JzTWVNaXRzRkRlMG9WZGwxMm9Da2xR?=
 =?utf-8?B?cTJlcmM3a21lZy93QWw2dGF5STBWYzR1WWI4SEZzWnlDWVUvNU9PNFlpcVow?=
 =?utf-8?B?ZVlVMk41cFBnSVNuZ2srTmp2TFhRNmdIeng5dmFiajBESml0VFlUYUdGRTYy?=
 =?utf-8?B?TXRWS3BPb3N1Q08xWVdwSTRaNWE3d1N1dzlSVlFxRmROZkwrd1pDM2JpZldk?=
 =?utf-8?B?SlhuampwZ2NRZWlsd2R4aDh1ZkQzSW03Sjk5OGtwMFA2N2licm5kNUh6RlFa?=
 =?utf-8?B?WGkrTGNzSmVaVHNpWDZBbGxYS0JKTGVNdGhmZWEzbndYV0hMVEdVUmtyUG9m?=
 =?utf-8?B?R1krcXRoSjhwSEVMblZEVFhpR0gzWWxWemVEM09IbWNUK1V6K3F3eGhOSldk?=
 =?utf-8?B?QllrczdkL1dLblJmY0tkbnZRcTNFbDF6WDdneEhWYno4NEFYSitHMEMxRFJ5?=
 =?utf-8?B?d0ROZ3lEbFJFdFFHWnhjWHlWY0NhL1VQdk9EL2pWRXVZTEtCN2lGSlFScGRB?=
 =?utf-8?B?azV3dmkyc20vamd0N21WOHhKanlZWm43RW9rN2g2bUNSSnBXR1BudG1WZmkw?=
 =?utf-8?B?YVZQc3h3QnlSL0N2eldTQ0ZMaUMzZHd0czY5aHdzclhVSmtRRXhaWXJlcWo0?=
 =?utf-8?B?eW1JcEFaT1JnbW13K1BNajlCMDNVSWUrckFraHdKVVdmVXRKQ09CMjZPM0ZI?=
 =?utf-8?B?Uml4aU5OMW9RYnVPeWhneWNXdzhiaCttb1FtclhJM0RVRDNRRWNjOGd5dnFW?=
 =?utf-8?B?dTh1clU1eFB3ZWpMdmIvV1ZsaDkzVU81YmQwZkJBOEc1L25xUnFNVFNBNEZa?=
 =?utf-8?B?bzhuUEFpOEF0VlBScGlQcVEvaWtla2JUeHk2a0sxZXVkUWxCS2M3dFZUTTZu?=
 =?utf-8?B?WGtySDQraHM5bW5XRHR3QUtnNDJLMXRhZXRHTEMxTEdZc0ViSTVQQnZISU4v?=
 =?utf-8?B?UFdLeGs3Y1had0VTU3I3Q1pUY1VjdnJ5bXdSWlZrU3pBMHdRSDN1ekhVSzRu?=
 =?utf-8?B?RnJ1cUhsOWR6ZjdGRk9YYlE4cmRWV2FYWnZ0OXVDMFVFUEhqb052VHJ5R0Rk?=
 =?utf-8?Q?oVyV+P6jvVSFhKx4MlZ1JY46Y?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98369be3-3e5b-4c5a-bad9-08dc603976cd
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 06:25:10.4096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7bZ3PnLN7HFKMRIDACvOhW1bTYDhpEPxiCpQHRwWJQ9yudW3leZ8LMBbXYKSNbMz0TCxU77wwf73e/wJRRQvmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5898

HI jianfeng

在 2024/4/19 11:33, xiujianfeng 写道:
> [Some people who received this message don't often get email from xiujianfeng@huawei.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Hi,
>
> I found a discussion about this change in the email thread bellow, and
> hope it helps you.
It's helpful to know why this patch not need, thank you.
>
> https://lore.kernel.org/all/YwMwlMv%2FtK3sRXbB@slm.duckdns.org/#t

I have a question, that, now that only for cgroup1, when I running qemu 
ubuntu, I got this:

 > mount | grep cgroup
 > cgroup2 on /sys/fs/cgroup type cgroup2 
(rw,nosuid,nodev,noexec,relatime,nsdelegate,memory_recursiveprot)

Only cgroup2 mount in my system, but /proc/cgroup also worked, maybe 
better to disable this when only cgroup2 mounted?

> On 2024/4/9 10:18, Huan Yang wrote:
>> The current cgroups output format is based on tabs, which
>> may cause misalignment of output information.
>>
>> Using placeholder formatting can make the output information
>> more readable.
>>
>> Signed-off-by: Huan Yang <link@vivo.com>
>> ---
>>   kernel/cgroup/cgroup-v1.c | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c
>> index 520a11cb12f4..c082a78f4c22 100644
>> --- a/kernel/cgroup/cgroup-v1.c
>> +++ b/kernel/cgroup/cgroup-v1.c
>> @@ -669,15 +669,16 @@ int proc_cgroupstats_show(struct seq_file *m, void *v)
>>        struct cgroup_subsys *ss;
>>        int i;
>>
>> -     seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\tenabled\n");
>> +     seq_printf(m, "%16s %16s %16s %16s\n", "#subsys_name", "hierarchy",
>> +                "num_cgroups", "enabled");
>>        /*
>>         * Grab the subsystems state racily. No need to add avenue to
>>         * cgroup_mutex contention.
>>         */
>>
>>        for_each_subsys(ss, i)
>> -             seq_printf(m, "%s\t%d\t%d\t%d\n",
>> -                        ss->legacy_name, ss->root->hierarchy_id,
>> +             seq_printf(m, "%16s %16d %16d %16d\n", ss->legacy_name,
>> +                        ss->root->hierarchy_id,
>>                           atomic_read(&ss->root->nr_cgrps),
>>                           cgroup_ssid_enabled(i));
>>