Received-SPF: pass (google.com: domain of linux-kernel+bounces-151058-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 18 Apr 2024 23:28:48 -0700
From: Richard Cochran <richardcochran@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Mahesh Bandewar <maheshb@google.com>, Netdev <netdev@vger.kernel.org>,
	Linux <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>, Arnd Bergmann <arnd@arndb.de>,
	Sagi Maimon <maimon.sagi@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>, John Stultz <jstultz@google.com>,
	Mahesh Bandewar <mahesh@bandewar.net>
Subject: Re: [PATCHv1 next] ptp: update gettimex64 to provide ts optionally
 in mono-raw base.
Message-ID: <ZiIPIKM1rH7J-Pok@hoboy.vegasvil.org>
References: <20240416215942.150202-1-maheshb@google.com>
 <20240417182445.019fb351@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417182445.019fb351@kernel.org>

On Wed, Apr 17, 2024 at 06:24:45PM -0700, Jakub Kicinski wrote:
> On Tue, 16 Apr 2024 14:59:42 -0700 Mahesh Bandewar wrote:
> >  		if (extoff->n_samples > PTP_MAX_SAMPLES
> > -		    || extoff->rsv[0] || extoff->rsv[1] || extoff->rsv[2]) {
> > +		    || extoff->rsv[0] || extoff->rsv[1]
> > +		    || (extoff->clockid != CLOCK_REALTIME
> > +			&& extoff->clockid != CLOCK_MONOTONIC_RAW)) {
> 
> Since you're touching this condition it's probably a good opportunity
> to fox the coding style.

What is the CodingStyle violation?

Is it starting a line with  ||  ?


Thanks,
Richard