Received-SPF: pass (google.com: domain of linux-kernel+bounces-151079-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 19 Apr 2024 09:01:21 +0200 (CEST)
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
cc: Julia Lawall <julia.lawall@inria.fr>, 
    Ricardo Ribalda <ribalda@chromium.org>, Denis Efremov <efremov@linux.com>, 
    Nicolas Palix <nicolas.palix@imag.fr>, cocci@inria.fr, 
    kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [cocci] [PATCH] coccinelle: misc: minmax: Suppress reports for
 err returns
In-Reply-To: <f1f47166-00d7-49f3-9b80-34aa7b7b5510@web.de>
Message-ID: <1530259-fe0-eb35-6f8a-58f272adef5@inria.fr>
References: <20240415-minimax-v1-1-5feb20d66a79@chromium.org> <alpine.DEB.2.22.394.2404182255010.3213@hadrien> <f1f47166-00d7-49f3-9b80-34aa7b7b5510@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-533158061-1713510082=:3432"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-533158061-1713510082=:3432
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT


On Fri, 19 Apr 2024, Markus Elfring wrote:

> >> Most of the people prefer:
> >>
> >> return ret < 0 ? ret: 0;
> >>
> >> than:
> >>
> >> return min(ret, 0);
> >>
> >> Let's tweak the cocci file to ignore those lines completely.
> …
> > Applied, thanks. (Coccinelle for-6.10 branch).
>
> Was a planned code adjustment published?

There is no "planned code adjustment" if there is no patch.

I can check the dependencies again.

julia

>
>
> …
> >> +++ b/scripts/coccinelle/misc/minmax.cocci
> >> @@ -50,11 +50,26 @@ func(...)
> >>  	...>
> >>  }
> >>
> >> +// Ignore errcode returns.
> >> +@errcode@
> …
> >> -// Don't generate patches for errcode returns.
> >> -@errcode depends on patch@
> …
>
> How does such a change fit to the usability of the coccicheck operation modes
> “context” and “org”?
>
> Should dependencies be reconsidered any more for the desired consistency
> of involved rules for scripts of the semantic patch language?
>
> Regards,
> Markus
>
--8323329-533158061-1713510082=:3432--