Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp457921lqt; Fri, 19 Apr 2024 00:24:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUOtknUbkbsdC1m2+lMSZRBImA7mLO/r32z+oG5x8ewt46Mv+iA/+O57J0zVhsdBDsbf2hn6sDrhxKf2sLkcBlgHu+XsBSzrB2EWRs94g== X-Google-Smtp-Source: AGHT+IFBmwt8Li9huufWNv3hq/Ih22GtVb2l9ugfUoMCJxA1CjjACxGjhX6lx/ZujOuObabk9I7t X-Received: by 2002:a2e:b752:0:b0:2d8:60a4:cfa with SMTP id k18-20020a2eb752000000b002d860a40cfamr671332ljo.41.1713511444771; Fri, 19 Apr 2024 00:24:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713511444; cv=pass; d=google.com; s=arc-20160816; b=U4Ky48HGMsjnx18nJxyZ36sDdbrby1ptMQyfvg/Xq37Opxxu7hwSIDI7kmi1+J4XkZ oN43s5SEX+W69XAn2gPmYS5thIHosbZkNeE8LR15rHzd2VPJTy9vFaBIzLeWv2OMsrl3 qS89cEMwho7LWZvhYei8T80vIHSrRVW3x0fGdz22BDoE6eZg9eUFw2R0p/Cs4NxxgmmQ 1DT8UbGzbh+Lt/mENLggbPn6AxoDRvouPp3p7TzuKXHASEH9X7Lrd//3OZ4buhCvy2IG WT5Zm4gygYhOtoa64tKMCKyR4dOFblU5ECMXNsWADT9VSr/dJeLaaMiaSeq4Y8FIbQJv kI2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=y6+LJ/HKVZ3t3mY/lApMl/GxR/GrG1RUjmP1/5KDxJs=; fh=Pb/9XsUDC8tdfm9K3KPs4LtC3UstkC3CsXAVijcDK6g=; b=rzWBdSEb1z7VrRZGcEvl1LlNqsKvDGpq7Mbib44vdoyifvRuiNok05EBa2SUWSVcnF 5PQfwKZzqWp2SS2OVlo5R3vHrZ2e2u8rn9KJlHcz5Y+VKFApf5Z1Ja9zUenmvxQuuiMt xq0EA/REYcZCeoQrbrgfT59wm57ngc/FxUqNKG3d73LoJYelN5zSu3MA9TCRK/4VDiFJ 5Ft5548H4HVninbm3li1My/sHA0koKJ3+vMP9FxsPhsb6GnBe3MNN7XK4hdWepM/LW6a AsELWkB5Og3ilgkerZPkxyUcfuaKX6ejT+kgEy1b6jyq14NMX1FWSrI2sFgFdm89uwD3 BuVg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=Ajstnip1; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au dkim=pass dkdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-151099-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151099-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id cy28-20020a0564021c9c00b0056fe3f28babsi1779465edb.160.2024.04.19.00.24.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 00:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151099-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=Ajstnip1; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au dkim=pass dkdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-151099-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151099-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 461BC1F219F6 for ; Fri, 19 Apr 2024 07:24:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8898A60263; Fri, 19 Apr 2024 07:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="Ajstnip1" Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4FF84688; Fri, 19 Apr 2024 07:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713511371; cv=none; b=geFI45h73cI9PXcGcZmmIGx9+WLZgZzUQW1StYrhI62OeDv3a49p7TVS6+MWsAnsfny28m1tWJGh2m11rAZVnMttUKTE2cBKTEretrlj7q/JxCgZHeTdqUetl3br7sG8Sgl3jpDHOBsaF5HKpNS0SzDfvjnTOSYvCTQJSZGlFIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713511371; c=relaxed/simple; bh=CEuAYloiZrQnIKJVjmfowJD2YH1xfOErl7xwt1bPHhM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=D1R/rtHQXl6WlT8ccY5N8Y4dDp3Z+ml9NlJd/qhYEZOO2wtOwhJpk+ZB4HRf3e3sv+hZICvY0xaKNe1ZfvQCU9AEAOs4mSXHlmLpJiJ7H+sB+u/kCMOuXkVFz2AAIuxf9ZS+JKq5O0AcL/VeHd4kvHG0GM9hXcptRKJmsUS1gxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au; spf=pass smtp.mailfrom=ellerman.id.au; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b=Ajstnip1; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ellerman.id.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1713511364; bh=y6+LJ/HKVZ3t3mY/lApMl/GxR/GrG1RUjmP1/5KDxJs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ajstnip1AJQziYYZob5+/WWQw9OkiQ6HqYW6enqSgR3T/CWGp6JpdFQzdsfgccveC waF4b2KpmGDJhW0uaIjTruByYiknefTsAbDI1CsuVxIlgr8/egc0ybcsQUt/stAUIl raR314f9lFE/RXTMwibjefIPDZ5AB0qSRczs793ZKaBylcevAra8Aht5IRKNIO774t aG3dAb/4j2sOMbQ5Iwk3E6LlLVt1iq7SfpU3a55AkDG8Tl4O8gD7WxKyVt/tO8JQz4 7Nt41dgDBlJelLCvurGlsjRwLg8I8J1MJ2FAUJ37oJvYirJXZTHvc5s+9d7acvo/rM EtC7Y6dv3fK3A== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4VLR1c0rdDz4x0D; Fri, 19 Apr 2024 17:22:43 +1000 (AEST) From: Michael Ellerman To: Chris Packham , Andi Shyti , Abhinav Jain Cc: "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "skhan@linuxfoundation.org" , "javier.carrasco.cruz@gmail.com" , Julia Lawall , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup In-Reply-To: <2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz> References: <20240415161220.8347-1-jain.abhinav177@gmail.com> <2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz> Date: Fri, 19 Apr 2024 17:22:43 +1000 Message-ID: <87plulakak.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Chris Packham writes: > On 16/04/24 08:54, Andi Shyti wrote: >> Hi Abhinav, >> >>> /* Enable I2C interrupts for mpc5121 */ >>> - node_ctrl = of_find_compatible_node(NULL, NULL, >>> - "fsl,mpc5121-i2c-ctrl"); >>> + struct device_node *node_ctrl __free(device_node) = >> How have you tested this? > > I'm not sure I know anyone that still has a mpc5121. Maybe someone on > linuxppc-dev? Not that I know of. The driver loads on my T4240, but doesn't hit the right paths to test this patch. No objection to it being merged though. cheers